From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD750C4332F for ; Tue, 12 Apr 2022 09:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377686AbiDLJuV (ORCPT ); Tue, 12 Apr 2022 05:50:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352326AbiDLJmd (ORCPT ); Tue, 12 Apr 2022 05:42:33 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E45A13E0F for ; Tue, 12 Apr 2022 01:51:32 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id w18so21466387edi.13 for ; Tue, 12 Apr 2022 01:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=VyKuoVOFtbJpQqYL42DYs7vEqjn6TG+3AG+tuB3ScVs=; b=R4JpCrbTrv7VPod1/4uHIpPG60WwEs6xdg5RD47te/xuroYSMJV17AJ9kTj+IjCRfl 1vvR6A9B+eDfXxQpkBMMoUr1qtN8ZykBYccQDCshfgpuJSIW6r2x+qMueE6JZN8/31sv NyxM36AjZiwkWybsHCh+WNLUkZD/m+HTzhkVN5d3GsSnz+TOnW+oZ6DWwlnQHfFNEKt9 8gi6kCzc/6dfh+pI59Xll/cqC4SVrUG0AYHSAy1sC30xGWHvUIYFVVrzPJp0NTKtNUrU FC70CNLpMPZ8gckRC69enVnqUIZkm5W9p4O3G3x5WYY7IOVJDDiJcmOAAI8CsfkInQX8 5p5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VyKuoVOFtbJpQqYL42DYs7vEqjn6TG+3AG+tuB3ScVs=; b=fddac/QUPp/1Ltpw4zKgcRlnbkSsxyaXrlreejH/8gLs8M/zAkFXsOeDX1W0d5lUcK cJPvvlM3zpso1pG6jUA2PWYk4NtYqg+Bp1wilm9EWfuW2mxlHddI8/MSg6r/qKjI7Ijn Luq6+It2hmsjhLWrOeyKUkya7ih7wowpP2o+72y5wPqc7rT6mfp5km5Y17rPxhdG717a ik2/7BnABVnrUi3hpL6muS7cpTVVxXQqT6aUlgfFZBa2xULz3iH/STJDtkTqiJM0zdsC stPuvETzAhzJC6Jl8pz5qlgjq+bYN3hglBvnmT//OxO0+dlsfJ3zyjv7POLEMQ8r/PJQ sEYA== X-Gm-Message-State: AOAM531FCbwF1R8qu8l4AK51PzdYrfMR8gGKkcjFV3XkIhdPr33JloD0 CeI2UZpi/FVwK/i/tUeWfAD/4Q== X-Google-Smtp-Source: ABdhPJzhgwKUzzSz6he1cnlPJJ1RdVI6ilJSVC2f6gsXEHJNEA9nt9WQDY78OnBYwejeXogZpjSQFA== X-Received: by 2002:aa7:cac4:0:b0:418:85b7:adec with SMTP id l4-20020aa7cac4000000b0041885b7adecmr37427381edt.231.1649753490825; Tue, 12 Apr 2022 01:51:30 -0700 (PDT) Received: from [192.168.0.194] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id g2-20020a50bf42000000b0041cc5233252sm13505771edk.57.2022.04.12.01.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 01:51:30 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 10:51:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 2/2] PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver Content-Language: en-US To: Johnson Wang , Krzysztof Kozlowski , cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org, kyungmin.park@samsung.com Cc: khilman@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220408052150.22536-1-johnson.wang@mediatek.com> <20220408052150.22536-3-johnson.wang@mediatek.com> <76d58182-2f56-32b2-42e9-2ecbdd09ba3d@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/2022 10:39, Johnson Wang wrote: >>> +static struct platform_driver mtk_ccifreq_platdrv = { >>> + .probe = mtk_ccifreq_probe, >>> + .remove = mtk_ccifreq_remove, >>> + .driver = { >>> + .name = "mtk-ccifreq", >>> + .of_match_table = of_match_ptr(mtk_ccifreq_machines), >> >> You use of_match_ptr() so is it possible to build it without OF? If >> so, >> then mtk_ccifreq_machines needs maybe_unused. >> > > No, this driver must be built with OF due to our CPU arch. COMPILE_TEST does not use your arch... There are stubs for most of of-like functions, so !OF should build anyway. > Should I add some dependencies in Kconfig to ensure OF is enabled? There are different ways to solve it and it depends on what goal do you want to achieve? One ways is to use maybe_unused and of_match_ptr. Other way is to do not use them (skip both). Best regards, Krzysztof