From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCF1A3939B4 for ; Mon, 9 Mar 2026 10:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773053520; cv=none; b=oMmnHYAxgXodrBPvHAVOuDeJWUayl8PIre6m3x4CQOnZ47RfbYj3oNMdw0Cbj3WexqBO7IPtzNnSmVUbsrqogvK89bC8lq7/t2RPVXYVgZpYgQRha2re1/5yPY6iIoLhnv3+5VPVwq7Y0erWUG9MR3Lwr/l/FFmX9+O2dORqHZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773053520; c=relaxed/simple; bh=Uyatg7jYdLH+dz9BKcMrBo73IYn9xt/IAQZ4UWxi8ag=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=omvg0SooDYPV6vDDiavbUmi0fqePRK8Z0G7PQhZTpkDbf4lhWvzAsLiYKAbmuB7HflBGlDW/TuBoNzkb9DK1sNt8x091qTXZ1C/Q1Q9UfjbjcQfMcqf9Yc6kuvqwMpK6LrBurPPCZs59rmOhDzlcZkquhU7b5+moStOgo/lqwY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=O7fq2pYT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eUFudLs0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="O7fq2pYT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eUFudLs0" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62988TEh3477078 for ; Mon, 9 Mar 2026 10:51:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4mKFMEgxGg2tAs5QNXTAVvhLuUyFSnfWBYIFIYGINQ4=; b=O7fq2pYTp0/nngie bm+8nlA2wDVptpio5ybsAK4s4AahMyxrgqRHo0xaz1oT4IpDQtqKQpi4OdjI+1BF jrciEFefEPXxvvhNGHIk7vEbjL7QAc/p9J8tPtU95bEJidOlLtOglfI+eKz1ZphY ASTUkYKqbQeaVxN3soiie2TUi2UuQ5IFMAZ+2A7M9HJscJpArx0Fmr6UUiiADpoH wB1r3HMpipMvjEpjLbWdAZY4RjzTSb6DmrqSR9FbHLKA6X5A7xLBSlKlGGuKTmGQ egbZOcNtZSPuvu0p0Y5kOJHArMYOUki3R4LNCpzi898PJ9OPxuO11U9pXRMjfxSc 9esuxg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4crcd8d0fj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 10:51:57 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35982c5940cso5935645a91.1 for ; Mon, 09 Mar 2026 03:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773053517; x=1773658317; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4mKFMEgxGg2tAs5QNXTAVvhLuUyFSnfWBYIFIYGINQ4=; b=eUFudLs0Ut/ynoq5JFbkTHmxsnZG9j4IYmM+g/vlRIRb+8OxQc1OMh0gSnWV6c1NiK JLXMWylTREShQwJBiENWSq+Aq+7vcxmHgbOhbKubEH+9+xn6acWqWmpOiLSnLJ5fPnUu ryDvJKQ0iuQQJZrI3/mNb0fPLMhCJVpQgPMnIYnjUAqSqo4SXVj96+k4tA24IE1jBLhV eNHJYVECeDE1yLvwJWtNTJkdkjRnhSd0F2PN7l5kwBGGzmK7mwk6cW5E94jWd6s6lrIM VqAywDLisZhN3H2V29hZ+pnh6wKjycNY8cWiA6jb2Fh/sjI8KEben3vlrdBsNacbp4tU WsJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773053517; x=1773658317; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4mKFMEgxGg2tAs5QNXTAVvhLuUyFSnfWBYIFIYGINQ4=; b=LYdohvn2cGJOnmArvNWUYxvU/dnIa3i3d0bcebhhz0nyJlTMaIx1FYYUVfq5GCrCuh r4UflZNTSdb3iqxWYKKyh7P8rPpRzDnkErMTdPM9k69G/KbWA824BxXUGaBLbrapQ1pU emQk7O95rvuJsP8hE6YCRPg0ivG3ZiCmr6D9BFx5jvCSOeIk5y12hS07zrOcKJiimq3Z PgBtfIrLM4fpCoTIHYkIlyjCATygktvROCFNhG13qOX7oqBD81TOg57RUsdqENZxFG0P riGXcDe9iDdIAsfNX1eZ4jXjkVYA747198sFU7CbAsk9Bxu67K+9Bz/gV9dcpyL+HOaP YOCQ== X-Forwarded-Encrypted: i=1; AJvYcCWjV6P2l7sOp9z4Z76D6Qgzq0QPmmoHH4+8NGhlidxBkp3FQlgjVu6pW9ymOoK5/zjQG4oq22N0zjPhbH0=@vger.kernel.org X-Gm-Message-State: AOJu0YwUBe/K71UmvKjeB/7qY5uz0g8rfjJ6pbk4ekTYU9g1UetsMz54 mV2zptcHZ3/STlgQiBN81BwlykOIdpIVD/CKFLr6+crFyunirg+wiwZeuambj5Fx+rqT/mqSN0Z ogW34NaikuWm2jWWEARmf/nnMhGo3BWwTI11eeJLpEs4pGbsTDLwmrV6xKDy5GruTsIg= X-Gm-Gg: ATEYQzz4FKqJNj+O3vrfEwZ+jN68OxdvHTdOec5ZtgEs7RNNtIsdqq+WcVIFlnDAINm GpQr5ndaPJzTVUeKn7KsEdzEbmyO2D2gN3J2jUJif8WkGxZD195ZJ7pqAM3nYV9oz4RSuhjt1WO 4urQjpMsMz1m6peSiLiw0GRYEYBs575f85XpqK0glwNYs1UEIxkaRi0IisoSzRj6Ulg9nYBqeha U8GutF+QH6cM3Zz76YoXtdAFGHSmALW8j5KEvkvaVmZ7ADxQb8FaKCbxOVrErVuwrzTxV8C+qow xpcXOAS+jkmHYEOVeQac952kU//gexwTGjpHtRz71ZuORi57mTkpnB/pHkQTOS39k9r13tZVfpD wRhAdxgXzZvPfM4ngn8hCCXwc7/3vG/n+gazy2wgJzhva3Z9UFHXEUZMbCDj92UQppgD9jyXrtr perDNXxX7EhmQuER+zsByScmhkYkXZe/eCtbjMv+I= X-Received: by 2002:a05:6a20:548d:b0:398:7a05:f0b7 with SMTP id adf61e73a8af0-3987a05f0d0mr5545679637.58.1773053516735; Mon, 09 Mar 2026 03:51:56 -0700 (PDT) X-Received: by 2002:a05:6a20:548d:b0:398:7a05:f0b7 with SMTP id adf61e73a8af0-3987a05f0d0mr5545652637.58.1773053516239; Mon, 09 Mar 2026 03:51:56 -0700 (PDT) Received: from [10.190.200.237] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e0acde5sm8494350a12.7.2026.03.09.03.51.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 03:51:55 -0700 (PDT) Message-ID: Date: Mon, 9 Mar 2026 16:21:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 4/5] arm64: dts: qcom: x1-crd: Add Embedded controller node To: Krzysztof Kozlowski Cc: robh@kernel.org, krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, bryan.odonoghue@linaro.org, ilpo.jarvinen@linux.intel.com, hansg@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260308233646.2318676-1-sibi.sankar@oss.qualcomm.com> <20260308233646.2318676-5-sibi.sankar@oss.qualcomm.com> <20260309-festive-prudent-ibex-f8b601@quoll> <3eaceb96-003b-47d2-9ae5-bb676dde0240@kernel.org> Content-Language: en-US From: Sibi Sankar In-Reply-To: <3eaceb96-003b-47d2-9ae5-bb676dde0240@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Su24eT1wLEUdtyHCqCil1Sy4m3_Q3pz- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDA5OSBTYWx0ZWRfX5wpsmk+397tE EtgkaoVMWFRh3PUQGZ+0Uxm7qzD9yTgfWuzU5AbGSKuElReBaWzPOU0fD42/TdrdOXBpKX1t0Zv md/4mxDbxRpYdKeZDEvQkBXxpUj41TKFSr5AUW9lYQZq8yYeSBm3DXXKTo/iySO9sBUmQFCXHOn H/aLBUiuWn23nbjnyuFNrkIhk2M3hNaPswmTZTaXu8lYS1u3S/GJQFeaDzg+IMNL7cBa+5UMxn3 jjD3hSUPzKmGjGFSUGtQ1woILK66j/4wv7KgCHAhjgBG+iYv/Rwd0FzYu6JxhzdiOM9XtJaJOCs QRPawZJ2KL9pGKpGd16ZVG5A3VI2gNJMx0JEnglWmEbA+EyuvxjsOhMo4pldRlCgDxFWUCL7qY1 GObeyraHkwjoAs9kQAr8wvpTUK2mjAsPBF3jLIwIpgswW1y1x68Xi/8EfXV3WOFJLp6CgIYO0tw 45hHK9r668rz1lMNKEg== X-Authority-Analysis: v=2.4 cv=O/w0fR9W c=1 sm=1 tr=0 ts=69aea64d cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=J0bc_HPAM6LSsZCXcSwA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: Su24eT1wLEUdtyHCqCil1Sy4m3_Q3pz- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090099 On 3/9/2026 2:39 PM, Krzysztof Kozlowski wrote: > On 09/03/2026 10:03, Sibi Sankar wrote: >> On 3/9/2026 12:55 PM, Krzysztof Kozlowski wrote: >>> On Mon, Mar 09, 2026 at 05:06:45AM +0530, Sibi Sankar wrote: >>>> Add embedded controller node for Hamoa/Purwa CRDs which adds fan control, >>>> temperature sensors, access to EC internal state changes and suspend >>>> entry/exit notifications to the EC. >>>> >>>> Signed-off-by: Sibi Sankar >>>> --- >>>> arch/arm64/boot/dts/qcom/x1-crd.dtsi | 16 ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >>>> index ded96fb43489..29a1aeb98353 100644 >>>> --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >>>> @@ -1042,6 +1042,16 @@ eusb6_repeater: redriver@4f { >>>> >>>> #phy-cells = <0>; >>>> }; >>>> + >>>> + embedded-controller@76 { >>>> + compatible = "qcom,hamoa-it8987-ec", "qcom,hamoa-ec"; >>> I don't see updates to other x1e boards, thus my arguments from v2 stay >>> valid. It's wrong to call it "hamoa-ec" since only one Hamoa board has >>> it. All of other Hamoa boards apparently do not have it. >> >> Hey Krzysztof, >> Thanks for taking time to review the series :) >> >> What other Hamoa boards are you referring to? The series >> mentions that the driver and bindings is meant for Qualcomm >> Hamoa/Purwa/Glymur "reference" devices, so it only covers >> CRD and IOT-EVK. It definitely does not cover all Hamoa boards >> boards like you are assuming. > hamoa-ec compatible implies that and that's something I raised in v2 > already. You need a specific compatible. Hamoa/Glymur reference devices can have different EC MCUs depending on the SKU. This introduces the need to deal with possibility of quirks and bugs introduced by these differences. Hamoa/Purwa CRDs and IOT EVK runs on IT8987, while Glymur reference devices run on NPCX498/488. This pretty much was the rationale to make the MCU part of the compatible. Anyway I can keep it as qcom,hamoa-ec and qcom,glymur-ec for now and add specific compatibles when we upstream those boards? > > > Best regards, > Krzysztof