From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760044AbcIMTHB (ORCPT ); Tue, 13 Sep 2016 15:07:01 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:45106 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759627AbcIMTG6 (ORCPT ); Tue, 13 Sep 2016 15:06:58 -0400 Subject: Re: [PATCH 1/2] usb: dwc3: Add ref clock period setting To: Rob Herring , John Youn References: <20160912140940.GA12684@rob-hp-laptop> CC: Felipe Balbi , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Rutland , "Thinh Nguyen" From: John Youn Message-ID: Date: Tue, 13 Sep 2016 12:06:56 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160912140940.GA12684@rob-hp-laptop> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.140.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/12/2016 7:09 AM, Rob Herring wrote: > On Thu, Sep 01, 2016 at 02:32:30PM -0700, John Youn wrote: >> From: Thinh Nguyen >> >> Added ref_clk_per for writing to GUCTL.RefClkPer which >> sets the period of ref_clk in nano second. >> >> Signed-off-by: Thinh Nguyen >> Signed-off-by: John Youn >> --- >> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ >> drivers/usb/dwc3/core.c | 21 +++++++++++++++++++++ >> drivers/usb/dwc3/core.h | 5 +++++ >> drivers/usb/dwc3/dwc3-pci.c | 1 + >> 4 files changed, 29 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt >> index e3e6983..aa54ba7 100644 >> --- a/Documentation/devicetree/bindings/usb/dwc3.txt >> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt >> @@ -50,6 +50,8 @@ Optional properties: >> - snps,hird-threshold: HIRD threshold >> - snps,hsphy_interface: High-Speed PHY interface selection between "utmi" for >> UTMI+ and "ulpi" for ULPI when the DWC_USB3_HSPHY_INTERFACE has value 3. >> + - snps,ref_clk_per: value for GUTCL.RefClkPer field that sets the period of >> + ref_clk in nano seconds. > > Use '-' rather than '_' and add a unit suffix (property-units.txt). > Ok. We'll change it to: snps,ref-clk-period-ns John