mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Tarun Alle <Tarun.Alle@microchip.com>
Cc: arun.ramadoss@microchip.com, UNGLinuxDriver@microchip.com,
	hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: phy: phy-c45: Auto-negotiaion changes for T1 phy in phy library
Date: Mon, 9 Dec 2024 17:54:12 +0100	[thread overview]
Message-ID: <ad3f19b8-20fc-41c9-bfd0-e5f9996da578@lunn.ch> (raw)
In-Reply-To: <20241209161427.3580256-2-Tarun.Alle@microchip.com>

On Mon, Dec 09, 2024 at 09:44:26PM +0530, Tarun Alle wrote:
> Below auto-negotiation library changes required for T1 phys:
> - Lower byte advertisement register need to read after higher byte as
>   per 802.3-2022 : Section 45.2.7.22.

Is this a fix? Does Linux have any T1 PHYs which already support
auto-neg? Either add a comment this is not a fix because...., or
please pull this out into a patch for net, with a Fixes: tag.

	Andrew

  parent reply	other threads:[~2024-12-09 16:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 16:14 [PATCH net-next 0/2] Add auto-negotiation support for LAN887x T1 phy Tarun Alle
2024-12-09 16:14 ` [PATCH net-next 1/2] net: phy: phy-c45: Auto-negotiaion changes for T1 phy in phy library Tarun Alle
2024-12-09 16:48   ` Russell King (Oracle)
2024-12-09 16:54   ` Andrew Lunn [this message]
2024-12-10  6:39     ` Tarun.Alle
2024-12-09 16:14 ` [PATCH net-next 2/2] net: phy: microchip_t1: Autonegotiaion support for LAN887x T1 phy Tarun Alle
2024-12-09 17:03   ` Andrew Lunn
2024-12-10  6:42     ` Tarun.Alle
2024-12-09 17:11   ` Andrew Lunn
2024-12-12  8:47     ` Tarun.Alle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad3f19b8-20fc-41c9-bfd0-e5f9996da578@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Tarun.Alle@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=arun.ramadoss@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®