From: Shuah Khan <skhan@linuxfoundation.org>
To: "John B. Wyatt IV" <jwyatt@redhat.com>,
Thomas Renninger <trenn@suse.com>
Cc: linux-pm@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, John Kacur <jkacur@redhat.com>,
"John B. Wyatt IV" <sageofredondo@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] pm: cpupower: gitignore: Add compile_commands.json
Date: Mon, 30 Sep 2024 13:55:27 -0600 [thread overview]
Message-ID: <ad442d07-4c04-4be5-9273-3970e7f41a55@linuxfoundation.org> (raw)
In-Reply-To: <20240930172330.7076-1-jwyatt@redhat.com>
On 9/30/24 11:22, John B. Wyatt IV wrote:
> A compile_commands.json file is used by the LSP in tools like VSCode and
> Neovim to look up function and type information. The file is specific to
> the state of the current system; add it to the gitignore.
>
> Note: the kernel root's gitignore has a similar entry:
>
> /compile_commands.json
>
> I am not sure why they use '/' for a file as it is used for directories.
>
> Signed-off-by: "John B. Wyatt IV" <jwyatt@redhat.com>
> Signed-off-by: "John B. Wyatt IV" <sageofredondo@gmail.com>
> ---
> tools/power/cpupower/.gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/power/cpupower/.gitignore b/tools/power/cpupower/.gitignore
> index 7677329c42a6..5113d5a7aee0 100644
> --- a/tools/power/cpupower/.gitignore
> +++ b/tools/power/cpupower/.gitignore
> @@ -27,3 +27,6 @@ debug/i386/intel_gsic
> debug/i386/powernow-k8-decode
> debug/x86_64/centrino-decode
> debug/x86_64/powernow-k8-decode
> +
> +# Clang's compilation database file
> +compile_commands.json
Thank you. Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower
It will be included in my next pull request to PM maintainer.
thanks,
-- Shuah
prev parent reply other threads:[~2024-09-30 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 17:22 John B. Wyatt IV
2024-09-30 19:55 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad442d07-4c04-4be5-9273-3970e7f41a55@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sageofredondo@gmail.com \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®