From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Carlier <devnexen@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Avi Fishman" <avifishman70@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: npcm: fix unbalanced clk_disable_unprepare()
Date: Tue, 14 Apr 2026 11:51:26 +0300 [thread overview]
Message-ID: <ad4ADuwCgRGO99u2@ashevche-desk.local> (raw)
In-Reply-To: <20260411123517.15083-1-devnexen@gmail.com>
On Sat, Apr 11, 2026 at 01:35:17PM +0100, David Carlier wrote:
...
> ret = devm_request_irq(&pdev->dev, irq, npcm_adc_isr, 0,
> "NPCM_ADC", indio_dev);
> if (ret < 0) {
> dev_err(dev, "failed requesting interrupt\n");
Also consider killing this message as it dups what IRQ core prints already.
> - goto err_disable_clk;
> + return ret;
> }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-14 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 12:35 David Carlier
2026-04-11 12:46 ` Nuno Sá
2026-04-14 8:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad4ADuwCgRGO99u2@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andrew@codeconstruct.com.au \
--cc=andy@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devnexen@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®