From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Alisa-Dariana Roman" <alisadariana@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Alisa-Dariana Roman" <alisa.roman@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] iio: adc: ad7191: Don't check for specific errors when parsing properties
Date: Tue, 14 Apr 2026 12:31:08 +0300 [thread overview]
Message-ID: <ad4JXGgVLkwjLHwb@ashevche-desk.local> (raw)
In-Reply-To: <ad4Dd2hlVdw16xgg@nsa>
On Tue, Apr 14, 2026 at 10:10:38AM +0100, Nuno Sá wrote:
> On Sun, Apr 12, 2026 at 03:30:40PM +0100, Jonathan Cameron wrote:
> > On Tue, 17 Mar 2026 12:42:07 +0200
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
...
> > I left this one for a while to see if the discussion would continue but seems not.
> > I'm not sure it is always the case, but in this particular example I think the
> > resulting code is a little nicer to read so applied.
> >
> > So for me, case by case basis for this sort of change.
>
> Yeah, I missed this one! Anyways seems the way will be to explicitly
> use device_property_present() to check property presence. Still don't
> love the dual call thing so I might just stop checking for -EINVAL (was
> not doing it religiously anyways).
>
> Maybe we could have a set of optional variants of the API like
> device_property_read_*_optional() kind of thing where we just return 0
> if the property is not present. But might also be too noisy...
I think that's what usually Sakari likes (tons of wrappers for each case :-).
I prefer be on the compromise side.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-14 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 14:39 Andy Shevchenko
2026-02-20 10:04 ` Nuno Sá
2026-02-20 10:33 ` Andy Shevchenko
2026-03-17 10:42 ` Andy Shevchenko
2026-04-12 14:30 ` Jonathan Cameron
2026-04-14 9:10 ` Nuno Sá
2026-04-14 9:31 ` Andy Shevchenko [this message]
2026-04-14 9:33 ` Andy Shevchenko
2026-04-14 10:02 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad4JXGgVLkwjLHwb@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=alisa.roman@analog.com \
--cc=alisadariana@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®