From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F954370D45 for ; Wed, 6 May 2026 07:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778052247; cv=none; b=YCOsFYZA7LyQIMuRybiO2P3LFUB6ocYwsuC998ugA27INRa7xjJ8fubIDlV5jndBS03PWO3NHFVcKNYg7FTkEzAZs83TLTnpT9z/gP0rhBioJnpiOYEQtMXRDFMsFa+VycD/5Fqua51C0/j5BvRoUzq4uZoejmHIf9DvHbVAD/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778052247; c=relaxed/simple; bh=9Txn1bCLhaBrW9GSBvOIK6rfzG5OCHasTAFNQG+D6CI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=psek90ww+9uunYF65JkqqRXNr940B9O13H9TkLhOfg0+EREP+geRHJ/FlBPwiwGIbi9XzNaursQ5paqZNX/e93hizzZPFkeRdDl/HHWR2HwYWXIRnQyoXiE0SGy4t9kFF1xMYhS0yyX3C727drWcvhVM38qNnSoIVW3RRrYEOng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZODMjYTX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bSALvkcw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZODMjYTX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bSALvkcw" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6466aqcx248341 for ; Wed, 6 May 2026 07:24:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= k4ZIoRP2u1e5bW324pFhv4+9GD5DTAsNOUVtYctmqkc=; b=ZODMjYTXggS8Mgdw zOZKwGLY4CP67fsA0s/2K8pQGqHbRKJ9epkVSWF0i1ribUhuf3PfZ0wDNsnOl+uo 0Btvi2bcW/8nvu5G2nrs2PQ3rEiYkNQFCZ0+e+PxKfBpwpeyhFJA3sOJt/orxsij g9fJCBbpns9PTqr0LuGRm+dAwhbIqfVrScfw8laOiF+7pYjIXmaklxCq95ZHXni3 T62lTt6vtCr1ztwKjZw38sGoYQBwVleeqaI1IpFLcXrlmRarqDBXjH4WxYsKDHwC 9XhSrD7DRvIr/Tqfxnq8F3B6u67S3nGUVTMB8pP3euKf2cC6MWHy2oi9LLceH+y2 0mcHDQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dyjq438j2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 06 May 2026 07:24:05 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b2d83e7461so113272215ad.3 for ; Wed, 06 May 2026 00:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778052244; x=1778657044; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k4ZIoRP2u1e5bW324pFhv4+9GD5DTAsNOUVtYctmqkc=; b=bSALvkcwskconrVZggX/saqR44yayvb75kvYQo+D1Hq9GP9ibJC+Gq3b3n/NuNQKCP 9TAX8h6CyXLDOLHICFOfrnCfo6XYfei2oks7/4GPTBS/BmrkF7nYZmQ9W8t2Eb2rX57X od3b1lyLpawa6ONBd3aeQJde/huc4MVxv14WEjEhqE7JSws5X8KvwEfE2xHr3rxG9pso osjRRjZ5kDdMuEgEG2Jro5BnnrwXjxeXOao5tQgf1+fTe7YkWgSQCuHbt/gsCio3sflQ 60Qy4ueUiYHkppfKoN2jTKauXjQsVXh8T3BmpfZ0HIkshIpr1m6tFUevvyJrzFQCG/zZ vWhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778052244; x=1778657044; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k4ZIoRP2u1e5bW324pFhv4+9GD5DTAsNOUVtYctmqkc=; b=FOqTCqX4v0/PFm+z0wJluxrwcD3vPaXrqb4mmOu0OHdgCkDB/UkxFC1j6n5lWyFRG/ qGqcoLjgZsLN4Y6EjO0xqq8burpPdxemgY4atpLqI3hebwo+3XQnAFYEzsGxeZXEcHjG W1gwMJmtchYNYMMfEqEAm28WiCsOqnptZsgQTKwsSxQHYV8OVgmB61Hm/hT+4WNhXZLX 8JG1jzYhnJArKr6NNuLJDZKSq8IPZTsHe2tzhJIHLvkw9zkptDLdYFnHC1+uTDIsdNuO jWI+w/+KZkA8o+IXTpoJiWlMUdfE1sENAfQXFedhMCyFHJHbKS5OvdgOHkvOvLsegko/ ENyw== X-Forwarded-Encrypted: i=1; AFNElJ9l4+u2JjbXjsQYyjDS/Ra3D/c3+57GvWzx8SDEDS2S0brxzYZOT3OjKXSs5jsajRKEFfLd1RslinIAoaw=@vger.kernel.org X-Gm-Message-State: AOJu0YznQAoRlu7pVGvxSaHwXzvOLRxobVoSIi8YEEshiK2GcOFn6f1p 7giYfS8t73AbPScrwVFcyVNfgyTc9eX2TayPEohGp3HZlHTMm5G9mlu7jvNbT4svEeywjVJTCqA vzAAiVN6c34+hHv3eYp0fzMcUy5VANR9t1lzzcZ396/I7hMFd8cC9Qj5rmoUO7dKQGdypMYkCtr o= X-Gm-Gg: AeBDiet2Ymd5hcmniQ1X94JakCW26QCLrIgYK0310fkKyHVAfuqdaX8Sy8Z6EInsnoh /rFAsj/ZmMpKIt8OWADsoNguf5yu88k+JdtBRWHeEzMCg35xyEU8AKDZ5T9F5ih0MBk6TGd366z a2QLZo5hIprOKuzqsmyaN+hdQbs5q0eXaYtF4AO4AMWUXD1/G7itpA+ghfZLt3VSgtswYpKcNzP xUVEFabnRFKqML259ytOSPBDdJmIdmLUL/EjChQIdhJ+yPii8rI2QoR4Y5rLwzOcP+rx1kAv1zm 2KUjrFG6BBewwcKeUKBeiUqPQ7K9Au/YgT8U/TfY5xy0IStBqCduNLPT3a0imp+1QV1o/TPo2Tm /LU86ebgJjctdqm4fjN+RHapH7Zc4G8Egp+j+xNbbCogVskg6PZ0NIzeB6QX0wTTLWMo= X-Received: by 2002:a17:903:22d1:b0:2b9:ff02:a14d with SMTP id d9443c01a7336-2ba78f799cemr23714465ad.18.1778052243739; Wed, 06 May 2026 00:24:03 -0700 (PDT) X-Received: by 2002:a17:903:22d1:b0:2b9:ff02:a14d with SMTP id d9443c01a7336-2ba78f799cemr23714045ad.18.1778052243138; Wed, 06 May 2026 00:24:03 -0700 (PDT) Received: from [192.168.0.172] ([49.205.248.139]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ba7ca37db8sm18508275ad.82.2026.05.06.00.23.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 00:24:02 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 12:53:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] media: iris: optimize COMV buffer allocation for VPU3x and VPU4x To: Vishnu Reddy , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260506-optimize_comv_buffer-v3-1-c1b4a44e4300@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260506-optimize_comv_buffer-v3-1-c1b4a44e4300@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=MYxcfZ/f c=1 sm=1 tr=0 ts=69faec95 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=EkRsrf7Hk27R9rd+nIzaeA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=M4aftBSd0jw2qhfeuUkA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDA3MCBTYWx0ZWRfX5DYX/fcsZiAK JsjZdOCkajTZqCKKRb/J+hcKvDd/eJv80SBLHay+Twcj3NG1m9ebCh6CMrSpijaSNy32jY46qDM kdyBhg30DoB0QOFgCYRCVKcfAWi6/wmHpSlQT2VVgmEoxNOegjdE0vLT8BZSnQRGee91XeARm2e p32HFMV06zxr5U98RUaosTpzk3UZ+E2PWPkvUNcOtfbO/p42GnnJ7AEk6pN7FKuBLQ+fsNE4xtj DTr8PovTL7QjnzeTMGNO8/j0/QN3OuVXwe/kSxqv2y3VfKqRTBZ6ERylh1vyJxp6/w/geqvef5o nJft5SYUkvJK63/3w/XPYq+3M9KvrnaVmEaCdaqhSzOlC8kRNV0gNtSh14YaSoYCoYfnAFF2/9D BLXKzbyR8kMbFghbOr4WkH9hKAZfxpQq2btQk420GcBxQ5NdraOXpFtQzDZTz8KKBs35RMSVnqm OYYYO0Va3qWhVlvyksw== X-Proofpoint-GUID: gTKPrxVdIv62pECfbYcrgq0BqCgdbo7l X-Proofpoint-ORIG-GUID: gTKPrxVdIv62pECfbYcrgq0BqCgdbo7l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060070 On 5/6/2026 11:42 AM, Vishnu Reddy wrote: > The existing iris_vpu_dec_comv_size() used VIDEO_MAX_FRAME (32) as > num_comv count unconditionally when calculating the co-located motion > vector (COMV) buffer size. This resulted in an oversized COMV buffer > allocation throughout decode session, wasting memory regardless of > actual number of buffers required. > > For VPU3x and VPU4x platforms, introduce iris_vpu3x_4x_dec_comv_size() to > replace iris_vpu_dec_comv_size(). These derive num_comv dynamically, it > uses inst->fw_min_count once the firmware has reported its buffer > requirements, and fallback to output count during initialization before > firmware has communicated its requirements. This aligns the COMV buffer > size to the actual count needed rather than always allocating with fixed > VIDEO_MAX_FRAME value. > > Additionally, during iris_vdec_inst_init(), fw_min_count was initialized > to MIN_BUFFERS instead of 0. This masked the fallback logic and caused the > COMV size calculation to use MIN_BUFFERS even before firmware had reported > its actual requirements. Fix this by initializing fw_min_count to 0. > > During testing of 1080p AVC, it reduces the COMV buffer size from 32.89MB > to 6.16MB per decode session, significantly reducing memory consumption. > > Signed-off-by: Vishnu Reddy > --- Reviewed-by: Vikash Garodia