From: Javier Martinez Canillas <javierm@redhat.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, "Ondrej Jirman" <megi@xff.cz>,
"Robert Mader" <robert.mader@posteo.de>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Kamil Trzciński" <ayufan@ayufan.eu>,
"Martijn Braam" <martijn@brixit.nl>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm: panel: Add Himax HX8394 panel controller driver
Date: Fri, 23 Dec 2022 21:58:10 +0100 [thread overview]
Message-ID: <ad5471ab-643c-fe4d-13cd-4984d4bb4ee9@redhat.com> (raw)
In-Reply-To: <Y6VyJhz9DTjaDUDa@ravnborg.org>
Hello Sam,
On 12/23/22 10:17, Sam Ravnborg wrote:
> Hi Javier.
>
> On Thu, Dec 22, 2022 at 11:38:27PM +0100, Javier Martinez Canillas wrote:
>> From: Kamil Trzciński <ayufan@ayufan.eu>
>>
>> The driver is for panels based on the Himax HX8394 controller, such as the
>> HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface.
>
> A few comments/nitpicks in the following.
> I have been away for a while, and paged out most of my panel knowledge,
> so read it all with that in mind.
>
Thanks a lot for your feedback! I agree with your comments and will address
those in the next iteration.
> In general - very nicely written driver.
>
> Sam
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2022-12-23 20:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 22:38 [PATCH 0/4] Add PinePhone Pro display support Javier Martinez Canillas
2022-12-22 22:38 ` [PATCH 1/4] drm: panel: Add Himax HX8394 panel controller driver Javier Martinez Canillas
2022-12-23 9:17 ` Sam Ravnborg
2022-12-23 20:58 ` Javier Martinez Canillas [this message]
2022-12-22 22:38 ` [PATCH 2/4] dt-bindings: display: Add Himax HX8394 panel controller bindings Javier Martinez Canillas
2022-12-23 8:12 ` Krzysztof Kozlowski
2022-12-23 8:43 ` Javier Martinez Canillas
2022-12-22 22:38 ` [PATCH 3/4] MAINTAINERS: Add entry for Himax HX8394 panel controller driver Javier Martinez Canillas
2022-12-22 22:38 ` [PATCH 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Javier Martinez Canillas
2022-12-22 22:57 ` Maya Matuszczyk
2022-12-23 8:38 ` Javier Martinez Canillas
2022-12-26 13:05 ` Javier Martinez Canillas
2022-12-23 8:13 ` Krzysztof Kozlowski
2022-12-23 8:44 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad5471ab-643c-fe4d-13cd-4984d4bb4ee9@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=ayufan@ayufan.eu \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=pbrobinson@gmail.com \
--cc=robert.mader@posteo.de \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®