From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1108C433E2 for ; Sat, 12 Sep 2020 07:55:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EEE62054F for ; Sat, 12 Sep 2020 07:55:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N0IshfJt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725879AbgILHzv (ORCPT ); Sat, 12 Sep 2020 03:55:51 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27984 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725817AbgILHzq (ORCPT ); Sat, 12 Sep 2020 03:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599897345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CMsih95ppexED5XQI9GoRgCwwBN6vlyz7YM0OAysBhw=; b=N0IshfJtP0QuIJNQt79W9Dz8e3VJF/wSlsK7uRYex8RqsbHlwe/ZscGtuhhUOC33qh8v+C G7R3WslOAlQ1LubZjL2YcGyyzN7T2DE3q+oISUE7WZlZShcUNatuqMokGdSzgFMXKOzv2d 72Hf6ZbVhlYakcCYpqkigqSWPd46Fcw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-463-yaMgLDbWMAWQctkZYHS9qg-1; Sat, 12 Sep 2020 03:55:42 -0400 X-MC-Unique: yaMgLDbWMAWQctkZYHS9qg-1 Received: by mail-wr1-f69.google.com with SMTP id a10so4084076wrw.22 for ; Sat, 12 Sep 2020 00:55:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CMsih95ppexED5XQI9GoRgCwwBN6vlyz7YM0OAysBhw=; b=aWC3WksIsoCkNUQqLITv+A+nb4el4Z/SzS8yylaR1yxCIBCcU3vu0FHKxTnXISaMgW /4JYqDTb7fb4+FruFCCjzQfWub18ubmdC48qpObqGjFRsORggxzbSWI1K6fp91fNNkws /fOpOyQ+C+m6X2AlG5e0YHilCVh2hCtqdkj4Vp5mSaPVZdx5kMFfp816V4xuLuoTzBSX RaRPeFPk6PHyNsEUipleYv0wagQdiv18hvNWoFLWtesp5+za60SdATml9d52hJoveJT3 GerwwtIDkRPaD/yBhoL6IYQjH+vNG01lrINFmtVrmG5vyHzXgR8XX/E6XNfgaVGzWufH yf2w== X-Gm-Message-State: AOAM531/DbIkq4vD3TtlvM3OvwEYXfLsIPrE+ql9g5/Hl4tlJkdAPxaL GyJi4QpcQR+gJxIYv/+IyhtHDCpJZFZgy/YtbZ7nDAwwVLOGzY6A6VyzQcCClqelzEoXByObPHc dfazjAJNSv4d1wIZTEsFNvzx0 X-Received: by 2002:a5d:4d51:: with SMTP id a17mr5739911wru.248.1599897341636; Sat, 12 Sep 2020 00:55:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyg6CN+GEydxbMQMopXakFuMzw3iVzO6YDM9LKHVc0oXuGeulvNCjUe0zMburgKy2PGf4Mkag== X-Received: by 2002:a5d:4d51:: with SMTP id a17mr5739895wru.248.1599897341427; Sat, 12 Sep 2020 00:55:41 -0700 (PDT) Received: from [192.168.10.150] ([93.56.170.5]) by smtp.gmail.com with ESMTPSA id j14sm8882364wrr.66.2020.09.12.00.55.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Sep 2020 00:55:40 -0700 (PDT) Subject: Re: [PATCH 1/3] SVM: nSVM: correctly restore GIF on vmexit from nesting after migration To: Maxim Levitsky , kvm@vger.kernel.org Cc: Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , linux-kernel@vger.kernel.org, Joerg Roedel , "H. Peter Anvin" , Sean Christopherson , Ingo Molnar , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Thomas Gleixner References: <20200827162720.278690-1-mlevitsk@redhat.com> <20200827162720.278690-2-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: Date: Sat, 12 Sep 2020 09:55:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200827162720.278690-2-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/08/20 18:27, Maxim Levitsky wrote: > However in nested_svm_vmexit we were first were setting GIF to false, > but then we overwrite this with value from the hsave area. Do you mean we are overwriting the resulting intercepts with values from the hsave area? If so, I can rewrite the commit message but the patch is good! Paolo