From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
Doug Berger <opendmb@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Antoine Tenart <atenart@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Yajun Deng <yajun.deng@linux.dev>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] Allow disabling pause frames on panic
Date: Mon, 3 Nov 2025 15:34:15 -0800 [thread overview]
Message-ID: <ad5d4ba5-bd30-429d-9c5c-86b3d6abe232@broadcom.com> (raw)
In-Reply-To: <20251103152257.2f858240@kernel.org>
On 11/3/25 15:22, Jakub Kicinski wrote:
> On Mon, 3 Nov 2025 11:46:29 -0800 Florian Fainelli wrote:
>> This patch set allows disabling pause frame generation upon encountering
>> a kernel panic. This has proven to be helpful in lab environments where
>> devices are still being worked on, will panic for various reasons, and
>> will occasionally take down the entire Ethernet switch they are attached
>> to.
>
> Could you explain in more detail? What does it mean that a pause frame
> takes down an Ethernet switch?
One of our devices crashed and kept on sending pause frames to its link
partner which is an Ethernet router. Rather than continue to forward
traffic between other LAN ports and Wi-Fi, that router just stopped
doing that and the other devices were frozen. I don't have the exact
model yet because this was on a different site/team but I will try to
get that. This should obviously be treated as a router bug and its
firmware should be updated, if there is an update available.
I have seen it happen a bunch of times at home as well with an unmanaged
5-port TP-Link switch and a crashed laptop.
--
Florian
prev parent reply other threads:[~2025-11-03 23:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 19:46 Florian Fainelli
2025-11-03 19:46 ` [PATCH net-next 1/2] net: ethernet: Allow disabling pause " Florian Fainelli
2025-11-03 22:08 ` Andrew Lunn
2025-11-03 19:46 ` [PATCH net-next 2/2] net: bcmgenet: Support calling set_pauseparam from panic context Florian Fainelli
2025-11-03 22:19 ` Andrew Lunn
2025-11-03 23:00 ` Florian Fainelli
2025-11-04 4:14 ` Andrew Lunn
2025-11-03 23:22 ` [PATCH net-next 0/2] Allow disabling pause frames on panic Jakub Kicinski
2025-11-03 23:34 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad5d4ba5-bd30-429d-9c5c-86b3d6abe232@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=atenart@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®