From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753165AbdBMRPs (ORCPT ); Mon, 13 Feb 2017 12:15:48 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:29382 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbdBMRPq (ORCPT ); Mon, 13 Feb 2017 12:15:46 -0500 Subject: Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support To: David Miller , stephen@networkplumber.org References: <1486748305-240339-1-git-send-email-shannon.nelson@oracle.com> <1486748305-240339-5-git-send-email-shannon.nelson@oracle.com> <20170210162208.69485824@xeon-e3> <20170211.210101.1450332574457722492.davem@davemloft.net> Cc: netdev@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org From: Shannon Nelson Organization: Oracle Corporation Message-ID: Date: Mon, 13 Feb 2017 09:15:17 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170211.210101.1450332574457722492.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/2017 6:01 PM, David Miller wrote: > From: Stephen Hemminger > Date: Fri, 10 Feb 2017 16:22:08 -0800 > >> On Fri, 10 Feb 2017 09:38:20 -0800 >> Shannon Nelson wrote: >> >>> +static void vsw_get_ethtool_stats(struct net_device *dev, >>> + struct ethtool_stats *estats, u64 *data) >>> +{ >>> + int i = 0; >>> + >>> + data[i++] = dev->stats.rx_packets; >>> + data[i++] = dev->stats.tx_packets; >>> + data[i++] = dev->stats.rx_bytes; >>> + data[i++] = dev->stats.tx_bytes; >>> + data[i++] = dev->stats.rx_errors; >>> + data[i++] = dev->stats.tx_errors; >>> + data[i++] = dev->stats.rx_dropped; >>> + data[i++] = dev->stats.tx_dropped; >>> + data[i++] = dev->stats.multicast; >> >> Please do not duplicate regular network statistics into ethtool. >> This doesn't really add any value. > > Agreed. > Okay, I'll drop this patch. sln