From: Marc Zyngier <marc.zyngier@arm.com>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: <daniel.lezcano@linaro.org>, <lorenzo.pieralisi@arm.com>,
<tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource: arch_timer: Mark ARMv8 system timer as 'always-on'
Date: Thu, 06 Nov 2014 18:09:25 +0000 [thread overview]
Message-ID: <ad6085048a3c0a42c03d623a6770e300@www.loen.fr> (raw)
In-Reply-To: <1415296639-40203-1-git-send-email-anatol.pomozov@gmail.com>
Hi Anatol,
On 2014-11-06 17:57, Anatol Pomozov wrote:
> Quoting ARMv8 Reference Manual section D6.1:
> "The system counter must be implemented in an always-on power
> domain."
Yes. And the key words here are "system counter". That's the global
counter, not the per-cpu view of that, and critically nor comparators.
The timers (per-cpu counter+comparator) will happily go down with the
CPU, and won't be able to wake it up. Exactly like ARMv7, by the way.
> There is no need to keep 'always-on' configurable on ARMv8. We ignore
> this dts property value and unconditionally set it to true.
>
> The issue was discovered while working on ARMv8 board with only one
> timer
> (arm arch timer). If 'always-on' is false then it disables
> high-resolution
> timer functionality.
Yup, and that's by design (see above). The *only* case where it is
really "always-on" is when a virtual machine is running (if the vcpu is
running then the physical CPU is, and so is the timer).
If your system really never does any form of PM, then fine, just put
the DT property in. Removing it is, I'm sorry to say, a bit short
sighted.
Thanks,
M.
--
Fast, cheap, reliable. Pick two.
next prev parent reply other threads:[~2014-11-06 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 17:57 Anatol Pomozov
2014-11-06 18:09 ` Marc Zyngier [this message]
2014-11-06 18:14 ` Anatol Pomozov
2014-11-06 18:23 ` Lorenzo Pieralisi
2014-11-06 20:46 ` Anatol Pomozov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad6085048a3c0a42c03d623a6770e300@www.loen.fr \
--to=marc.zyngier@arm.com \
--cc=anatol.pomozov@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®