From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F054C001DC for ; Mon, 31 Jul 2023 16:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233418AbjGaQ1m (ORCPT ); Mon, 31 Jul 2023 12:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233371AbjGaQ1c (ORCPT ); Mon, 31 Jul 2023 12:27:32 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B52DC1BC5 for ; Mon, 31 Jul 2023 09:27:10 -0700 (PDT) Received: from [192.168.2.174] (109-252-150-127.dynamic.spd-mgts.ru [109.252.150.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0168E6606FCD; Mon, 31 Jul 2023 17:26:56 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690820818; bh=3epO/QMQFTjkV49Ea0BqvxuXzjBbmCJzO0QJfElbI6o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iVwVxs574lxQBIXji+t3KapEUuHgAWJm4noZ24H1GkeWlALhA/dhuYRnLHhXn85hr 0GsO4CM2/e7uawL9mH+uonCaQakYjYgV5llG0sRHbZxoMo9QKnRBwjTAhpUsLGUBMM V93iptL7F/hQcD7Qr8g0C2rpPNHOwBsYohDpbpI7lbLaNSWI6ue9zZdEDL/loka3Vs YJUmjFY7Gv9dgbMbnc+/hvi8IXTgEopyP4t3i0wlv0tVX+utY+RTwBVMdtr6rfhdNm 1oCshwmBR5EwYLxXuGAtJkkj4hprZqVgTq62aZJzv4V/KDDU37lIwWluGN8RiYfcd9 0BZmNQPtT1XdA== Message-ID: Date: Mon, 31 Jul 2023 19:26:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver Content-Language: en-US To: Gurchetan Singh Cc: Rob Clark , Gerd Hoffmann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, virtualization@lists.linux-foundation.org, David Airlie , Chia-I Wu , Daniel Vetter , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Pierre-Eric Pelloux-Prayer , Emil Velikov References: <20230416115237.798604-1-dmitry.osipenko@collabora.com> <141b928d-6165-f282-b8e6-f140cb09333d@collabora.com> <4c18744d-b6cd-d517-5726-104017d0764b@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/29/23 01:03, Gurchetan Singh wrote: > On Wed, Jul 19, 2023 at 11:58 AM Dmitry Osipenko < > dmitry.osipenko@collabora.com> wrote: > >> 27.06.2023 20:16, Rob Clark пишет: >> ... >>>> Now these are just suggestions, and while I think they are good, you >> can safely ignore them. >>>> >>>> But there's also the DRM requirements, which state "userspace side must >> be fully reviewed and tested to the standards of that user-space >> project.". So I think to meet the minimum requirements, I think we should >> at-least have one of the following (not all, just one) reviewed: >>>> >>>> 1) venus using the new uapi >>>> 2) gfxstream vk using the new uapi >>>> 3) amdgpu nctx out of "draft" mode and using the new uapi. >>>> 4) virtio-intel using new uapi >>>> 5) turnip using your new uapi >>> >>> forgot to mention this earlier, but >>> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >>> >>> Dmitry, you can also add, if you haven't already: >>> >>> Tested-by: Rob Clark >> >> Gurchetan, Turnip Mesa virtio support is ready to be merged upstream, >> it's using this new syncobj UAPI. Could you please give yours r-b if you >> don't have objections? >> > > Given that Turnip native contexts are reviewed using this UAPI, your change > does now meet the requirements and is ready to merge. > > One thing I noticed is you might need explicit padding between > `num_out_syncobjs` and `in_syncobjs`. Otherwise, feel free to add my > acked-by. The padding looks okay as-as, all the struct size and u64s are properly aligned. I'll merge the patch soon, thanks. -- Best regards, Dmitry