From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Lee Yongjun <jun85566@gmail.com>,
rjui@broadcom.com, sbranden@broadcom.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: broadcom: ns2-svk: fix AT25 EEPROM node and properties
Date: Wed, 28 Jan 2026 13:07:31 -0800 [thread overview]
Message-ID: <ad644270-4236-4a71-b301-b912b0cd49f3@broadcom.com> (raw)
In-Reply-To: <20260122161823.105404-1-jun85566@gmail.com>
On 1/22/26 08:18, Lee Yongjun wrote:
> The AT25 EEPROM node on the Northstar 2 SVK board used legacy vendor
> properties and a non-standard node name, which triggers dtbs_check
> warnings.
>
> Update the node to follow the dt-schema by:
> - Renaming the node from at25@0 to eeprom@0.
> - Replacing deprecated "at25,byte-len" with "size".
> - Replacing deprecated "at25,page-size" with "pagesize".
> - Replacing deprecated "at25,addr-mode" with "address-width".
>
> For "address-width", the legacy value <2> corresponds to the EE_ADDR2
> flag in the driver (include/linux/spi/eeprom.h), which is explicitly
> defined as 16-bit addressing. Therefore, <16> is the technically
> accurate value that preserves the existing hardware behavior while
> satisfying the at25.yaml schema requirements.
>
> Signed-off-by: Lee Yongjun <jun85566@gmail.com>
Thanks for your patch, however I have something from Rob already queued up:
https://lore.kernel.org/r/20260106-dt-dtbs-broadcom-fixes-v1-9-ba45874e4553@kernel.org
You could re-submit the portion of your patch that renames the node?
--
Florian
prev parent reply other threads:[~2026-01-28 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 16:18 Lee Yongjun
2026-01-28 21:07 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad644270-4236-4a71-b301-b912b0cd49f3@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jun85566@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®