From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBB52C4167B for ; Mon, 11 Dec 2023 11:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234690AbjLKLKS (ORCPT ); Mon, 11 Dec 2023 06:10:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234590AbjLKLKP (ORCPT ); Mon, 11 Dec 2023 06:10:15 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F1E1B0 for ; Mon, 11 Dec 2023 03:10:21 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-54bf9a54fe3so6085791a12.3 for ; Mon, 11 Dec 2023 03:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702293020; x=1702897820; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=91RxGGTnrJ5WuG9IRZA1XtPRYSS4yFIRTROkLcfHYJ8=; b=u3F2IcUa0D9W0Obf2XVN8ONmN9ciO5ZkzAu4AuqDWLefTSLBAZdJJL8deOmGGhWZ30 IUst/1Sf6eKIk0FS78lk1CM0cfzMWXYPCH3DGTFmqZo2a634C2paMVO0Jde/kB8sWydP 4XohkVjLjrq3qA/eHDylyedFOH73qw5XkEMUlZW1gQO5ls5k2zLDJygS0O7dMcNHgwLG AlN9xa7e8n08Osr3wK2LGxYJUhgkWULQo5+x/lfNfy7i7qs3JZDsbg5Zv6iW9VRZpxff 4BQSXS//QnjpaxG0GjKKqZHNhayfYvGuGTSJVPaF7Ue4cUuyd2vsN598LHtz00WL0gFw zHkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702293020; x=1702897820; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=91RxGGTnrJ5WuG9IRZA1XtPRYSS4yFIRTROkLcfHYJ8=; b=DcgAjhqIZgpkCTSD3GtW8vHIBDmjIuStm0AmfNG6Q7cb94oKp+ZNv5EK1TYMvIQZEX o5DQ267De16QprW0uwEQGswS5esbBVL7kiht/HHwEa+r+jZC4iDnt9c6cTCn7ELIMMbn gk6RCDAdXPejVrd2nYPndmzVekZQ9r8uN316G+CZG1vq0fl82vUwP2pEatgEYYO9+PfP splt0e/TA6but2YfiNoxg2EQgfAoZcuwYnnbhWHLrz3XtHhSGUPNpb6zLEXWxppb4xXx /Jil3aOwMhX9qSehNsJtG7PhdqBVmjD6ecnBqzykHUC1I4Temk/zYE41kjriEynMt8mI Jl3Q== X-Gm-Message-State: AOJu0YyYekKLQJThufIn1Ozd6KwUO0YMMTOdCrKcg4deume/5iF0+u6c ssVVznp+oEwpSXeO/Gc8cKKLKQ+cOwW81UiQzfY= X-Google-Smtp-Source: AGHT+IGZA4vMfpYYJuMGy3YH/2kalo54jdDgRC5CF5WKMmndNcMCZvw2bWV8TUDavosYKEoZvTIPmw== X-Received: by 2002:a17:906:51d0:b0:a1a:5838:aec2 with SMTP id v16-20020a17090651d000b00a1a5838aec2mr2290537ejk.2.1702293020172; Mon, 11 Dec 2023 03:10:20 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id tr6-20020a170907c58600b00a1f73d6f079sm4028469ejc.84.2023.12.11.03.10.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 03:10:19 -0800 (PST) Message-ID: Date: Mon, 11 Dec 2023 11:10:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: build failure after merge of the nvmem tree Content-Language: en-US To: Miquel Raynal Cc: Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List References: <20231211164916.6f0d2357@canb.auug.org.au> <730b71e2-9c3c-4b40-86a6-0794615222fd@linaro.org> <20231211113059.094f4226@xps-13> From: Srinivas Kandagatla In-Reply-To: <20231211113059.094f4226@xps-13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On 11/12/2023 10:30, Miquel Raynal wrote: > Hi Srinivas, > > srinivas.kandagatla@linaro.org wrote on Mon, 11 Dec 2023 10:23:40 +0000: > >> Thankyou Stephen for the patch. >> >> On 11/12/2023 05:49, Stephen Rothwell wrote: >>> Hi all, >>> >>> After merging the nvmem tree, today's linux-next build (i386 defconfig) >>> failed like this: >>> >>> /home/sfr/next/next/drivers/nvmem/core.c: In function 'nvmem_cell_put': >>> /home/sfr/next/next/drivers/nvmem/core.c:1603:9: error: implicit declaration of function 'nvmem_layout_module_put' [-Werror=implicit-function-declaration] >>> 1603 | nvmem_layout_module_put(nvmem); >>> | ^~~~~~~~~~~~~~~~~~~~~~~ >>> >>> Caused by commit >>> >>> ed7778e43271 ("nvmem: core: Rework layouts to become regular devices") >>> >>> I have applied the following patch for today. >>> >>> From: Stephen Rothwell >>> Date: Mon, 11 Dec 2023 16:34:34 +1100 >>> Subject: [PATCH] fix up for "nvmem: core: Rework layouts to become regular devices" >>> >>> Signed-off-by: Stephen Rothwell >>> --- >>> drivers/nvmem/core.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c >>> index 9fc452e8ada8..784b61eb4d8e 100644 >>> --- a/drivers/nvmem/core.c >>> +++ b/drivers/nvmem/core.c >>> @@ -1491,6 +1491,11 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np, const char *id) >>> return cell; >>> } >>> EXPORT_SYMBOL_GPL(of_nvmem_cell_get); >>> + >>> +#else /* IS_ENABLED(CONFIG_OF) */ >>> + >>> +static inline void nvmem_layout_module_put(struct nvmem_device *nvmem) { } >>> + >> >> I see no reason why nvmem_layout_module_put() should be even under IS_ENABLED(CONFIG_OF). >> >> Updated the patch with this fixed. > > Ok, works for me. I will send a fixup with the doc change (see the > other kernel test robot report) so you can squash it as well with the > original patch. > if you have fix up ready, can you send it. --srini > I am surprised we get these now, I actually pushed the branch on my > Github 0-day repository and got no negative report within 3 days. > Anyway, I guess they have to prioritize the requests. > > Thanks, > Miquèl