From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Niklas Cassel <niklas.cassel@wdc.com>,
linux-kernel@vger.kernel.org
Cc: Hannes Reinecke <hare@suse.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 25/25] Documentation: sysfs-block-device: document command duration limits
Date: Fri, 9 Dec 2022 12:31:19 +0900 [thread overview]
Message-ID: <ad6c7534-14dc-d48a-f5f1-a35c649a42bd@opensource.wdc.com> (raw)
In-Reply-To: <Y5Kp/JhhwF1rjrdu@debian.me>
On 12/9/22 12:22, Bagas Sanjaya wrote:
> On Thu, Dec 08, 2022 at 11:59:41AM +0100, Niklas Cassel wrote:
>> +What: /sys/block/*/device/duration_limits/enable
>> +Date: Dec, 2022
>> +KernelVersion: v6.3
>> +Contact: linux-scsi@vger.kernel.org
>> +Description:
>> + (RW) For ATA and SCSI devices supporting the command duration
>> + limits feature, write to the file to turn on or off the
>> + feature. By default this feature is turned off. If the device
>> + does not support the command duration limits feature, this
>> + attribute does not exist (the directory
>> + "/sys/block/*/device/duration_limits" does not exist).
>> + Writing "1" to this file enables the use of command duration
>> + limits for read and write commands in the kernel and turns on
>> + the feature on the device. Writing "0" disables the feature.
>
> Sphinx reported inline emphasis warning due to unescaped asterisk above:
>
> Documentation/ABI/testing/sysfs-block-device:101: WARNING: Inline emphasis start-string without end-string.
>
> I have applied the fixup:
[...]
>> <snipped>...
>> + Possible values are:
>> +
>> + - 0x0: The device will complete the command at the
>> + earliest possible time (i.e, do nothing based on
>> + the time limit not being met).
>> + - 0xD: The device will complete the command and an IO
>> + failure will be reported to the user with the ETIME
>> + error code.
>> + - 0xF: Same as 0xD.
>> +
>
> The lists items above looks poorly indented in htmldocs (due to use of
> proportional fonts). The fix is to align to first character after bullet
> list marker, like:
Thanks for the hints. Will fix that in v2.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2022-12-09 3:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221208105947.2399894-1-niklas.cassel@wdc.com>
2022-12-08 10:59 ` Niklas Cassel
2022-12-09 3:22 ` Bagas Sanjaya
2022-12-09 3:31 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad6c7534-14dc-d48a-f5f1-a35c649a42bd@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=bagasdotme@gmail.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=niklas.cassel@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®