mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: m18063 <Claudiu.Beznea@microchip.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <nsekhar@ti.com>,
	<david@lechnology.com>, <wsa@the-dreams.de>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-i2c@vger.kernel.org>, <nicolas.ferre@microchip.com>
Subject: Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses
Date: Wed, 5 Jul 2017 12:33:52 +0300	[thread overview]
Message-ID: <ad743b8f-74a3-c349-188e-a152b1250243@microchip.com> (raw)
In-Reply-To: <20170630072032.tbnatpnh3rej4lmf@pengutronix.de>



On 30.06.2017 10:20, Uwe Kleine-König wrote:
> Hallo,
> 
> On Thu, Jun 29, 2017 at 02:39:10PM +0300, Claudiu Beznea wrote:
>> diff --git a/include/linux/platform_data/at24.h b/include/linux/platform_data/at24.h
>> index 271a4e2..d55c454 100644
>> --- a/include/linux/platform_data/at24.h
>> +++ b/include/linux/platform_data/at24.h
>> @@ -50,6 +50,7 @@ struct at24_platform_data {
>>  #define AT24_FLAG_TAKE8ADDR	BIT(4)	/* take always 8 addresses (24c00) */
>>  #define AT24_FLAG_SERIAL	BIT(3)	/* factory-programmed serial number */
>>  #define AT24_FLAG_MAC		BIT(2)	/* factory-programmed mac address */
>> +	u8		offset;
> 
> Assuming you rename the property, please adapt the member name here
> accordingly.
Sure!

Thanks,
Claudiu
> 
> Best regards
> Uwe
> 

  reply	other threads:[~2017-07-05  9:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 11:39 [RFC PATCH 0/3] Add at24 functionality to read form different EEPROM offsets Claudiu Beznea
2017-06-29 11:39 ` [PATCH 1/3] dt-bindings: i2c: eeprom: document all at24 bindings Claudiu Beznea
2017-06-29 11:39 ` [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses Claudiu Beznea
2017-06-29 11:56   ` Andy Shevchenko
2017-06-29 13:30     ` Ludovic Desroches
2017-07-05  9:31       ` m18063
2017-06-29 15:32   ` David Lechner
2017-07-05  9:33     ` m18063
2017-06-30  7:20   ` Uwe Kleine-König
2017-07-05  9:33     ` m18063 [this message]
2017-06-29 11:39 ` [RFC PATCH 3/3] dt-bindings: i2c: eeprom: document "start-offset" binding Claudiu Beznea
2017-07-06 15:45   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad743b8f-74a3-c349-188e-a152b1250243@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=david@lechnology.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=nsekhar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®