From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3381819D097 for ; Tue, 22 Oct 2024 12:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729600888; cv=none; b=L0y7/OAjv0NSXoPQW7RFrhbLKQfCsxN4Y7boFbeKFUp+14GQMVHMfCTflY65pMhh/ksCLe2E/Z12kIqAJOaXBgrT7iROhaPDQnFpi385M7mS0bOUCRZq+gkb6qMSflHjF1pKD8puNdRoZIDlLFUSelYA1zsxiqsj7nyCqV6jiIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729600888; c=relaxed/simple; bh=7ogbe9klNHIgIwWQi1odvjugDCadVyAD3zv6Rmvq2ak=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LtXDYOBx188gwROsIqlDcV5sYHAL4Rh7QK+gVXYUUZaXSgReP3qLeVMS5tlrSCeaoXOI187XYX3V/DdzhgpSzfziMiNlP1oH9mFhHU0UAQ+CtrJMiLZKLZ62/z6fkNieRgf9+/3hpQ60KyvupAJUWtYHVeSwe4esaumCBDvXil0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZDaitrPV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZDaitrPV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729600885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G77AXdhmFXzZ/ESBcMLQ3RrG4kqVBepd83akdkPaE3g=; b=ZDaitrPVAys3GtxZtA0DQEP9nxit3xZvrnoCIE3QK8f+NJDjxwxIK3j9R0kvlMCWCvYQBy tWEMINvTOp1HEm57Ya2+aT1veNmr+LD+4mIHXTwpGF04cFOGtuiJzOVjH48mFjlU3M1Vfp VcyjqRakAU+/+LE9g8NDkbGNhXDK0V4= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-ePQ_GK6IP5ytALiXNkrqnA-1; Tue, 22 Oct 2024 08:41:21 -0400 X-MC-Unique: ePQ_GK6IP5ytALiXNkrqnA-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a99f43c4c7bso383147766b.0 for ; Tue, 22 Oct 2024 05:41:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729600880; x=1730205680; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G77AXdhmFXzZ/ESBcMLQ3RrG4kqVBepd83akdkPaE3g=; b=DlkrNtKU00gzsFXoHieMXua2OGPGO1pE+fGOHKn9eX5aXGg8xpLIPr3KpMbmevLhPE WaVfO1bKw7ZQiTtQfpAo+0Jt/8NIY7HrwzvP3KD8e32u9YPl+KPIdRkMPX52JAL5pqcW pK0pkIZmu6hWSo68bVsJQEtvA9o9pYd1q0vIZu1+otJafE0d+wTShtAcroslt6kR2fJz AxPwynOnvxJqOMeEJCIAjC+ZkXylik7DnIeo0j94j+kuAyne2FpgPYl3Id8kla1MONMx Qr4Lr0FucaMg821Wvd3MN0qGRNuDj8DmrYKNf9Fe3gppJK0fa27yRTQ73s8NARHftBE6 kCFA== X-Gm-Message-State: AOJu0YyS7yod4PAVBbcSsh79nKPzE6e9z495Kmnd2CDYNXFhS2DqDe2D mUDx85OhIHvf/chLRZmOVqsELKXqnIa0Alet38LITv7r/5XU0TNUIi0nktz2Do3XOmv2EWtCGsC HArayQohyi9K0BhERzmkYM+beDswPpeShdLfLmuSsglpNjAuGPbsAsHae/Vjuig== X-Received: by 2002:a17:907:8f07:b0:a9a:7f91:8c76 with SMTP id a640c23a62f3a-a9a7f91909emr783155466b.0.1729600880471; Tue, 22 Oct 2024 05:41:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEOf16Iq8griI6UFYZrIvV7s26ph2XKRc9+xFT6FensfG/rdtXdTr+cjCcBXBOEOEpVJS42kg== X-Received: by 2002:a17:907:8f07:b0:a9a:7f91:8c76 with SMTP id a640c23a62f3a-a9a7f91909emr783153466b.0.1729600880050; Tue, 22 Oct 2024 05:41:20 -0700 (PDT) Received: from ?IPV6:2001:1c00:2a07:3a01:e7a9:b143:57e6:261b? (2001-1c00-2a07-3a01-e7a9-b143-57e6-261b.cable.dynamic.v6.ziggo.nl. [2001:1c00:2a07:3a01:e7a9:b143:57e6:261b]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a912d638fsm338112466b.18.2024.10.22.05.41.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2024 05:41:19 -0700 (PDT) Message-ID: Date: Tue, 22 Oct 2024 14:41:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform/x86: eeepc-laptop: use sysfs_emit() instead of sprintf() To: chen zhang , ilpo.jarvinen@linux.intel.com, corentin.chary@gmail.com, luke@ljones.dev Cc: linux-kernel@vger.kernel.org, chenzhang_0901@163.com, "platform-driver-x86@vger.kernel.org" References: <20241018095547.46006-1-chenzhang@kylinos.cn> Content-Language: en-US From: Hans de Goede In-Reply-To: <20241018095547.46006-1-chenzhang@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 18-Oct-24 11:55 AM, chen zhang wrote: > Follow the advice in Documentation/filesystems/sysfs.rst: > show() should only use sysfs_emit() or sysfs_emit_at() when formatting > the value to be returned to user space. > > Signed-off-by: chen zhang > --- > drivers/platform/x86/eeepc-laptop.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c > index 03319a80e114..ba36b7bf6dc4 100644 > --- a/drivers/platform/x86/eeepc-laptop.c > +++ b/drivers/platform/x86/eeepc-laptop.c You need to add a: #include when using sysfs_emit() . Please send a v2 with this fixed and please don't forget to Cc: platform-driver-x86@vger.kernel.org for the v2. Regards, Hans > @@ -285,7 +285,7 @@ static ssize_t show_sys_acpi(struct device *dev, int cm, char *buf) > > if (value < 0) > return -EIO; > - return sprintf(buf, "%d\n", value); > + return sysfs_emit(buf, "%d\n", value); > } > > #define EEEPC_ACPI_SHOW_FUNC(_name, _cm) \ > @@ -361,7 +361,7 @@ static ssize_t cpufv_show(struct device *dev, > > if (get_cpufv(eeepc, &c)) > return -ENODEV; > - return sprintf(buf, "%#x\n", (c.num << 8) | c.cur); > + return sysfs_emit(buf, "%#x\n", (c.num << 8) | c.cur); > } > > static ssize_t cpufv_store(struct device *dev, > @@ -393,7 +393,7 @@ static ssize_t cpufv_disabled_show(struct device *dev, > { > struct eeepc_laptop *eeepc = dev_get_drvdata(dev); > > - return sprintf(buf, "%d\n", eeepc->cpufv_disabled); > + return sysfs_emit(buf, "%d\n", eeepc->cpufv_disabled); > } > > static ssize_t cpufv_disabled_store(struct device *dev, > @@ -1025,7 +1025,7 @@ static ssize_t store_sys_hwmon(void (*set)(int), const char *buf, size_t count) > > static ssize_t show_sys_hwmon(int (*get)(void), char *buf) > { > - return sprintf(buf, "%d\n", get()); > + return sysfs_emit(buf, "%d\n", get()); > } > > #define EEEPC_SENSOR_SHOW_FUNC(_name, _get) \