From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>, Wanpeng Li <kernellwp@gmail.com>
Cc: kvm list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Radim Krcmar <rkrcmar@redhat.com>
Subject: Re: [PATCH] KVM: nVMX: Fix CR4 after VMLAUNCH/VMRESUME failure
Date: Thu, 8 Feb 2018 17:40:37 +0100 [thread overview]
Message-ID: <ad78ef46-7471-c095-0dd9-a5d5fbe85698@redhat.com> (raw)
In-Reply-To: <CALMp9eT30t6J0jWsOrpWdUikFaVSTSW7RDGGYB1R17ZEiJAP9Q@mail.gmail.com>
On 08/02/2018 16:54, Jim Mattson wrote:
> On Thu, Feb 8, 2018 at 7:29 AM, Jim Mattson <jmattson@google.com> wrote:
>> Similarly, the correct L1 CR4 value should be in vmcs01's CR4
>> read shadow field.
> Sorry; that's wrong. L1's CR4 value has to be reconstructed from the
> vmcs01 guest CR4 field and CR4 shadow field using the cr4 guest/host
> mask. But there is no way to get it from any field(s) in vmcs12.
Now that we have the prepare_vmcs02_full/prepare_vmcs02 split, we
probably should do more checks in there, and not rely on the processor
anymore.
Paolo
next prev parent reply other threads:[~2018-02-08 16:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 11:04 Wanpeng Li
[not found] ` <CALMp9eQNB+2KLAR2Tv+By2oTthRLvAQMmJiEs61kFNrZDct3_g@mail.gmail.com>
2018-02-05 18:24 ` Jim Mattson
2018-02-06 0:57 ` Wanpeng Li
2018-02-06 16:58 ` Jim Mattson
2018-02-07 8:31 ` Wanpeng Li
2018-02-07 16:57 ` Jim Mattson
2018-02-08 6:22 ` Wanpeng Li
2018-02-08 15:29 ` Jim Mattson
2018-02-08 15:54 ` Jim Mattson
2018-02-08 16:40 ` Paolo Bonzini [this message]
2018-02-11 11:56 ` Wanpeng Li
2018-02-12 17:37 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad78ef46-7471-c095-0dd9-a5d5fbe85698@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®