From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67345230BE9 for ; Sat, 3 Jan 2026 23:57:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767484681; cv=none; b=oaYVcHkhiTjsPDgJLNrD0GcBnnMih36QvbBzU1Ufr22wjm1S7Y3ucJQLEVBKzUcy5YhE1vDNPN+UgVA9/6wIXSAWmXkYhw6wn6kFUQ9XhDSJ5JMaiSbsP6O6T5ZnmObdPm0XOAJhxaoxDtCg4ZDd+LwrfFV1aWCp/Wtq3gc8BjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767484681; c=relaxed/simple; bh=Nc0bv4pj2jQS1zXWwXvjiUVnCrXsy+PQZzamWQEOi/Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=osbTzp3lAeeGG1melGaaP9qs6AX10OZkxga29TO/rZ85hnvHz+kyYEP2HkIkIayDNgUcQVXdpbmJuP8LhcrqjYul662F0037GSQmywalwPnU2NOkaaQa4vbj0opX9GbQbxukKmCYrllM/eCn4OInHLUOTUOR6mSTM+gs6ha9SbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IcmhY4Q1; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IcmhY4Q1" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-598e9f63169so1204075e87.2 for ; Sat, 03 Jan 2026 15:57:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767484677; x=1768089477; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=dB1LagwegptwwLHmXyd1osJA27FSZTcIsYt0ExTrUgg=; b=IcmhY4Q1VROUpEIn0PP0vEUnJ3UnOVKso3pWBHmiMrDJtyunw54KWFgXkpxy15saTO 9SiOAl71hK3KC9gstLtRuPRgvhP3HzHHwAnlwR5OxnJGFZU5WJR0NYosfRdqxobgzuvF HXDipGhaxZsfx34XxO3j2X9ABG7ogtHl3WBnnB+xcI7kq5JfBpVDt97ztu9gc4pLsRgs pNc3pfO8kfpBc1tx/WSioIqY+SmKxvCjIWr7Ej8p31hM9uQIv90FMZUlDbzEnkUqvgJh MTkUoDiKLk4HVlCmDnVIoqFAcktaJAAolg08LtoeCbMOHCLTx/lb33+7vzGuJ122SkMs rWYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767484677; x=1768089477; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dB1LagwegptwwLHmXyd1osJA27FSZTcIsYt0ExTrUgg=; b=Z5izAREbGO/8CCC7YYCSKrQLHLukujpgIzJ1Yr9bwnVnfCkEitTb1HgmovUZ9fWjag Ijbp7LD+8esRe67XZCiwEdcGyXiQS9EnCpQQs5OaFXr4Y+fuOTlWdpFLudte0aAYjE4b mT7UfHl0lA+n7Mx/Tq/Irxafptyc3VXM4+q03ZNaZ9lXVYj9uqje/KOESC5hXE2zpNJV t2ZN71f44bMdZYroWQz8tbx0jNeRdsxOiA1BWZAdlXBtXaLiJrVYUtncIFgktfpMGE1n 7hlZA45rY/6RaxFKxt07Z/HqCDQJqIpocDBLhiBJdHagoClBcjTc1yC1KpBtS+TGFQK+ sOJw== X-Forwarded-Encrypted: i=1; AJvYcCUpUC9VtFSy2YKHrtSrdqSOgzL2OfKNiuOhBYSFKOBeFHiFBUhPQijQZ49iBlUjWHUkRDv79fK8t+SkQqM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5fy73BIGNPtLtdJUm98VCQ/n892U/1bEOLOXQzvW9BsKcSV6a 433BkM7Yj7Jzo3AL2bV8GCYLXkm+irgdaLviYwm5EOI+3ehcIRbkmuY4Oh9ERM180J8= X-Gm-Gg: AY/fxX65Cb2JdA48nmbpBrKfziXAvqZijAO1m7rv2XtPt6/Ggq+8rdO/dquF0zwRQl5 6hpckRXznYkq+GVsgVmB6pKQyeeqsE0nCcLzU+5EKO5Sjdv81sQ0Sq5NzrGNn7+GVwc5yqv7Q70 iryRBOYPjZI/iirSHvHClRm5jQSVjDpbqnKYfWnARsY1VDLnrQDbgxt8CZ2hiMu1dGOTeOANXWH YWLcwlwAMYQGfPYHwU3eQ2m/P4pMaYmeq/00ADlz2nyyzCMgsShZD3JKPR4bPeKoMt+I70OCscz PXz/ntkEYE41/nnDMCLKnSINuBiKN3aX7vg1nh0tpw8shrN3RwxvIjt1xb+d7LOBpdEXD2FWe2V DAQKeY5sLKzF98HZgOaawyCYV6rI0SFlEAZJiDlS2nH/3/RrWhMkcuPARrNZUMxk7HtdfZcTTyM JuS1U/+B9XVcjjgO4WL0pV005hLAgLqpSyFc0beGnBN7MP396jsry9VzrfJmm3ggxndg== X-Google-Smtp-Source: AGHT+IHsnTa0hbn+0Wh1C3VR25cgPSQ44uvQseVE0kXGNojATuxFAd6n7Pd80xTUUipMQpgZdEmtvQ== X-Received: by 2002:a05:6512:3ba3:b0:597:d7d6:eae1 with SMTP id 2adb3069b0e04-59a17d74eb7mr10048358e87.2.1767484677292; Sat, 03 Jan 2026 15:57:57 -0800 (PST) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185dd90esm13558109e87.31.2026.01.03.15.57.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Jan 2026 15:57:55 -0800 (PST) Message-ID: Date: Sun, 4 Jan 2026 01:57:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] mtd: spi-nor: hisi-sfc: Simplify with scoped for each OF child loop To: Krzysztof Kozlowski , Pratyush Yadav , Jonathan Cameron Cc: Brian Norris , Kamal Dasu , Broadcom internal kernel review list , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Harvey Hunt , Paul Cercueil , Manivannan Sadhasivam , Stefan Agner , Tudor Ambarus , Michael Walle , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-msm@vger.kernel.org, llvm@lists.linux.dev References: <20260102124927.64703-8-krzysztof.kozlowski@oss.qualcomm.com> <20260102124927.64703-14-krzysztof.kozlowski@oss.qualcomm.com> <86a4yw87g8.fsf@kernel.org> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/3/26 14:38, Krzysztof Kozlowski wrote: > On 02/01/2026 14:33, Pratyush Yadav wrote: >> Hi Kyzystof, >> >> Thanks for the cleanup. >> >> On Fri, Jan 02 2026, Krzysztof Kozlowski wrote: >> >>> Use scoped for-each loop when iterating over device nodes to make code a >>> bit simpler. >> >> Nit: the commit message is a bit too dry. I had to go and look what the >> difference between the two variants was. I could make an educated guess >> by looking at the patch, but still. > > Really? That's old and widely used syntax, replaced so many times and > sorry, but really obvious. The made conversion changes are not exactly the ones, which were asked to be done. Commit 34af4554fb0c ("of: Introduce for_each_*_child_of_node_scoped() to automate of_node_put() handling") says it clearly: Note that, in the vast majority of cases, the _available_ form should be used and as code is converted to these scoped handers, we should confirm that any cases that do not check for available have a good reason not to. So, likely this and many other similar changes miss information in their commit messages, why for_each_available_child_of_node_scoped() form is inapplicable, thus it still could be improved. > We should not explain core kernel API in commit msgs, except maybe first > months of usage. > >> >> If you end up doing a v2, a one-liner explanation of the difference >> between the two loop variants would be nice to have. > -- Best wishes, Vladimir