From: Reinette Chatre <reinette.chatre@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"bp@alien8.de" <bp@alien8.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Cc: "seanjc@google.com" <seanjc@google.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] x86/sgx: Fix free page accounting
Date: Thu, 4 Nov 2021 11:44:54 -0700 [thread overview]
Message-ID: <ad812781-af6a-102c-0900-c4277284f2ab@intel.com> (raw)
In-Reply-To: <9f96f71fe67042a89cd1a8f79a1840fa@intel.com>
Hi Tony,
On 11/4/2021 11:36 AM, Luck, Tony wrote:
>> -/* The free page list lock protected variables prepend the lock. */
>> -static unsigned long sgx_nr_free_pages;
>> +atomic_long_t sgx_nr_free_pages = ATOMIC_LONG_INIT(0);
>
> You accidentally lost the "static" here. This is still only accessed within this
> one source file.
Thank you very much for catching this. Will fix.
>
> Otherwise:
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
>
Thank you very much.
Reinette
next prev parent reply other threads:[~2021-11-04 18:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:28 Reinette Chatre
2021-11-04 18:36 ` Luck, Tony
2021-11-04 18:44 ` Reinette Chatre [this message]
2021-11-04 18:54 ` Greg KH
2021-11-04 19:04 ` Dave Hansen
2021-11-04 20:57 ` Reinette Chatre
2021-11-05 7:10 ` Greg KH
2021-11-08 19:19 ` Reinette Chatre
2021-11-07 16:45 ` Jarkko Sakkinen
2021-11-07 16:47 ` Jarkko Sakkinen
2021-11-08 19:48 ` Reinette Chatre
2021-11-08 20:12 ` Jarkko Sakkinen
2021-11-08 20:56 ` Reinette Chatre
2021-11-09 1:30 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad812781-af6a-102c-0900-c4277284f2ab@intel.com \
--to=reinette.chatre@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®