mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daehwan Jung <dh10.jung@samsung.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Howard Yen <howardyen@google.com>,
	Jack Pham <jackp@codeaurora.org>, Puma Hsu <pumahsu@google.com>,
	"J . Avila" <elavila@google.com>,
	sc.suh@samsung.com
Subject: Re: [PATCH v3 4/4] usb: host: add xhci-exynos driver
Date: Tue, 22 Mar 2022 18:10:00 +0100	[thread overview]
Message-ID: <ad877924-68bb-f029-258a-0cf9094265eb@kernel.org> (raw)
In-Reply-To: <1647853194-62147-5-git-send-email-dh10.jung@samsung.com>

On 21/03/2022 09:59, Daehwan Jung wrote:
> This driver supports USB Audio offload with Co-processor.

One do you need one more XHCI driver? How does it differ from existing
and why existing cannot be extended?

> It only cares DCBAA, Device Context, Transfer Ring, Event Ring, and ERST.
> They are allocated on specific address with xhci hooks.
> Co-processor could use them directly without xhci driver after then.
> 
> Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> ---
>  drivers/usb/host/Kconfig       |   9 +
>  drivers/usb/host/Makefile      |   1 +
>  drivers/usb/host/xhci-exynos.c | 982 +++++++++++++++++++++++++++++++++
>  drivers/usb/host/xhci-exynos.h |  63 +++
>  4 files changed, 1055 insertions(+)
>  create mode 100644 drivers/usb/host/xhci-exynos.c
>  create mode 100644 drivers/usb/host/xhci-exynos.h
> 

Please address all the questions I raised in your v1, do not ignore them.

Please use get_maintainers.pl to CC all necessary people and lists. It
makes me very sad that you do not follow the kernel development process
(as mentioned in submitting-patches.rst and other documents).

Best regards,
Krzysztof

  parent reply	other threads:[~2022-03-22 17:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220321090202epcas2p1bfa78db059c1f6f6acbbb015e4bf991c@epcas2p1.samsung.com>
2022-03-21  8:59 ` [PATCH v3 0/4] support USB offload feature Daehwan Jung
     [not found]   ` <CGME20220321090204epcas2p31e39a4b8b6fc803ceecac5d19e6e39e9@epcas2p3.samsung.com>
2022-03-21  8:59     ` [PATCH v3 1/4] usb: host: export symbols for xhci hooks usage Daehwan Jung
2022-03-21 15:35       ` kernel test robot
2022-03-22 17:12       ` Krzysztof Kozlowski
2022-03-23  1:22         ` Jung Daehwan
     [not found]   ` <CGME20220321090204epcas2p3b2be5c6b131240e408d12d40c517395c@epcas2p3.samsung.com>
2022-03-21  8:59     ` [PATCH v3 2/4] usb: host: add xhci hooks for USB offload Daehwan Jung
2022-03-21 17:00       ` Mathias Nyman
2022-03-22  2:14         ` Jung Daehwan
     [not found]   ` <CGME20220321090205epcas2p4f3698a0aa49d251c0a8f008e85d968ba@epcas2p4.samsung.com>
2022-03-21  8:59     ` [PATCH v3 3/4] usb: host: add some to xhci overrides " Daehwan Jung
     [not found]   ` <CGME20220321090205epcas2p15ac16f281554b663062e0e31666defab@epcas2p1.samsung.com>
2022-03-21  8:59     ` [PATCH v3 4/4] usb: host: add xhci-exynos driver Daehwan Jung
2022-03-21 15:45       ` Bjørn Mork
2022-03-22  2:30         ` Jung Daehwan
2022-03-21 16:26       ` kernel test robot
2022-03-21 16:37       ` kernel test robot
2022-03-22 17:10       ` Krzysztof Kozlowski [this message]
2022-03-23  2:34         ` Jung Daehwan
2022-03-23  8:26           ` Krzysztof Kozlowski
2022-03-29  2:35             ` Jung Daehwan
2022-03-22 17:16       ` Krzysztof Kozlowski
2022-03-23  5:17         ` Jung Daehwan
2022-03-23  8:34           ` Krzysztof Kozlowski
2022-03-21  9:14   ` [PATCH v3 0/4] support USB offload feature Greg Kroah-Hartman
2022-03-21  9:24     ` Jung Daehwan
2022-03-21  9:32       ` Greg Kroah-Hartman
2022-03-21 10:06         ` Jung Daehwan
2022-03-21 10:16           ` Greg Kroah-Hartman
2022-03-22  2:17             ` Jung Daehwan
2022-03-22 17:05             ` Krzysztof Kozlowski
2022-03-23  1:31               ` Jung Daehwan
2022-03-23  8:25                 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad877924-68bb-f029-258a-0cf9094265eb@kernel.org \
    --to=krzk@kernel.org \
    --cc=dh10.jung@samsung.com \
    --cc=elavila@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=howardyen@google.com \
    --cc=jackp@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=pumahsu@google.com \
    --cc=sc.suh@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®