From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.44
ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none;
	t=1793625585;
	b=FqYlD6NQhZYiDqy92J0Tvd20xFTmoxXXSO4eKZCHn3o4V7saAwJdPC7iWrupZDE3NmpF
	 lhanunj4mMC1BIPAOrcsvA2SgJymDjZ56GDHSZl13vR28+VsMZLMaltPeQPjBEAddR8J7
	 WiGS3yKe4elH7U8QACFcb5p1dnYEWr3jG8Ef9aZi/ZTYbv46i/RIcv6oltMjHx9H92pO2
	 d9WY4RxwLqr5xS6oUZ/U8VsG4AQhAxnaAoC/Qb1vqCwkjnetwfhi7o0JigYadqIrWLxKj
	 BzfraoGs6+BLj4GAiZ5oBzJCusGyOlTNgowscSpsxbwLliNcZR6gvj3p8YZEbKgvxfA==
ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015;
	a=rsa-sha256; c=relaxed/relaxed; t=1793625585;
	h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature:
	 X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received:
	 Message-ID:Date:MIME-Version:User-Agent:From:Reply-To:Subject:To:Cc:
	 References:Content-Language:Autocrypt:Organization:In-Reply-To:
	 Content-Type:Content-Transfer-Encoding;
	bh=8nLNQzeB35x5xdtfZInSPUAhxxbGqIl4i+gN+oukDPQ=;
	b=WonbUqohHyd5FfJN3i5g7AS8PxTutc4aBg3LePg5wLWE1TzfMuavHl/TdbEYD2m+uhoY
	 i8kvxOrsxwPJO/nrDOjiHeWruBqeKRmt5GOzL0R54braN6pRl5ZQ5ZVUvM6PyptR8zRHp
	 FFKh0KFYSfHm1YKA/acFl9XyNCsxVzGyia9IZlZdc3CxCUqKmkIgttfbNJyIrxcRviApp
	 eyKzp/gsbK3AbKixvniJrxG3LB28phpuclzMb2qYtznt35zMuYDVUhdzuYIUWXViIpWux
	 2qZgx2uJs5VAGZr9m6iWPhtR3tPtjlu9naUyhqcVTLeUqipJ1B6zEx++eplru5BkF9g==
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; 
	dmarc=pass header.from=linaro.org;
	spf=pass smtp.mailfrom=linaro.org;
	dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=rfRnl19U;
	arc=none smtp.remote-ip=209.85.221.44
Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256)
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDAAD606A324
	for <linux-kernel@vger.kernel.org>; Mon,  2 Nov 2026 13:19:43 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DDAAD606A324
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=rfRnl19U
Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-48e20ed3b9dso2700852f8f.2
        for <linux-kernel@vger.kernel.org>; Mon, 02 Nov 2026 05:19:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google; t=1793625582; x=1794230382; darn=vger.kernel.org;
        h=content-transfer-encoding:content-type:in-reply-to:organization
         :autocrypt:content-language:references:cc:to:subject:reply-to:from
         :user-agent:mime-version:date:message-id:from:to:cc:subject:date
         :message-id:reply-to:content-type;
        bh=8nLNQzeB35x5xdtfZInSPUAhxxbGqIl4i+gN+oukDPQ=;
        b=rfRnl19ULOXlnkOK1IXPxgWQCHPhmDZLSyQJtrOD+2EtwcWhpR4/AyWTlBk+Q7iP1X
         GTl++CYTrMQ7kuk+GuJazKgo0Bc9kVRUz4N9POdys96x5r+giC21YOj8zNYSTFhUipdy
         3QQ6WyuKzDUbUyHUrgDwHrIxjtBy/5Ss8lfbg5uyIuoRMpfPNfWkYPuAH5RFoiVZ4kPm
         9UJHX2PjCCOM7D9YKg6aJegBH+FRH5eiNIZsL8XCaLALnirFeAt2SrNzSIfjYOMxD4eb
         p5jjT5qP49a2201vn/uGFc9pm6kdn1IfknYRWJ9HiCVNUJTUrwKCXJTFRpjCKHt2GMxy
         CjiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20260707; t=1793625582; x=1794230382;
        h=content-transfer-encoding:content-type:in-reply-to:organization
         :autocrypt:content-language:references:cc:to:subject:reply-to:from
         :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state
         :from:to:cc:subject:date:message-id:reply-to:content-type;
        bh=8nLNQzeB35x5xdtfZInSPUAhxxbGqIl4i+gN+oukDPQ=;
        b=SVZHop6m/3wLLoFamAi62PjTjcqo94tEMT5qZCQDRt/mZAeqvvkfJ+72vf65Q0lXdo
         pCDuwSdpArRUM3HvMLJgvnZWZio7oLadyLXHVNtHObZG1+vlptnjKlxhP/YYjIxC9JxP
         79wK+klLwZ/5qOLSoQwU8EcvlD5yhIDtbRRPeaZRFOf6rBzYMKcX5It+Fgq/9yoGYY9m
         bZR4AEjd/RTTLsfC4hDDTQPKl9IWtrT5dF5mbw5Wcmyx9q2wKptC+YDk/EowPNMahet8
         ta6Cf+l6XTzE7z3snFS9dnCKG2x6i3nXJJxLPw9t7sth+67NJ9P4uvd49TCPBzATr/xV
         GJ0Q==
X-Forwarded-Encrypted: i=1; AKwUvBxhF1nD/4x38MAbH7ueSQP3yXB/1cYxBLpSta48JUO8fcP+mRbQpf0/trdJfUwgjH80uJ3A1vDA6+2kttA=@vger.kernel.org
X-Gm-Message-State: AFq9FYLhbTkz3v8PlI7gq4eKKoxiGU+xpkF0LjWqaJmJhYJd51s3R7L5
	XHVIu8XAK9gtD2/pin3Al7S6ffGSvFTpo+6IlfRT9XyXCKUM68W+3NiAwn23RN8DC7w=
X-Gm-Gg: AYBFou0NmcGnYOa5+E2LrsqnXRmUAa5bbhiCxlPbbEGTRRsJgydVKUxG1WRVFV8IB7e
	OKI35h5l6A5Xz7DHle+yr3vqKxCZ3dnFunH8zqIbpPL/sMMURaddDIEIUKrX5LMdEN+zXg4BIX6
	eJJHCxchIt4KimnQSa3JVrQbbHn4HbUmiVvUu3xmNX239pfEdXAxCgyAIIwA132L2rORyRlJZ0T
	FXFAoyFCRgAxP8WLThvio06lNNOXkF8TwT6rccq6aoBXAZ+4sLi5k+ByzoJyN31IxtuWa9bUmU6
	RiPq5OfS/la6C/WFOcVt3O+6Ar/OUzvHf6IHBIgeSN/fxNy1XmumUmaUJoFQeJ3ZmAXnQBtbU4z
	VLtVViOS/GyVh+yY7SOwKbXKib2TXqwJsc+PgRIexEipdjeJQNBbOCH6SpXcP2xvdgx/gbIakDZ
	8U7jLRlHT1ZBfpmQh6AIsIdFMtPH5yrZDb6Z6++bxatJn9oWJDDJSd0sb1Eh1f8IEUSFWvNeo5B
	ZGdbFsmhjYnAN926M/Is5Kw0JhCbtpyKyZ1G/flZRnJs+D9WAANrth/82Z3XPEJayD9x9cs9Uhe
	EdaeVAdQboqn6qkpFWe0fZW2Ac/rJUdeaQ70ORfZ8ZMsTFDUQQ8TpqbRCKB93VFZEMAowSCotxO
	2swhh
X-Received: by 2002:a05:600c:871b:b0:4a1:6992:f861 with SMTP id 5b1f17b1804b1-4ac14fbdd1emr212180345e9.1.1793625582011;
        Mon, 02 Nov 2026 05:19:42 -0800 (PST)
Received: from ?IPV6:2a01:e0a:106d:1080:9476:5165:3a16:262? ([2a01:e0a:106d:1080:9476:5165:3a16:262])
        by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4aa8213ead6sm350838855e9.14.2026.11.02.05.19.41
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Mon, 02 Nov 2026 05:19:41 -0800 (PST)
Message-ID: <ad896489-1399-4f9c-9551-09a75e4fbcac@linaro.org>
Date: Mon, 2 Nov 2026 14:19:40 +0100
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Post: <mailto:linux-kernel@vger.kernel.org>
List-Help: <mailto:linux-kernel+help@vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
List-Owner: <mailto:linux-kernel+owner@vger.kernel.org>
Precedence: list
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Neil Armstrong <neil.armstrong@linaro.org>
Reply-To: Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH v4 2/7] drm/panel: Add Hitachi TX10D07VM0BAA MIPI DBI Type
 B panel driver
To: Svyatoslav Ryhel <clamor95@gmail.com>,
 Jessica Zhang <jesszhan0024@gmail.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Thierry Reding <thierry.reding@kernel.org>,
 Jonathan Hunter <jonathanh@nvidia.com>,
 Mikko Perttunen <mperttunen@nvidia.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
References: <20261022132259.240717-1-clamor95@gmail.com>
 <20261022132259.240717-3-clamor95@gmail.com>
Content-Language: en-US, fr
Autocrypt: addr=neil.armstrong@linaro.org; keydata=
 xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP
 GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4
 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9
 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik
 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB
 AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA
 OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk
 Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04
 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ
 GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw
 UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa
 GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r
 yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp
 QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+
 SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY
 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM
 Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX
 oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn
 M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3
 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS
 KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy
 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT
 QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g
Organization: Linaro
In-Reply-To: <20261022132259.240717-3-clamor95@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/22/26 15:22, Svyatoslav Ryhel wrote:
> Add a driver for panel used in LG Optimus 2X P990. Panel is 4" WVGA MIPI
> DBI Type B linked to DRM encoder via RGB to DBI bridge.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>   drivers/gpu/drm/panel/Kconfig                 |  14 +
>   drivers/gpu/drm/panel/Makefile                |   1 +
>   .../drm/panel/panel-hitachi-tx10d07vm0baa.c   | 297 ++++++++++++++++++
>   3 files changed, 312 insertions(+)
>   create mode 100644 drivers/gpu/drm/panel/panel-hitachi-tx10d07vm0baa.c
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 53a1fc2913fee..5f68b78526c3e 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -274,6 +274,20 @@ config DRM_PANEL_HIMAX_HX8394
>   
>   	  If M is selected the module will be called panel-himax-hx8394.
>   
> +config DRM_PANEL_HITACHI_TX10D07VM0BAA
> +	tristate "Hitachi TX10D07VM0BAA MIPI DBI Type B panel"
> +	depends on OF
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_MIPI_DBI
> +	select VIDEOMODE_HELPERS
> +	help
> +	  Say Y here if you want to enable support for the HITACHI
> +	  TX10D07VM0BAA MIPI DBI Type B panel found in the LG Optimus 2X
> +	  P990 smartphone.
> +
> +	  To compile this driver as a module, choose M here: the module will
> +	  be called panel-hitachi-tx10d07vm0baa.
> +
>   config DRM_PANEL_HYDIS_HV101HD1
>   	tristate "Hydis HV101HD1 panel"
>   	depends on OF
> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> index f2c9c80a218f0..414267a49d922 100644
> --- a/drivers/gpu/drm/panel/Makefile
> +++ b/drivers/gpu/drm/panel/Makefile
> @@ -27,6 +27,7 @@ obj-$(CONFIG_DRM_PANEL_HIMAX_HX83112A) += panel-himax-hx83112a.o
>   obj-$(CONFIG_DRM_PANEL_HIMAX_HX83112B) += panel-himax-hx83112b.o
>   obj-$(CONFIG_DRM_PANEL_HIMAX_HX83121A) += panel-himax-hx83121a.o
>   obj-$(CONFIG_DRM_PANEL_HIMAX_HX8394) += panel-himax-hx8394.o
> +obj-$(CONFIG_DRM_PANEL_HITACHI_TX10D07VM0BAA) += panel-hitachi-tx10d07vm0baa.o
>   obj-$(CONFIG_DRM_PANEL_HYDIS_HV101HD1) += panel-hydis-hv101hd1.o
>   obj-$(CONFIG_DRM_PANEL_ILITEK_ILI7807S) += panel-ilitek-ili7807s.o
>   obj-$(CONFIG_DRM_PANEL_ILITEK_ILI7836A) += panel-ilitek-ili7836a.o
> diff --git a/drivers/gpu/drm/panel/panel-hitachi-tx10d07vm0baa.c b/drivers/gpu/drm/panel/panel-hitachi-tx10d07vm0baa.c
> new file mode 100644
> index 0000000000000..83c2af1be9755
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-hitachi-tx10d07vm0baa.c
> @@ -0,0 +1,297 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +#include <linux/array_size.h>
> +#include <linux/delay.h>
> +#include <linux/err.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/media-bus-format.h>
> +#include <linux/module.h>
> +#include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> +#include <linux/property.h>
> +#include <linux/regulator/consumer.h>
> +
> +#include <video/mipi_display.h>
> +
> +#include <drm/drm_mipi_dbi.h>
> +#include <drm/drm_modes.h>
> +#include <drm/drm_of.h>
> +#include <drm/drm_panel.h>
> +#include <drm/drm_probe_helper.h>
> +
> +static const struct regulator_bulk_data hitachi_tx10d07vm0baa_supplies[] = {
> +	{ .supply = "avci" }, { .supply = "iovcc" },
> +};
> +
> +struct hitachi_tx10d07vm0baa {
> +	struct drm_panel panel;
> +	struct mipi_dbi *dbi;
> +
> +	struct regulator_bulk_data *supplies;
> +	struct gpio_desc *reset_gpio;
> +};
> +
> +static inline struct hitachi_tx10d07vm0baa *to_hitachi_tx10d07vm0baa(struct drm_panel *panel)
> +{
> +	return container_of(panel, struct hitachi_tx10d07vm0baa, panel);
> +}
> +
> +#define panel_dbi_command(priv, cmd, seq...) \
> +({ \
> +	const u8 d[] = { seq }; \
> +	struct drm_panel *panel = &(priv)->panel; \
> +	struct device *dev = panel->dev; \
> +	int ret; \
> +	ret = mipi_dbi_command_stackbuf((priv)->dbi, cmd, d, ARRAY_SIZE(d)); \
> +	if (ret) \
> +		dev_err_ratelimited(dev, "error %d when sending command %#02x\n", ret, cmd); \
> +	ret; \
> +})
> +
> +static int hitachi_tx10d07vm0baa_prepare(struct drm_panel *panel)
> +{
> +	struct hitachi_tx10d07vm0baa *priv = to_hitachi_tx10d07vm0baa(panel);
> +	struct device *dev = panel->dev;
> +	int ret;
> +
> +	priv->dbi = dev_get_drvdata(dev->parent);
> +	if (!priv->dbi)
> +		return -ENODEV;
> +
> +	gpiod_set_value_cansleep(priv->reset_gpio, 1);
> +
> +	ret = regulator_bulk_enable(ARRAY_SIZE(hitachi_tx10d07vm0baa_supplies), priv->supplies);
> +	if (ret) {
> +		dev_err(dev, "failed to enable power supplies: %d\n", ret);
> +		return ret;
> +	}
> +
> +	usleep_range(1000, 2000);
> +
> +	gpiod_set_value_cansleep(priv->reset_gpio, 0);
> +
> +	usleep_range(10000, 11000);
> +
> +	return 0;
> +};
> +
> +static int hitachi_tx10d07vm0baa_enable(struct drm_panel *panel)
> +{
> +	struct hitachi_tx10d07vm0baa *priv = to_hitachi_tx10d07vm0baa(panel);
> +
> +	panel_dbi_command(priv, MIPI_DCS_SET_PARTIAL_ROWS, 0x00, 0x00, 0x03, 0x1f);
> +	panel_dbi_command(priv, MIPI_DCS_SET_SCROLL_AREA, 0x00, 0x00, 0x03, 0x20,
> +			  0x00, 0x00);
> +
> +	panel_dbi_command(priv, MIPI_DCS_SET_ADDRESS_MODE, 0x0a);
> +	panel_dbi_command(priv, MIPI_DCS_SET_SCROLL_START, 0x00, 0x00);
> +
> +	panel_dbi_command(priv, MIPI_DCS_SET_PIXEL_FORMAT, MIPI_DCS_PIXEL_FMT_24BIT);
> +	panel_dbi_command(priv, MIPI_DCS_SET_TEAR_SCANLINE, 0x00, 0x00);
> +
> +	panel_dbi_command(priv, 0x71, 0x00);		/* Ex_Vsync_en */
> +
> +	panel_dbi_command(priv, 0xb2, 0x00);		/* VCSEL */
> +	panel_dbi_command(priv, 0xb4, 0xaa);		/* setvgmpm */
> +	panel_dbi_command(priv, 0xb5, 0x33);		/* rbias1 */
> +	panel_dbi_command(priv, 0xb6, 0x03);		/* rbias2 */
> +
> +	panel_dbi_command(priv, 0xb7, 0x1a, 0x33, 0x03, 0x03,
> +			  0x03, 0x00, 0x00, 0x01, 0x02, 0x00,
> +			  0x00, 0x04, 0x00, 0x01, 0x01, 0x01);	/* set_ddvdhp */
> +	panel_dbi_command(priv, 0xb8, 0x1c, 0x53, 0x03, 0x03,
> +			  0x00, 0x01, 0x02, 0x00, 0x00, 0x04,
> +			  0x00, 0x01, 0x01);			/* set_ddvdhm */
> +
> +	panel_dbi_command(priv, 0xb9, 0x0a, 0x01, 0x01, 0x00,
> +			  0x00, 0x00, 0x02, 0x00, 0x02, 0x01);	/* set_vgh */
> +	panel_dbi_command(priv, 0xba, 0x0f, 0x01, 0x01, 0x00,
> +			  0x00, 0x00, 0x02, 0x00, 0x02, 0x01);	/* set_vgl */
> +	panel_dbi_command(priv, 0xbb, 0x00, 0x00, 0x00, 0x00,
> +			  0x01, 0x02, 0x01);			/* set_vcl */
> +
> +	panel_dbi_command(priv, 0xc1, 0x01);		/* number of lines */
> +	panel_dbi_command(priv, 0xc2, 0x08);		/* number of fp lines */
> +	panel_dbi_command(priv, 0xc3, 0x04);		/* gateset(1) */
> +	panel_dbi_command(priv, 0xc4, 0x4c);		/* 1h period */
> +	panel_dbi_command(priv, 0xc5, 0x03);		/* source precharge */
> +	panel_dbi_command(priv, 0xc6, 0xc4, 0x04);	/* source precharge timing */
> +	panel_dbi_command(priv, 0xc7, 0x00);		/* source level */
> +	panel_dbi_command(priv, 0xc8, 0x02);		/* number of bp lines */
> +	panel_dbi_command(priv, 0xc9, 0x10);		/* gateset(2) */
> +	panel_dbi_command(priv, 0xca, 0x04, 0x04);	/* gateset(3) */
> +	panel_dbi_command(priv, 0xcb, 0x03);		/* gateset(4) */
> +	panel_dbi_command(priv, 0xcc, 0x12);		/* gateset(5) */
> +	panel_dbi_command(priv, 0xcd, 0x12);		/* gateset(6) */
> +	panel_dbi_command(priv, 0xce, 0x30);		/* gateset(7) */
> +	panel_dbi_command(priv, 0xcf, 0x30);		/* gateset(8) */
> +	panel_dbi_command(priv, 0xd0, 0x40);		/* gateset(9) */
> +	panel_dbi_command(priv, 0xd1, 0x22);		/* flhw */
> +	panel_dbi_command(priv, 0xd2, 0x22);		/* vckhw */
> +	panel_dbi_command(priv, 0xd3, 0x04);		/* flt */
> +	panel_dbi_command(priv, 0xd4, 0x14);		/* tctrl */
> +	panel_dbi_command(priv, 0xd6, 0x02);		/* dotinv */
> +	panel_dbi_command(priv, 0xd7, 0x00);		/* on/off sequence period */
> +
> +	panel_dbi_command(priv, 0xd8, 0x01, 0x05, 0x06, 0x0d,
> +			  0x18, 0x09, 0x22, 0x23, 0x00);		/* ponseqa */
> +	panel_dbi_command(priv, 0xd9, 0x24, 0x01);			/* ponseqb */
> +	panel_dbi_command(priv, 0xde, 0x09, 0x0f, 0x21, 0x12,
> +			  0x04);					/* ponseqc */
> +
> +	panel_dbi_command(priv, 0xdf, 0x02, 0x06, 0x06, 0x06,
> +			  0x06, 0x00);					/* pofseqa */
> +	panel_dbi_command(priv, 0xe0, 0x01);				/* pofseqb */
> +
> +	panel_dbi_command(priv, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, 0xff);
> +	panel_dbi_command(priv, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x40);
> +
> +	panel_dbi_command(priv, 0xe2, 0x00, 0x00);		/* cabc pwm */
> +	panel_dbi_command(priv, 0xe3, 0x03);			/* cabc */
> +	panel_dbi_command(priv, 0xe4, 0x66, 0x7b, 0x90, 0xa5,
> +			  0xbb, 0xc7, 0xe1, 0xe5);		/* cabc brightness */
> +	panel_dbi_command(priv, 0xe5, 0xc5, 0xc5, 0xc9, 0xc9,
> +			  0xd1, 0xe1, 0xf1, 0xfe);		/* cabc brightness */
> +	panel_dbi_command(priv, 0xe7, 0x2a);			/* cabc */
> +	panel_dbi_command(priv, 0xe8, 0x00);			/* brt_rev */
> +	panel_dbi_command(priv, 0xe9, 0x00);			/* tefreq */
> +
> +	panel_dbi_command(priv, 0xea, 0x01);			/* high speed ram */
> +
> +	panel_dbi_command(priv, 0xeb, 0x00, 0x33, 0x0e, 0x15,
> +			  0xb7, 0x78, 0x88, 0x0f);		/* gamma setting r pos */
> +	panel_dbi_command(priv, 0xec, 0x00, 0x33, 0x0e, 0x15,
> +			  0xb7, 0x78, 0x88, 0x0f);		/* gamma setting r neg */
> +	panel_dbi_command(priv, 0xed, 0x00, 0x33, 0x0e, 0x15,
> +			  0xb7, 0x78, 0x88, 0x0f);		/* gamma setting g pos */
> +	panel_dbi_command(priv, 0xee, 0x00, 0x33, 0x0e, 0x15,
> +			  0xb7, 0x78, 0x88, 0x0f);		/* gamma setting g neg */
> +	panel_dbi_command(priv, 0xef, 0x00, 0x33, 0x0e, 0x15,
> +			  0xb7, 0x78, 0x88, 0x0f);		/* gamma setting b pos */
> +	panel_dbi_command(priv, 0xf0, 0x00, 0x33, 0x0e, 0x15,
> +			  0xb7, 0x78, 0x88, 0x0f);		/* gamma setting b neg */
> +
> +	panel_dbi_command(priv, MIPI_DCS_EXIT_SLEEP_MODE);
> +	msleep(110);
> +
> +	panel_dbi_command(priv, MIPI_DCS_SET_DISPLAY_ON);
> +
> +	return 0;
> +}
> +
> +static int hitachi_tx10d07vm0baa_disable(struct drm_panel *panel)
> +{
> +	struct hitachi_tx10d07vm0baa *priv = to_hitachi_tx10d07vm0baa(panel);
> +
> +	panel_dbi_command(priv, MIPI_DCS_SET_DISPLAY_OFF);
> +	msleep(35);
> +
> +	panel_dbi_command(priv, MIPI_DCS_ENTER_SLEEP_MODE);
> +	msleep(50);
> +
> +	return 0;
> +}
> +
> +static int hitachi_tx10d07vm0baa_unprepare(struct drm_panel *panel)
> +{
> +	struct hitachi_tx10d07vm0baa *priv = to_hitachi_tx10d07vm0baa(panel);
> +
> +	gpiod_set_value_cansleep(priv->reset_gpio, 1);
> +	regulator_bulk_disable(ARRAY_SIZE(hitachi_tx10d07vm0baa_supplies), priv->supplies);
> +
> +	msleep(50);
> +
> +	return 0;
> +}
> +
> +static const struct drm_display_mode hitachi_tx10d07vm0baa_mode = {
> +	.clock = (480 + 10 + 10 + 10) * (800 + 4 + 4 + 4) * 60 / 1000,
> +	.hdisplay = 480,
> +	.hsync_start = 480 + 10,
> +	.hsync_end = 480 + 10 + 10,
> +	.htotal = 480 + 10 + 10 + 10,
> +	.vdisplay = 800,
> +	.vsync_start = 800 + 4,
> +	.vsync_end = 800 + 4 + 4,
> +	.vtotal = 800 + 4 + 4 + 4,
> +	.width_mm = 52,
> +	.height_mm = 86,
> +	.type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
> +};
> +
> +static int hitachi_tx10d07vm0baa_get_modes(struct drm_panel *panel,
> +					   struct drm_connector *connector)
> +{
> +	u32 bus_format = MEDIA_BUS_FMT_RGB888_1X24;
> +
> +	drm_display_info_set_bus_formats(&connector->display_info,
> +					 &bus_format, 1);
> +
> +	connector->display_info.bus_flags = DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE |
> +					    DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE |
> +					    DRM_BUS_FLAG_DE_HIGH |
> +					    DRM_BUS_FLAG_DATA_LSB_TO_MSB;
> +
> +	return drm_connector_helper_get_modes_fixed(connector, &hitachi_tx10d07vm0baa_mode);
> +}
> +
> +static const struct drm_panel_funcs hitachi_tx10d07vm0baa_panel_funcs = {
> +	.prepare = hitachi_tx10d07vm0baa_prepare,
> +	.enable = hitachi_tx10d07vm0baa_enable,
> +	.disable = hitachi_tx10d07vm0baa_disable,
> +	.unprepare = hitachi_tx10d07vm0baa_unprepare,
> +	.get_modes = hitachi_tx10d07vm0baa_get_modes,
> +};
> +
> +static int hitachi_tx10d07vm0baa_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct hitachi_tx10d07vm0baa *priv;
> +	int ret;
> +
> +	priv = devm_drm_panel_alloc(dev, struct hitachi_tx10d07vm0baa, panel,
> +				    &hitachi_tx10d07vm0baa_panel_funcs, DRM_MODE_CONNECTOR_DPI);
> +	if (IS_ERR(priv))
> +		return PTR_ERR(priv);
> +
> +	ret = devm_regulator_bulk_get_const(dev, ARRAY_SIZE(hitachi_tx10d07vm0baa_supplies),
> +					    hitachi_tx10d07vm0baa_supplies, &priv->supplies);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to get supplies\n");
> +
> +	priv->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
> +	if (IS_ERR(priv->reset_gpio))
> +		return dev_err_probe(dev, PTR_ERR(priv->reset_gpio),
> +				     "Failed to get reset gpio\n");
> +
> +	ret = drm_panel_of_backlight(&priv->panel);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to get backlight\n");
> +
> +	ret = devm_drm_panel_add(dev, &priv->panel);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to add panel\n");
> +
> +	platform_set_drvdata(pdev, priv);
> +
> +	return 0;
> +}
> +
> +static const struct of_device_id hitachi_tx10d07vm0baa_of_match[] = {
> +	{ .compatible = "hit,tx10d07vm0baa" },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, hitachi_tx10d07vm0baa_of_match);
> +
> +static struct platform_driver hitachi_tx10d07vm0baa_driver = {
> +	.driver = {
> +		.name = "panel-hitachi-tx10d07vm0baa",
> +		.of_match_table = hitachi_tx10d07vm0baa_of_match,
> +	},
> +	.probe = hitachi_tx10d07vm0baa_probe,
> +};
> +module_platform_driver(hitachi_tx10d07vm0baa_driver);
> +
> +MODULE_AUTHOR("Svyatoslav Ryhel <clamor95@gmail.com>");
> +MODULE_DESCRIPTION("HITACHI TX10D07VM0BAA MIPI DBI Type B panel driver");
> +MODULE_LICENSE("GPL");

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil