mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jean Delvare <jdelvare@suse.com>,
	Eric Tremblay <etremblay@distech-controls.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: tmp512: mark OF related data as maybe unused
Date: Sun, 12 Mar 2023 11:10:15 -0700	[thread overview]
Message-ID: <ad8c23e2-8a92-4fdd-b785-c485ebb597a5@roeck-us.net> (raw)
In-Reply-To: <20230311111610.251774-2-krzysztof.kozlowski@linaro.org>

On Sat, Mar 11, 2023 at 12:16:10PM +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
> 
>   drivers/hwmon/tmp513.c:610:34: error: ‘tmp51x_of_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/tmp513.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/tmp513.c b/drivers/hwmon/tmp513.c
> index 47bbe47e062f..78cdd2d2d875 100644
> --- a/drivers/hwmon/tmp513.c
> +++ b/drivers/hwmon/tmp513.c
> @@ -607,7 +607,7 @@ static const struct i2c_device_id tmp51x_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, tmp51x_id);
>  
> -static const struct of_device_id tmp51x_of_match[] = {
> +static const struct of_device_id tmp51x_of_match[] __maybe_unused = {
>  	{
>  		.compatible = "ti,tmp512",
>  		.data = (void *)tmp512

  reply	other threads:[~2023-03-12 18:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 11:16 [PATCH 1/2] hwmon: gpio-fan: " Krzysztof Kozlowski
2023-03-11 11:16 ` [PATCH 2/2] hwmon: tmp512: " Krzysztof Kozlowski
2023-03-12 18:10   ` Guenter Roeck [this message]
2023-03-12 18:00 ` [PATCH 1/2] hwmon: gpio-fan: " Guenter Roeck
2023-03-12 18:06 ` Guenter Roeck
2023-03-12 18:08   ` Krzysztof Kozlowski
2023-03-12 18:48     ` Guenter Roeck
2023-03-12 19:32       ` Krzysztof Kozlowski
2023-03-12 21:03         ` Guenter Roeck
2023-03-12 21:14           ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad8c23e2-8a92-4fdd-b785-c485ebb597a5@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=etremblay@distech-controls.com \
    --cc=jdelvare@suse.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®