From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8104A227EB9 for ; Wed, 10 Jun 2026 17:31:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781112703; cv=none; b=kypSzkfHIgy2s80a2gMN8T9lX63oTG9Vem2n8zMwzIy9UVlWESphPtKqGNE1bLlLrmc6sdbUGSSEa+JfUrW1HBIJRR86x+t6C/T2XEntMqQBD46bO3gq/ewJeNXJ77mQUXwha+ITEasSKUSz/5qg5EWbDun1aVexOZUx27QveM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781112703; c=relaxed/simple; bh=zoAVZM9lw9OZBoKsWFzZss54eAd7kTsWGiBNL3Nahj4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tNddhO+nSdGnieABTOPJl+/iDc2R+5vyLMB21jPa8UGH1jWXX0nk8ZQChx7/CJPdVy3up9sfkSkAp0YH72Z1wLjbWM21Oq7F+94aNxL/XEFpyCLYYu8jqMX3J/eTMFCuvHVLNKvAI+RjA1bCR+z2SgI8X9eezMOkxILFRikZnwc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PmNX02+Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GZy39txV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PmNX02+Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GZy39txV" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65AFxJfV1670922 for ; Wed, 10 Jun 2026 17:31:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wuaZqI72kcvOWTcAMRw9YZ+vyHkrkFtJRQmO3nBSIeo=; b=PmNX02+QZ3r7rAax caZqRDHPJ75DNM5P7Xfqj64k0255t1UZI+rT5xQiwqtqLA+Ov0FRQQlD1GxDNKz5 cVstyCu1BPXXaT7GA7FsCl4qz+JNpMfqd8mals8xWBwsBc6Hkn8tfBmqreLFsiDq pr190h78ksV7bCrnw0rvdBiHu9ZLV0wZR+xiADTSeTV2Rii2+VAimb6sF6VHmfcY dYy8ppOkNNLCMgeoIxuSMcHgaNHtk0+g/fK4C73bcuqFcM3dRDGxKpET1THMcQ40 nMkPKX6yCt+Tect8Jj5NPTthphA0Eg0GIJ3gghfall2iqU4P9HUyLzCYob3iRmlN SKInxQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eq0m1u57g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 17:31:41 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8422ca754d8so4883815b3a.1 for ; Wed, 10 Jun 2026 10:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781112701; x=1781717501; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wuaZqI72kcvOWTcAMRw9YZ+vyHkrkFtJRQmO3nBSIeo=; b=GZy39txV5stzo/cZuxK285ZoyKfx5wnY7mu96K6wlziRZakgEfAmizo1qdnVbPtMSu keP79NAZ3BDA7uH41TVki9W3y50zWsP93iLAFpjkpsQ4mgLm8K2ocM6B217E1xe7yHuI vB731KfobtJ3mPPBNXV8zvjzeQWHUL40c8DsmibjiTWVZ2E4kpvYfJFuRpRnSMA6cJ/A IgY2iYipuktnfS7jSKQzcSRNDuWBr9l5xnRJtwaBCbpXnFByoFCJcnt78lwUp/aoZbGt c6h6nCdsAbKAJyFKUtR3+Y5m+fVLTRvD79jrqJ2HHyg1vkbBNgO2AudsfYxnwhZwcpiL iKJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781112701; x=1781717501; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wuaZqI72kcvOWTcAMRw9YZ+vyHkrkFtJRQmO3nBSIeo=; b=iMMYFkIAK6Oy+yVReVAULrCiHYZSI3QIRpbTcT++Tzg7vFiJCWp0hi0uLDPFPv2smK ZOcI2hZgvF6509373MdOom/LWAlVqvxNspaewTsXJhREk9H8dyVa1noXTQ49hVt8p3sN GqP/y9oelUmQotAyEkvmL0kw4W2mpw1HR7fASujPKUZcwmNKh6zc6Qq7VNlEswpsOmFD 4lEtitfbwron7m3VEcRnI3mZQd+h2kvOyqf7rw94McuArLSIIUrAwgJxW2hd5aW3fAXv 0hWSfE6rELXxH1m+deqPp6Z+hdmg8sLDZA4KLjG7tE/jvomn+oyStMFXBRl8u+xCsQJB al9g== X-Forwarded-Encrypted: i=1; AFNElJ+CaT3CMXnIWOgrJ81XGUJMcxFpS63Uz+s3s72v2mHZ9E5P47naHxtlX/sN7tuc3Flhna1Uohax+b2W+/k=@vger.kernel.org X-Gm-Message-State: AOJu0YxcSMdKcrCpaiIJl7VCvQDUrJz7eDMqqBDSKwwI7lXvToRGgi7+ 73XEwITKZ3pU0SBjJwlJ562FDtqv9lNhymaguIhbShWukbxs7glJTmwZyrnqiahgqL5UiqMKIou ThSVI0AghLH6EZAGApdcmPHXOrtgjeqnHX0nJm23LBeO1xkpltRG72+mOwK7btpeVEqA= X-Gm-Gg: Acq92OF5Cz10D+By3yK3dmqL38iDP33+yGMeXg+TeFbDQ4bN3M+gTMX57NqbMYsn8MB to716oBGvoop4/sg6QKOf8NBfd3cEdGXNVaf+Hoe9jEHJnx/zIzPHVxRm0kMQRk4mgiWrn1++u+ jVjDV5Si6tzvMDGIg2ZtWBjWhCX9CdzdocW1NgWpOnt17yYArd3/u3BY92a+MdjGA9B+V6HdzLk 393yrU20O7Qm7kIactMtkXaX2al0g6Wsk/sNRbqneNzT8mMck9WGNsguC96+nBBf03ZBhpt1zl6 xtH3MvNF+3yXJoT84n/AO4NcEiqeHs4jXhLybAKlPga8MRolC3ZV8/9DgYtbCg2/3ioR5UAIC5q XmoAOEj0fYP8bpsG5frypH9QqnciP0h3rxYWI5BSGADEiS8yLd+wMCgqOes8k X-Received: by 2002:a05:6a00:391d:b0:842:2f09:fde9 with SMTP id d2e1a72fcca58-8430a62fa44mr9456284b3a.8.1781112701201; Wed, 10 Jun 2026 10:31:41 -0700 (PDT) X-Received: by 2002:a05:6a00:391d:b0:842:2f09:fde9 with SMTP id d2e1a72fcca58-8430a62fa44mr9456240b3a.8.1781112700712; Wed, 10 Jun 2026 10:31:40 -0700 (PDT) Received: from [192.168.0.195] ([49.204.30.116]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8428221a7e9sm32993890b3a.11.2026.06.10.10.31.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 10:31:40 -0700 (PDT) Message-ID: Date: Wed, 10 Jun 2026 23:01:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/12] clk: qcom: gcc-mdm9607: Drop redundant register update during probe To: Stephan Gerhold , Bjorn Andersson Cc: Michael Turquette , Stephen Boyd , Georgi Djakov , Shawn Guo , Bryan O'Donoghue , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260609-qcom-clk-mdm9607-fixes-v1-0-5e9717faf842@linaro.org> <20260609-qcom-clk-mdm9607-fixes-v1-12-5e9717faf842@linaro.org> Content-Language: en-US From: Taniya Das In-Reply-To: <20260609-qcom-clk-mdm9607-fixes-v1-12-5e9717faf842@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDE2NSBTYWx0ZWRfX+rFgk/kGXs2M OboWXg8FZFsX4xsS8nGJtpq3k35h0RhYcMZTbVCEn9CkBK9foeX9LAir8wus8JPIPTL3ek3z+1K GRbvk1rhh1JAJgjKYZ0YpPRLkXzsUBmMhqMGZEgE8qsAQWYY0nRntZCTGq6I3dYNGw+LTY6XM0m NkLcGDtFe9qD22GWcSDoBJbffL6j4CbdHvJfZoiCYVjeS7Hj3a1iLcwZtBXgYLRsV1eVRWqE09C ktv99Gl94bmqudapPiISJ7Nujq5+18R37XkVIeaPet1jxFEl887dZtuuHNwLQOvICtjqt2ySMRv v8izQb6MoyTrYPoeUpVoOk8XvJzzrWPk7rGvnkQr1AjoHYjUf6a7ntaYCcIiTj/X5w2681J0Fsa WxYGNOcRL5SMHKNbNVNocUHsXxiu3DN969xKyM4PrIECG22DnL7S9/pA6ygVNpu4dHWgc1gnqZ/ 29WyOz/k7q0RiJuRdhA== X-Proofpoint-GUID: hoGqTAaIgAsMhfokxtCKqkbBlwzfeHeN X-Authority-Analysis: v=2.4 cv=UdJhjqSN c=1 sm=1 tr=0 ts=6a299f7d cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=wot0Jldcyx0dIQi3j0aq2Q==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=j8Cu_9a8AAAA:8 a=naHRbAbjXZXVQ0aMeuoA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=A2jcf3dkIZPIRbEE90CI:22 X-Proofpoint-ORIG-GUID: hoGqTAaIgAsMhfokxtCKqkbBlwzfeHeN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100165 On 6/9/2026 7:44 PM, Stephan Gerhold wrote: > From: Stephan Gerhold > > GPLL0 is pretty much guaranteed to be already on (and voted) during boot, > since it's used by the CPU and also various other components such as UART. > We also vote for this bit in the actual GPLL0 definition, which will be set > as soon as any driver in the kernel requires using the GPLL0 clock. > > All in all, this makes separately voting for GPLL0 during probe redundant, > especially because the "acpuclock" in the comment is a downstream construct > that does not exist in upstream. > > Signed-off-by: Stephan Gerhold > --- > drivers/clk/qcom/gcc-mdm9607.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-mdm9607.c b/drivers/clk/qcom/gcc-mdm9607.c > index 0bd4c12483cd..ce78ebc8ffec 100644 > --- a/drivers/clk/qcom/gcc-mdm9607.c > +++ b/drivers/clk/qcom/gcc-mdm9607.c > @@ -1565,16 +1565,7 @@ MODULE_DEVICE_TABLE(of, gcc_mdm9607_match_table); > > static int gcc_mdm9607_probe(struct platform_device *pdev) > { > - struct regmap *regmap; > - > - regmap = qcom_cc_map(pdev, &gcc_mdm9607_desc); > - if (IS_ERR(regmap)) > - return PTR_ERR(regmap); > - > - /* Vote for GPLL0 to turn on. Needed by acpuclock. */ > - regmap_update_bits(regmap, 0x45000, BIT(0), BIT(0)); This was to ensure that the (APCS_GPLL_ENA_VOTE) vote indeed has a vote from CPU. AFAIR, the boot up was not using this particular PLL vote register and no piggy backing for the GPLL vote. > - > - return qcom_cc_really_probe(&pdev->dev, &gcc_mdm9607_desc, regmap); > + return qcom_cc_probe(pdev, &gcc_mdm9607_desc); > } > > static struct platform_driver gcc_mdm9607_driver = { > -- Thanks, Taniya Das