From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C914318AFE for ; Wed, 15 Apr 2026 10:05:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776247553; cv=none; b=hue7jNxKjVm+k34uZtFjcY+nwt02I9mtIEM3jgW99TYpZ132ym5V4T07y1tdtWKNasSrKU12vwHEkYe5x5U+avUCjommoISfoiRWVy7hwTmL2p+z2nv51w397BRROEiFNeEO23VxR04xGOMqlNpK3gkrYC56Nl9Z51wIEcLHbfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776247553; c=relaxed/simple; bh=NDJ0bZGkP12D4112wksethGXWdmzMfeMV4LeDJwvJIU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qd/FByXqxfZLjribWa8ZeAQDrW7ANg+YwhN/fsHhuUh/KlHTQJ07JVfBWQ9I9t5JH8ZHaiVzTRhWhmoMMA/yUVp0k2vhBox/n566z8xMz8WgOcmEDFJG3wiDsItProcZOWnmTkd3SQufHQVdHxN2Rhk77emG0HWmZk6qQ7mh4+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FqY6hFd8; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FqY6hFd8" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso80036665e9.2 for ; Wed, 15 Apr 2026 03:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776247550; x=1776852350; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oPf/88OR1eh/7G09scCZwblzoYMeBue5GJQTUY482co=; b=FqY6hFd8HcrCiXPm96FKeC5eHd+qGvSeOn3/S38TX20fHyh6DfcaJtu1HrRJYGb43J aNz179KMHSFVg8dN1R2w//Q/Y0MgsiRaPy9lsbjXGmdZLBBAFUq92IG1SnVk8ZKUrvfK EqmcV/AH+pIp4IFpd2Qcd8KH4PgJ5lnm97XVKN5Uu1OF5uEEkOl+RMxWD16pIw0yuGEJ C5STg3tBeX6fkRm2/3YklAqq9pJN4nH0konRpepi1iKqYn5+MHuM1/1axqZBweYg8xeg Yd/ylnKLgsrH2B5mlyRLVHr86HLnGFo6l04VMsSJl90H+7yAq7/0uN+lPSs712iKhnyl opyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776247550; x=1776852350; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oPf/88OR1eh/7G09scCZwblzoYMeBue5GJQTUY482co=; b=bDPoVGhw8OUN0j/UxV6FqNgllwarwigy0AUH+ZqjKDajOGyzMdYfB5ZXr0PhLeZh3O ciU9IcwOPqOTwJQC2YJHx+QXb2rXoF55lBR1d1UxRSLgd/zEhZrTWHGrjxbLw62nLG9z DLAIx4xHLE4S1jMShCRgx/mzJx9e7tFvNRic1gZnNaEafANwD/qQh7xHXz3fPOj+s7tK mXiIhbfQxiMSneisMPDl8RDovdwSbyFSqMkx46loi7wPUieUPTYHVW9JQj6WxCeOUqsq 4f/YwqudAbUO9kDn4Ylo8szYJsMRvcOebJaLmXL0HZHvVllS+IMUzRWa5q3uXLQuK6/3 h2OA== X-Forwarded-Encrypted: i=1; AFNElJ/55iFOVDD8JtTa86EzcS3Ay7f10xLKA5KXbZv2KgIHEXobhOeSMo0zliiztUfns4PSSG/KGhczObM8uEE=@vger.kernel.org X-Gm-Message-State: AOJu0YywRySx25SF4F1NzlJAviMx0d5Nd5usthIz7l4rjkPlvmKI5sig 3BzH7x0+a8+JjhUYgL0RFFy+b24SGd8PXdNxCu/uSZdLmU8xC0PIc2rn X-Gm-Gg: AeBDietn+tXFrtIimhSpDEh2xN7Io5OUDQHaJsXeEAQzv0lEjqAP+9C6joYxsQJXeHG G24tA4EzFhoD6UQMy4Do2DnXaZdx4Ljg+thTAkB1Ms79AAirUTvovepTQzQyUEnYUpuOe62INAH m+eTAzCW9QP/EDBvC+9jaSpMbCVhbcClGMMipb2Dd9DDAhhdqlt/5AadElUs/+eN6XukAxjIfLE hhu9eEtPIKf6kp1bw5atpva4gJFmDp1mNhpSr/r66ixDUK8iJ5VqvhOK/XZnMsqyBhhmjGFY2wM SIGjlIp6KVY8Ib4aLDRyG2Dgs7apckj09L5/swJFm+MA8CUGcIDjUWTKr+m8FoPKLlyuZDU5Uey Lg5TJoRqZQQOr2pGnxoed5gDsd96ZML5SgAUcJCA4HrIKtZ9AaHwN6pvOWwC8vhaTeGB3yYW9Jj 7FLywOv0U31rDzD9JAXEw= X-Received: by 2002:a05:600d:1c:b0:487:1108:48bc with SMTP id 5b1f17b1804b1-488d6836d87mr221820675e9.17.1776247549991; Wed, 15 Apr 2026 03:05:49 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f08bdadbsm18978325e9.0.2026.04.15.03.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 03:05:49 -0700 (PDT) Date: Wed, 15 Apr 2026 13:05:45 +0300 From: Dan Carpenter To: deep@crimson.net.eu.org Cc: sakari.ailus@linux.intel.com, bingbu.cao@intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: staging: ipu7: cleanup register names and suffixes Message-ID: References: <20260415070205.1245502-1-deep@crimson.net.eu.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415070205.1245502-1-deep@crimson.net.eu.org> On Wed, Apr 15, 2026 at 09:02:05AM +0200, deep@crimson.net.eu.org wrote: > From: Kenet Jovan Sokoli > > Rename BUTTRESS_ registers to include IPU7_ prefix and > remove unnecessary U suffixes from numeric constants > for consistency. > The the renames and changing the types from u32 to int should probably be done in separate patches. You need to be a bit careful with changing types. Generally, you should use unsigned types for bitwise operations. So the _MASK variables should be unsigned. > diff --git a/drivers/staging/media/ipu7/ipu7-mmu.c b/drivers/staging/media/ipu7/ipu7-mmu.c > index 6ded07ccd780..c5f83023ddbd 100644 > --- a/drivers/staging/media/ipu7/ipu7-mmu.c > +++ b/drivers/staging/media/ipu7/ipu7-mmu.c > @@ -33,16 +33,16 @@ > > #define ISP_PAGE_SHIFT 12 > #define ISP_PAGE_SIZE BIT(ISP_PAGE_SHIFT) > -#define ISP_PAGE_MASK (~(ISP_PAGE_SIZE - 1U)) > +#define IPU7_ISP_PAGE_MASK (~(ISP_PAGE_SIZE - 1)) > > #define ISP_L1PT_SHIFT 22 > -#define ISP_L1PT_MASK (~((1U << ISP_L1PT_SHIFT) - 1)) > +#define IPU7_ISP_L1PT_MASK (~((1 << ISP_L1PT_SHIFT) - 1)) > > #define ISP_L2PT_SHIFT 12 > -#define ISP_L2PT_MASK (~(ISP_L1PT_MASK | (~(ISP_PAGE_MASK)))) > +#define ISP_L2PT_MASK (~(IPU7_ISP_L1PT_MASK | (~(IPU7_ISP_PAGE_MASK)))) In the original code this was 0x3ff000 but now, because of sign extension, it is 0xffffffff003ff000. Does it make a difference? I don't know. But it makes me uncomfortable to see all these changes thrown together like this where it's so hard to spot. regards, dan carpenter