From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A09A43A7825 for ; Tue, 7 Apr 2026 12:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775565266; cv=none; b=aav5KaUhKpX+ZAuZPsOAjFJK7qvfjfF/v73a0quSUfUf7b+QkBkOCd2JCNR1dtHbRtONK1MJNAGcKmnM798+/61QaK75g7zUvms1bbi9X6IyS9nJRcnt0a/f3liz2VE6PmPuJLM25bPMo5CUWIVf/aOsKCSQ8kbuZSpaem4CP8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775565266; c=relaxed/simple; bh=8hHHrBZ8Nyf0KEdu4IjMO2ZerCu7tDzBPkc0VZWH1bQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q/y2jy7mb51IqfVBJuYQ0TnIFGPXCKRIvsF4KlXTIxp03eoSQbfxJpj3P1PcaYnaAocgsjeuf86hCHz1QQ4cDZq4zmU7B1ko2Po+GRGbbR2TgwY0jwgxVqffUQ8K5LfZpLqX+bl6owm/ofxChs0YQ2xQgmN2iIJxjZK4eC2w/Ns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=TzTl8sUo; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="TzTl8sUo" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7d7e9b97a73so3498466a34.0 for ; Tue, 07 Apr 2026 05:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1775565263; x=1776170063; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kQjKpsXxXwfTOmn8xNLLNm+gkxdA4DaJZsvTM1mT8Ko=; b=TzTl8sUoWwXwKtlT26maQg+PIhumQ6c+PLXSdYUumK+/vTCyuEdXoLsJdAuoJw5VsQ FqwXUF00467Nxxa9gpHsAXTt1byMsp8tXFe+k0c9CpG4wQMEN7sIs/sqnOurvgQvoopY 8zZGMzt0KM/NN6+sDnWXigWaCdY0CoSBgmMto141lbCukZNqfZk1DTkLpahyYpaj9IX0 Xf4Zn+S+FbQZpl1/ms+3XeUfMOoaI+IzoNoGhK9QVDefEX4Nf1+NtBunLasNKd8MdXvs 1hMO6GiVZ7EPYTaQ12diMHxQYrSGfyrGDdLlFQ3pAMu0nQf0U4kdOURZup5jvGs6kqtt anjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775565263; x=1776170063; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kQjKpsXxXwfTOmn8xNLLNm+gkxdA4DaJZsvTM1mT8Ko=; b=l5oB1l+0Uf/Lm2e6yMzds+mIpWkD+U9Vsti9P0hV8kfyCuaPZcAk9Y7F+ya/TOuLO1 ACAm82nWTo6o3dGn2FUnZvOdXS+Ky/+ngz6xfV09a15W00gwZLcuiDCL8aOErguDmM7k TffW/qpbPuG861rCWbviXWSs8iwI+aME19DCkXEL6hFh3bT6UyM9J8zwezpXHrvkoBN5 /mxlSRX1fi7/rwJH1JcBNRfTwRZeB0nzwNMiDIaLliqy4guqeYrrQwfjTgh/ECo/JpWm 2oPU7eFyDiHtFGj0KoQCQYmwY6ezL49Gk0afnTKChAxvai0xCj9RM4OOP24oWr3oswdn 27Ug== X-Forwarded-Encrypted: i=1; AJvYcCX8TX6ibjj1PbY3X0jhNKeNNA/1N0RwB78eXsNYfVKOT8iC75EA9C/nJYSLxdQFd3GmiFRoob1X9u3qAJU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0qvMxRrgkCDMNHFr+Bwc7K394FaOZWckxHUjoXJJb4cCNXPLX vvU/1prZgS9+A6C4NRxMk/XYnhPBbzhv/UENE16fZRlzhKKKbFBtXbwH1XZc6qJVingxVW2RUvQ GyHHo X-Gm-Gg: AeBDietQuYEXcV41da6DD9FGqlq/HzEdbYatdaP/VfqOOye4YiaCTPCJb7mrmlwoE4m JdqPK1N1rlnkZYMhBOdfEoixjmItgIbxhJz9gFJY7o7DLo/8N6x+Kw8qhVqdUQKMLFGT2wqnvU+ qQrx9C+STRH5LX0b6y5F3AlhmU9vT5AYbkzoYPup4afHHdcvl84NmVno2d6BHbKwi4eRkIivO7c AdjV+EoOOSl40DhGi//YfeEXAssEDWUf6nmOd9c+3m+JBH+qcSnoNnEy7kc3slfHIdW6dzWVfxz zo92rb3+u2Ub0knyZv7L/NlxKvpiAUbdSYnK4RbFjVUTg3EMBim3uclIf67wjl7oSoZCNB1R0Cn YXVfi0bkAwkCbvNOGy47MMvTBizPfw6xUwnkLVc/XxPl+8xGtz2VhnK+8KEu1MmIZPwotXS1ttn xuv+zZAQc5VaTgJQYHorIxZPbfNWdScqAb5Dv5B+3s+Hz+wmzOIxka2sK7Tlnq5XUpjJFBtZoOk dYFYYGAteAYuOY= X-Received: by 2002:a05:6830:33e8:b0:7d7:4eaa:8b82 with SMTP id 46e09a7af769-7dbabd17ff9mr7149715a34.17.1775565263471; Tue, 07 Apr 2026 05:34:23 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:ac98:37e1:7dd5:e156]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dbf2ddd6c8sm2034596a34.23.2026.04.07.05.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 05:34:22 -0700 (PDT) Date: Tue, 7 Apr 2026 07:34:19 -0500 From: Corey Minyard To: Jian Zhang Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] ipmi: ssif_bmc: Fix KUnit test link failure when KUNIT=m Message-ID: Reply-To: corey@minyard.net References: <20260407094647.356661-1-zhangjian.3032@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407094647.356661-1-zhangjian.3032@bytedance.com> On Tue, Apr 07, 2026 at 05:46:47PM +0800, Jian Zhang wrote: > Building with CONFIG_KUNIT=m and CONFIG_SSIF_IPMI_BMC_KUNIT_TEST=y > results in link errors such as: > > undefined reference to `kunit_binary_assert_format' > undefined reference to `__kunit_do_failed_assertion' > > This happens because the test code is built-in while the KUnit core > is built as a module, so the required KUnit symbols are not available > at link time. > > Fix this by requiring KUNIT to be built-in when enabling > SSIF_IPMI_BMC_KUNIT_TEST. Got it, thanks. -corey > > Signed-off-by: Jian Zhang > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202604071448.zUBjPYPu-lkp@intel.com/ > --- > drivers/char/ipmi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig > index 72559f6050eb..669f76000197 100644 > --- a/drivers/char/ipmi/Kconfig > +++ b/drivers/char/ipmi/Kconfig > @@ -189,7 +189,7 @@ config SSIF_IPMI_BMC > > config SSIF_IPMI_BMC_KUNIT_TEST > bool "KUnit tests for SSIF IPMI BMC driver" if !KUNIT_ALL_TESTS > - depends on KUNIT > + depends on KUNIT=y > depends on SSIF_IPMI_BMC > default KUNIT_ALL_TESTS > help > -- > 2.20.1