From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D87038F24C for ; Tue, 7 Apr 2026 11:03:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559799; cv=none; b=MWjPghL8yY3pfhhcKDS1nGawdGiq+LabLuGq9VwuFCl4G0bM5zk7ZG4jXaFJKmXqhq7xKJciMz3sgOBUISThRGXixItPkGXFPAI+agiWFEaPVI3mZg/8KEvW0tWbqbTFbzZHVSSIcuxc4yuvp6udDvmrVYaoANRXKWWONPsN+mc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559799; c=relaxed/simple; bh=IkZzuazTH/iSTyd2T6R8GjK69h4T1pNcKXpp4s4Gg1Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jUvsZExQxEZunGFoYC5zdI8brclrLZVCQ/hNFnrKr4551Fn/1qxYPMlFbW+OHYV34++dgEMv4YVIF9F00PNeR3vtExjFBXfH+kTFJB7/ojTM5vcHOPmQ7s0KojPu8hR4MiPuQk9dWpoBj5pDcMeUbezOrmJIarAyvJzUKQJ/IoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linbit.com; spf=pass smtp.mailfrom=linbit.com; dkim=pass (2048-bit key) header.d=linbit-com.20251104.gappssmtp.com header.i=@linbit-com.20251104.gappssmtp.com header.b=u2HZJB/v; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linbit-com.20251104.gappssmtp.com header.i=@linbit-com.20251104.gappssmtp.com header.b="u2HZJB/v" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-488a041eae5so22696875e9.1 for ; Tue, 07 Apr 2026 04:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20251104.gappssmtp.com; s=20251104; t=1775559796; x=1776164596; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=m6TtVGHE2sfWKmKHTfD7B+wW30vSxCVJuqgVacPiiPs=; b=u2HZJB/vUiR5lymoBAvTeeFxwc6WnMaUdlQRSNBU7S+VkcRSix4hsO34fNtHPF7x/k QtnYt1N3mr3yCMoh7m4CF7s+5hEXvixu8A8QmgLsCJTuI9xCl/3npfNNKxmo5Ib/vmAb o/ok6VsTmvWjWfwFDKl4lPYYmbnMbPgAs5/frJmybB4HxiJllgAIITuz48q65Zy11Nlw 59AOaINBF2/HJHUtt6Fs+pVo2xp4DDyTdhCUxnqJQ+JczSwA6C7GujjkOMmHo8fzLf2D 1eWws4ZeAWH4M3qk2axQzUJ3diueEF87onhfh6lgQl37NhUZjNtw8QoT1Byv5BBs53yu +J7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775559796; x=1776164596; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m6TtVGHE2sfWKmKHTfD7B+wW30vSxCVJuqgVacPiiPs=; b=jXd/tcOgcs2R1aBay8torGyMG8MFfOGCNxQoyjlamQZN5a8uxsggWLtL0a4L0sQbbh 5oBA5tRYPnNQWH9h1i5DLSEDTzMJS5hUC+nCz+hXTaaqC8jCevxh8knhpfZWRaVt9b8N bZ6QJ0+t5yBoZrm+Zsk5J+KmGyw/05Qr2D6sfD/mX0g4gC4bRA3Zey5pLJ8o50nMPnMw WUlr21bifSasydos2OEfkKh4dnbV2xu6zJXxL7BKXW5CghMvXRLbypzdv3Xy6TRiL1iN 6V94/CYBNnPfFslKY06GDyb7bcwplzMcKvr4dSTsTqjdycc9ysWcAt6gTmPfRQeXfeyh 9liA== X-Forwarded-Encrypted: i=1; AJvYcCUZ4hxiieKY+atjGbX1ttTx3tuM2SN/zMVGMGAFp81EYu5OJvYkRArJ4EH0eG1YPhWZLb/Y9tCZFOIk2DU=@vger.kernel.org X-Gm-Message-State: AOJu0YwAHEL8wp3CqwmJ7hIBTdS7s6fwO48QpIddcFl7rrDSD1AlV/R3 NqhuF4BDczhiWiwLhW8uOi7GS7LTrsqUQWDSXBzuCyl+cA7tcrXx6ozi2F3v0ZOBQsU= X-Gm-Gg: AeBDiesbqJl7wWrIu+9uDwU3TQXzHB6sDGoSnBvsEtNQ5jhXmSLnf+rvqR1QfjFbAB8 3rPwXaXBxtNZG6NtwmXqpZwm+WCYDGz4IlsV1KeplCRvLI/2BX7rZ8TEW2fcTY5HQanUOsz0Re8 xu1xtAbJCTTuVWXctIcysHKpRw482DhmwNSogpcCaO7anJwg9PtQAWXzZcYdMV3stIruQGkkdL8 CPlDG6NMBkTE23qQyAcn+bv3yiEKG32LKtO02H7A7xgx08V2X9xtyZpInWWTA+wZd/K0exc86B+ sje1QHOFuf3Y3d6taWpk3ohsI5BeLqmwXOC/1Vb4fEV/fsEWwoeyOg1xpUNnpD4C8ViGSgfcgiV MQ83TbwVw/baM3E/1ZIFnOkR8LejmzaQfj8betvLd8/Cd4e1Cm0C0rHURZtKgHH+AoaV0S84FIO kKZ7HRtbXRYh7BtSGry0XbfY477po8VhXUk0rbZeQvZ4EymKgfP7CG/m+jDH0fKkXzhs1h2SPdB oS25A== X-Received: by 2002:a05:600c:c090:b0:488:b683:a421 with SMTP id 5b1f17b1804b1-488b692e9ebmr50994655e9.19.1775559795818; Tue, 07 Apr 2026 04:03:15 -0700 (PDT) Received: from localhost (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e1fe0b0sm50289928f8f.0.2026.04.07.04.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 04:03:15 -0700 (PDT) Date: Tue, 7 Apr 2026 13:03:14 +0200 From: Christoph =?utf-8?Q?B=C3=B6hmwalder?= To: David Carlier Cc: Philipp Reisner , Lars Ellenberg , Jens Axboe , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] drbd: use get_random_u64() where appropriate Message-ID: Mail-Followup-To: David Carlier , Philipp Reisner , Lars Ellenberg , Jens Axboe , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260405154704.4610-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260405154704.4610-1-devnexen@gmail.com> On Sun, Apr 05, 2026 at 04:47:04PM +0100, David Carlier wrote: >Use the typed random integer helpers instead of >get_random_bytes() when filling a single integer variable. >The helpers return the value directly, require no pointer >or size argument, and better express intent. > >Signed-off-by: David Carlier >--- > drivers/block/drbd/drbd_main.c | 4 ++-- > drivers/block/drbd/drbd_nl.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Maybe I just missed it, but v1 and v2 of this don't seem to exist? Anyway, the patch itself looks good, thanks. Reviewed-by: Christoph Böhmwalder