From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 966CF3B6352 for ; Tue, 7 Apr 2026 13:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775569245; cv=none; b=W8Tlt2O0CPJiFbmvga3RElXusrW6bYsd+RxRCUpl1VmUwOqHNEIHGO2cX0lEfpNXEJNvTMhbmn5Gcclo1ppXE6MZajSp21WJ7wdJhUMnZFULsOZKckEJ4TEG30d80ZlDNrmN7MghBCHWiQ6NqirdigmfSyGJVtzaIldSNvVvtho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775569245; c=relaxed/simple; bh=riwk18SRd4iQnEcLD/FFavyohmSnoQh62FycEvrcHbg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZkpW3oO0TCiphMEI1jTh/NC2BSa3wExpToC6chyCsParVKsJX9JettQifDdQzOdlHbDMwSzjb0adB0Av3pLpOFJOzecWld3HSCE+cQ78C4lPLhdqXsgGEERSy+a71I6W5g8ZsiTKIYUGi5cWlO57iKV23P3TYcCnsGHrRPGbZgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=u0Sno2dd; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="u0Sno2dd" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XuxSZ5DXz8fu1kIf9zg6mcgh1utxKsYfdHwjn+bP9QU=; b=u0Sno2dd2/vBjVdkCrCSFH2n8p r4kzR11O6GbCYhkuSOEL36COn9L+PV8e0cvcLsaxJrI2EV4QvEcwpp59JAPn9JJA831IkeUWaovWO OSbxM3aOpPR1M+CdepxPY50sleE61PT+vNcqPiF3ky2POo/4XB5YqTJkF/7Y7THjCE+X/+Q+5umQD PJzH34pU6W6RdzgruKgEKd7c6kxvu2pkmbrUS7CxJ7AnoyCFJIwt9CaAtXS54+BFRgxzQICzMFQkB bGjTVPrwBL7coG9MZ2WrjmEsRml/lIv8WIuKu3Cb2PDSWrW10sbGgkOuG0/rDaCnflxKgTiagUFvH 2AgKlhiQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1wA6f9-00000003gNx-0OOJ; Tue, 07 Apr 2026 13:40:15 +0000 Date: Tue, 7 Apr 2026 14:40:14 +0100 From: Matthew Wilcox To: Jianyue Wu Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hannes@cmpxchg.org, david@kernel.org, mhocko@suse.com, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, baohua@kernel.org, bhe@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: move folio LRU helpers out of swap Message-ID: References: <20260407110002.204755-1-wujianyue000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407110002.204755-1-wujianyue000@gmail.com> On Tue, Apr 07, 2026 at 07:00:02PM +0800, Jianyue Wu wrote: > +++ b/include/linux/mm.h > @@ -39,6 +39,8 @@ > #include > #include > > +#include "../../mm/folio_lru.h" This is enough to reject this patch. I don't think the patch is a good idea either. Yes, the current situation is messy, but you're not improving things by moving it to its own file.