From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFABD2750FB for ; Tue, 7 Apr 2026 17:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775583228; cv=none; b=Ns3O6Gtj2iUrCJwFzIIDLXCDSL1uumeYpXW3HXxm50TZKwetQ6SMwZE7Y3UczrOYoxSRc5hKpoajnJXql/8jvmUpzfbpGm5D1b0a7SPcSV0oGUfrfEWrE98pXay3kscvkAgJkd/lzxmTN8cqkmUesrWgfc93Hzjo4Galq2q49ZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775583228; c=relaxed/simple; bh=hbAcVILzsOuDzrUm6rUn5eHZ+ljgdgopBBQU3dNMmmc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NidQTU/F2lnNKJDB+9gKGrjeEREriCl97gRrgpP+FQO2YDnunGvHUHs/bMitHTb/dGiMaZCYQxW/BPEzYXOyUvsftns94jZKorbSIUOVGgQg6TyC6xe+sB1vQLTwZEXP44cqlx+185xMtsU2SCW7fKhLv3Mq/gyhuaYkNheJml8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=XmWcJwvY; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="XmWcJwvY" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-8cfc085395fso457747185a.2 for ; Tue, 07 Apr 2026 10:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1775583226; x=1776188026; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iMPEJ4PSjOhLfHG2aITDvdb8l6v5fds0USOpCE6Wu38=; b=XmWcJwvYwEy22ilndrMzXVYcuMun0pBaeCcU3OfqhHvtLj1/C6DqEDEDXjne6v6Cfs z6dAS6cfGccMrzZZgN+mGw6I/E2xcOJpSlt3CunVzpal/eMGVFwyeV+XaczG0ETN1VFH nrMUH3qmUw7yJA6MiJSy2iL2jP2pjKqpHhw4NA1DtORhGcc4R5ul3Rd9IvuJ/Tsj9yLz fOEvsWWANNDGOkq93udOKakzq9fPChP2nlPuaK+pwZV7rOtqJ7nPXySB8psMQ5yPoLlm M5WBHR/rfM15l28VtJErzfv57enq6N4ogFbNoxdO5bexW1laaxi9ACUmNhqJG/CgJw32 EZJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775583226; x=1776188026; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iMPEJ4PSjOhLfHG2aITDvdb8l6v5fds0USOpCE6Wu38=; b=ayrneq5bTYqmZ7o86DBeKML6mpnmJHJsPA74ajthU4iYuEpQ4VxAql7w/Rgm2Wb3Ly yUbx4jBkIK+VTNijv5i9QsFaaLEn5L8WUOAYiuGd/rHxGbOr+a5qlHF5qmm/UijMWsM4 9hS6+dISCzbg0D9CEb58kNAX93+Q2f/MBo9jwOHIYrL3Onv5i1RZD98LpYSkJyTHIPcZ oVJV9AnxqxathkMF4/QYfwdsfGzu48p+wQWTK3Moh/kg/UVpY39U3+1bmmhRO7ULEb6H fM7QhkCgTJdJAKD+t1kjuUyxzFbQH72g9iiGTik7wQCZlf+kqGxraAfoIvlCMB+VNd+x LcPQ== X-Forwarded-Encrypted: i=1; AJvYcCXVKJzrcL6MFYWOE1tKBhkOTQAO9q+/+wXQJT6jl8sETO6neNT6n6iECN1Ji1C3oFlg1wfBWLQjAAWBhz4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw95yRnCyxKXFPKbTgiWtctSCl3OWRxXkn83wKaWI/zrQ69iu10 63jA/qNuQJbpB1wpbI6B4ucykwW4FXyApec0KBLl5YdGYbdxxEdZS8tyOaTBsAwMKBE= X-Gm-Gg: AeBDieup+XTYH8VaQPXEoujtjHIztu8IvTuUcol5l7FwhE66ikobjj23W11pBxMMBJF 917dM7vFU9iF7kwHrrbZp9hiG4s9p/B1EKmOsKXJOW4/HTBox1XsFPXv3DsWFfY5XGXNlkSx51T ZrRr7u+vbXMZPzT0vQo6HHWzgstwxN2Yo9DBwRDEC0AhwAPmgFlGOv+DQjTOTG/mqEo0sdSZDs3 xVg15sDRUkM10st5CMYwXIGfZX9FTM4HO2wCqX1RgOnVyE2cCLsu8nJTFRWVLeAOUoOcInnm5O6 26QwDpG2z58WfIFtg8qS7yEsI4hr9hxaJGBRe57eS2xDfonVLryB4I1BUDD6GO38o8jCPxz0QYe SlCQqL0K+yMe3NB6IznkWgwMKHiqWoCm/VirK/a3p0tknvd3A272MOJQ1ODSduut2gwFu/hEdA4 e5IQeFEucxQ4bKLZkIHacEgXG+k6BlfeHxV0BKejDXo4laqgndAezwQdgflsnVBKV9M2W0Ha1AU GYAUc0zEqY7 X-Received: by 2002:a05:620a:7108:b0:8d7:2745:6462 with SMTP id af79cd13be357-8d727457900mr1390116585a.38.1775583225568; Tue, 07 Apr 2026 10:33:45 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-71-191-243-150.washdc.fios.verizon.net. [71.191.243.150]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d6339bc438sm796063485a.26.2026.04.07.10.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 10:33:44 -0700 (PDT) Date: Tue, 7 Apr 2026 13:33:43 -0400 From: Gregory Price To: Joshua Hahn Cc: Andrew Morton , Jackie Liu , David Hildenbrand , Zi Yan , Matthew Brost , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH] mm/mempolicy: Fix weighted interleave auto sysfs name Message-ID: References: <20260407172350.699577-1-joshua.hahnjy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407172350.699577-1-joshua.hahnjy@gmail.com> On Tue, Apr 07, 2026 at 10:23:50AM -0700, Joshua Hahn wrote: > On Tue, 7 Apr 2026 13:09:04 -0400 Gregory Price wrote: > > > > Signed-off-by: Joshua Hahn > > > > Maybe - > > > > Fixes: 2fb6915fa22d ("compiler_types.h: add "auto" as a macro for "__auto_type"") > > I thought about adding a Fixes tag, decided against it because it's > purely cosmetic. > > ... but now that I think about it, I think this could break some workflows > for users who have automated writing to the auto sysfs file. > Yes, it broke userland software depending on that symbol being there (which, hopefully, is very little at this point in time). > Maybe I should add a fixes tag for the patch that introduced the > sysfs file instead? That is, > > Fixes: e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning") > The original commit introduced 'auto' and the compiler_types.h commit modified that to "__auto_type". The latter broke userland so that's the right commit to mark for Fixes. ~Gregory