From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C2FB35AC03 for ; Tue, 7 Apr 2026 16:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775578306; cv=none; b=GfEjtriV+RebzHTnZpFMHF/88hHowB9q90qge9FqT87zZzgItNChVSXwG1/ZDrw6T9eyOYCwIubNIJZE7xoGI7zNwzP999uI7e+SYJYL+EGaXAQKiOY9s+RKeKIfdVNvC3pdPzNr1t/JXtAHEYCY2ikgiE3rO02/zVOG6Q5+Szo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775578306; c=relaxed/simple; bh=1cQAJtgQmFluSDEROaDsoxsRqFAOZvbJmchOqmbAdGM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VKRpbxqWfj9gg/gav/S6Deq2I4kqs9HCaOWNOGbW2mD5B0FW2TD93V7qQ7jXybqy6rBT++Zz+6DuuhVYCf3E2K4SMhnBmzNqgKQqmH7aBznADifgR9cde1iwPdNzpuUGmy8xom6kvejguvCQJIbXiKSnk2ictzASFMDc11b4vDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lKwk4HPW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZM4EQrrv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lKwk4HPW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZM4EQrrv" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 637Cgq993816989 for ; Tue, 7 Apr 2026 16:11:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=fNt3t7bGHnmTY4XQLsyQYIDe 23zUVnDOM/yLMp7Jz6M=; b=lKwk4HPWDN8Jh6mKxHtwtmsIkQYS5NCmK631tWI1 r3vGNcZCUitnG8BkKgQ/4nxeG99R2KHtNzqF6nusOk544F06n5DQcbkUFMEL9A/4 +gi7yqNabk5HP4M3CNrawA8DJNAvIQDRvoH6MIDcd3lgqvo13Q0y9OubSj79saL0 VAZY/SwwubKz9F1Az4/v4j+5MCwjhdXGDCfgsOR3v3ZGm47cgIe2JCcNHTyfYHNE +yX0ECY7R7Clzg8t13tVRFzjEANj6NgIPze7UjH0wkj7wu6TbmESWycNp9npARxN VvSv4yW84JGA///lUPm3uLernh+KPT/MZRX6zPKEzZb6SQ== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr4ujk3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 16:11:38 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-12bfa367189so29612855c88.0 for ; Tue, 07 Apr 2026 09:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775578297; x=1776183097; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fNt3t7bGHnmTY4XQLsyQYIDe23zUVnDOM/yLMp7Jz6M=; b=ZM4EQrrv/4zGEoT1H0BHGwUwV7WLp4aTTA+TjNTPHhmWO7SbA+gT6c66job7fgWxY1 6y7aJbNAozu0XD8lgZSOgMZXLXxMYJgi6oeckKY7H7xOKRY7pYbTnwK3pGyGCNsgH1Ku cI7odln8mgOAXcE8T6FBvOh3ZW+9OdZH062+DZ+X8zumW7leuT/iFGkDe31Fe3PGJ04z pyBeAkuMOB41s2XwdNIXwFv98/6zgc14XG4oyytqsb3ft922vtNOea5x1L5d0ihga7MS JD9kbScGEkS7skdNUlwR9wmxFe1R43fJpfpbhBX2uHIPExay3zvCicwmC6AUnimw5+bR YQPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775578297; x=1776183097; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fNt3t7bGHnmTY4XQLsyQYIDe23zUVnDOM/yLMp7Jz6M=; b=D81eoTL7JswwsdN7lu7lWk7+VwPiC2Z9r6Uul4K6s5UVmywQ4fpEK3l46873QkiGqR oFmnxBgH8bUAr4GR7pVNE8S5ielPmRtsbVs4xNA4bMwTqaEjw6yQmXjocALDYpC8KyIK g1JGEbGpFNml3qD1DY497IDtUFds+XSi4Ga3sW5Aj4x8XURUzJk3F7mU8P6wgYIjJ234 prQZHLQzz5+1PnekA6mzY78JmxTm4rJk5W77/o1jb3ZCZWEt4L+FyeL41wUlk1MlzRA/ +rUbw13vJy0WAI7Uz+roQZWDlBpz/+i6i/kPPS6M1/yvD5q5HLzSK5z44zgY4Ex1igAu o+cw== X-Forwarded-Encrypted: i=1; AJvYcCX8AngYkOx79Yk2YEf7UOe+1bD4+5qSFJ0JFJcX9RVpzNHVGjjgt8afG1mlq97towhqywrud45Wqssm65U=@vger.kernel.org X-Gm-Message-State: AOJu0YzItroyeN7k38e5wrkszoUDDnolkmei7HiwaN9PfwI2BY5pld1Y 9/gs4aba03WSltTPaj712ZjWDpUVhRfwGNCbS8JnWxm51iquUCVQ8slKAUxFx0ZOelnP/i/WRon 4v6vCPN7ztl4emyQp86/ejKTOb+jlpB8EQEaZhxHCHrxe/Gt7owjFO6DZfCxxsffP2vg= X-Gm-Gg: AeBDieucWl+ep+Dha8y2bktwk0A3CsehrA9cQN1zUE15uWiohTDkb+PXlhvNV3bTgwV zYb9JXKDI8Kzksd+LRFqsKtpPyDB2LmA6kfqisgS4WOHLriuBl2a/MMDX7+i7sRaMOUnQ3Jgb/u IttdXceRBswnTUe8eWIyCytwxa6duOP334Wv74XK1ey1V542GUR5ji3JSDV5QJ9O89CSOLUrP94 /u59d3t7ZTEY3OPX/ZU+wX3fVQFiuvU2Bx7PWRbqFBmHTTXnl0cC3a7v7BzutjU5Gh/Iwd8GMg0 0s3jfJx1xgj7En2oUOk0Lh4j+53D42MQDHxJWvS7ubVQjE7r0KncQSxKRGWtGh79vjfYeeaIHzS w27/kYV0OjNqC/oZp1B+pW+adPDj7GuzmSQcYtrNmRDKrE7y3k+fsDvXruH3948ULp8RD9O8G6G I= X-Received: by 2002:a05:7022:ec17:b0:119:e569:fbb4 with SMTP id a92af1059eb24-12bfb770b25mr9183239c88.35.1775578297056; Tue, 07 Apr 2026 09:11:37 -0700 (PDT) X-Received: by 2002:a05:7022:ec17:b0:119:e569:fbb4 with SMTP id a92af1059eb24-12bfb770b25mr9183216c88.35.1775578296453; Tue, 07 Apr 2026 09:11:36 -0700 (PDT) Received: from hu-mdtipton-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bfea5f860sm14659495c88.2.2026.04.07.09.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 09:11:36 -0700 (PDT) Date: Tue, 7 Apr 2026 09:11:34 -0700 From: Mike Tipton To: Krzysztof Kozlowski Cc: Vivek Aknurwar , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in Hawi SoC Message-ID: References: <20260406-icc-hawi-v2-0-6cfee87a1d25@oss.qualcomm.com> <20260406-icc-hawi-v2-1-6cfee87a1d25@oss.qualcomm.com> <20260407-prehistoric-inescapable-loon-cf0dd0@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407-prehistoric-inescapable-loon-cf0dd0@quoll> X-Authority-Analysis: v=2.4 cv=dO6WXuZb c=1 sm=1 tr=0 ts=69d52cba cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=eVgXn4zF-6aLp7D_HksA:9 a=CjuIK1q_8ugA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-GUID: ZKCsxdJj7od1I_PFm4Hf42UIAtFvzVRs X-Proofpoint-ORIG-GUID: ZKCsxdJj7od1I_PFm4Hf42UIAtFvzVRs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDE0MyBTYWx0ZWRfXykOPROPGV/p0 mzxmKJK6rtr3ZiNE8UOCSGuKMBSUopDHfNAwMqbrDRx/hggTYRcDjYmqU2K7ORkQZuMOYM+lbkC Z2m5J68FpT8IYYy5E5KKKF+dVaFRAdySetKK4LKw7o4TXMpZ86ASMOX5og4bSLkBqeBDiC6+GLQ lZM0cjpg6sBN04JDbyRMS6z8hSxHlYjdzB+ItL/bs6M0KAwDsnkfTHrp0qENXKyCaCLCe/O1DZp BrUKrwwVKybfKGy5f9q5GzgC1tAsQKKJ8M/dEObuJNoUfNvtxj4jof/ItDhYe8K60iQajQWAz0h wi/TQ42buHzFlJx6rHyDnMDcGztp/o5t+W0ATLu3WWZrYN/Tx3MvTXI7kSQkdEuIDgE5GtkzipC RoLhB+F73tbxLc4lnHYj9gWiI1Tes0Aa5039gABHHhZU7rPNV5lSNO0Db6pNgv30chOMKsDBbI3 54UkqkSgin/L7NXOV6A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_03,2026-04-07_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070143 Hi Krzysztof, On Tue, Apr 07, 2026 at 09:42:09AM +0200, Krzysztof Kozlowski wrote: > On Mon, Apr 06, 2026 at 04:04:41PM -0700, Vivek Aknurwar wrote: > > Document the RPMh Network-On-Chip Interconnect of the Hawi platform. > > > > Signed-off-by: Vivek Aknurwar > > Same fixes needed I wrote to Hawi upstreaming lead in private. That's > why I gave that feedback (privately) very fast, to avoid repeating the > mistake. So since private feedback was ignored, you have now review on > the lists. > > All Qualcomm previous patches are poor: > > document the RPMh Network-On-Chip interconnect in Mahua SoC > document the RPMh Network-On-Chip interconnect in Eliza SoC > document the RPMh Network-On-Chip interconnect in Kaanapali SoC > document the RPMh Network-On-Chip interconnect in Glymur SoC > > Made by the same people. > > Why can't you look how Neil did it for SM8650? Or Luca recently for > Milos? Or if you cannot look at non-qcom commits then Rajendra for X1E? I believe you're mainly referring to the lack of "Qualcomm" in the commit summary and description? I agree that should have been added. That's understood and it was overlooked for this patch. Most of our other patches inherently have "qcom" in the area prefixes, but yes when that isn't present which should clarify that this is Qualcomm-specific. Thanks, Mike