From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D7C702EE611 for ; Wed, 8 Apr 2026 11:02:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775646140; cv=none; b=fB1YWcoD5sJF6o4ZVNp0D1uO9N3PX7FrO+YJckzPGWt7JeE24u97Ghtm3ZpkqiuAsdpfm14EAjjvjr3rDqB/ns6XCqs403RVO1gJjJqdRgKA+jAai09glz7MFNH8eCZLl5O/N0MoQ72otW42PSzvOl6OWdeglVdFQXWk7ZjeVmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775646140; c=relaxed/simple; bh=7VE/oN+zNWKqLjgFETre/X5q6PBvSvRShw5YJFsm2dQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UuvvrsRMwWVsJJAZbfwIk1HP/6BdCCsYhrTPhk2YBlX6QLEjOi3JO4x4spY3L5Nbj+y4/EB6uwpqe0txLnfR7RCh9JDad5oTTzh9Ba9CJjthkYmvbtqBq0Rj1jzCtsKP0+js2U2f2CaVP8PIXLnTqOjNWtVSmFKS+2XSitVctZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=bLfyZa4Q; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="bLfyZa4Q" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82CEB359A; Wed, 8 Apr 2026 04:02:13 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B803A3F632; Wed, 8 Apr 2026 04:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1775646139; bh=7VE/oN+zNWKqLjgFETre/X5q6PBvSvRShw5YJFsm2dQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLfyZa4Qj3YHaKrT2yEHn8lydBLHeGjkpwD5gRsfChAsklDel2Jb2gBmYW2r5BFKb x+qJ0VHra2Z14ax/mFV17GZUzkbdwLYyINl6XLSscQPFDnAbNfm19UOVlPyPQuXS9Y 45xXfD7+hpqCaAox+jEfEzTsEEN8l93e6tEL58xs= Date: Wed, 8 Apr 2026 12:02:14 +0100 From: Yeoreum Yun To: Leo Yan Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@linaro.org, james.clark@linaro.org, alexander.shishkin@linux.intel.com Subject: Re: [PATCH 1/2] coresight: etm4x: fix inconsistencies with sysfs configration Message-ID: References: <20260317181705.2456271-1-yeoreum.yun@arm.com> <20260317181705.2456271-2-yeoreum.yun@arm.com> <20260407143028.GM356832@e132581.arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407143028.GM356832@e132581.arm.com> Hi Leo, [...] > As Suzuki suggested in another reply, we need to extract capabilities > into a separate structure. I'd also extract status related registers > into a new structure: > > struct etm4_cap { > int nr_ss_cmp; > bool pe_comparator; // TRCSSCSRn.PC > bool dv_comparator; // TRCSSCSRn.DV > bool da_comparator; // TRCSSCSRn.DA > bool inst_comparator; // TRCSSCSRn.INST > > int ns_ex_level; > int nr_pe; > int nr_pe_cmp; > int nr_resource; > ... > } > > struct etm4_status_reg { > u32 ss_status[ETM_MAX_SS_CMP]; > u32 cntr_val[ETMv4_MAX_CNTR]; > } Hmm, I don't think the cntr_val doesn't need to be separated into etm4_status_reg since they're configurable by sysfs. BTW from etmv4_config, I think parts of capabilites are only: - ss_status - s_ex_level I think it would be okay to include all of this information into struct etm4_cap not dedicate etm4_status_reg structure. BTW, Is it required to sustain TRCSSCSR.PENDING in sysfs after re-enable sysfs-session? (enable->disable->enable) while it's always cleared in perf mode? Thanks! -- Sincerely, Yeoreum Yun