From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCEED37AA98 for ; Wed, 8 Apr 2026 11:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775647668; cv=none; b=A9BSdKmNyFtjwdd+MOj9xK7itjqaGuJOxb2EwddWYzUlUjbsQYJ2YTCkw1iBznaNUKifm9VtfG9TmZX1405PDjJAM2ZK9fKJ6WK0zu7x2oI5KqKo5vsKZCoK78bbwMMD+SBKm4tRK7YLdYta4yRdwKuScz1sCb6HcwaFCPU1VjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775647668; c=relaxed/simple; bh=/8LmPIEP/Tr9DEnt8ZTpwgfcytxWaNmStAUNyJnf90M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FeajUBVzszUjflJ5TBtJZNcX/lrlGOSlhU8oq0cgyx9JAixQEV9B2SNoHylMi+6IFBDZ3D86KqakFt2JoA7csZamsCZYQreChn+ZrzYzpgxfM7PbS9ou9HhayjzfvNIkfL0yHc5gLblT5egofQIv3b/ghqlRnrA9kJT7+6qIo8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GgbXYTbR; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GgbXYTbR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775647668; x=1807183668; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/8LmPIEP/Tr9DEnt8ZTpwgfcytxWaNmStAUNyJnf90M=; b=GgbXYTbRtcCO25QEel7Zlb8MoLped2jPWviGQ3a4RYOfSQ/42AcZYGSM 7RVY/pi1UFAaGolKD0NIwifr5k/zomyOsFvRxdUNpozVg9O1MRNg90akt 87+9hIlsKU/mffQE2MaawQci4GYpKA3vqI7+uXRzpONVB6K2Y7C/3YvBM OdbrCZvIidxdXzh1X25wMWrTzUEBMMlYnFaxmLNdA5dFVL83GDUmOmcof OqxkoogolxrydmMMaeZJgkSU8k5KnpRov0C8kiie1ufn0OBLOrvDZxVud AeUTeK2MStDXPt5rD0I4fBZOKgN1AqwhIN25glePEE7KFwAxNVU485Zoe A==; X-CSE-ConnectionGUID: 9OXc10gCSSy91ySFILpjnA== X-CSE-MsgGUID: WAbFokyFRkKPz5y2kBbzVw== X-IronPort-AV: E=McAfee;i="6800,10657,11752"; a="88012134" X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208";a="88012134" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 04:27:47 -0700 X-CSE-ConnectionGUID: dQmf47jTQNCkbErWvNhPvg== X-CSE-MsgGUID: lFAgsKeTQsuc9wb8S8udxw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208";a="230114381" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.72]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 04:27:45 -0700 Date: Wed, 8 Apr 2026 14:27:43 +0300 From: Andy Shevchenko To: Lukas Wunner Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Subject: Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame Message-ID: References: <20260204012630.2211832-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Apr 08, 2026 at 08:35:52AM +0200, Lukas Wunner wrote: > On Wed, Feb 04, 2026 at 02:25:27AM +0100, Andy Shevchenko wrote: > > Compiler is not happy about used stack frame: > > > > drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer': > > drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=] > > > > Fix this by factoring out do_write_buffer_locked(). > > FWIW, the issue only occurs with CONFIG_KASAN_STACK=y, so an alternative > to refactoring the function is to disable KASAN for this particular file: I would like to avoid such big hammers. Somehow I lost the track of this patch, I need to find it locally and check the status, I will come up with updated one once I found the latest version. -- With Best Regards, Andy Shevchenko