From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B66B388E61 for ; Wed, 8 Apr 2026 07:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775634036; cv=none; b=XpH05H4IJZXQzU2r7BX37EZIPLtFah4eodcm9AQWuVpM54FTleNpOJsQCxYe7qLN9G+H4+vEui/yi4cZFHSjCw9pfGk1looO0O8Iggwc1auf2q2Kb8hH4HYcPfmWV8nExcCyhFENTRR5YZ+YQwmTa4jMBPWuEARR70CMeb6IZHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775634036; c=relaxed/simple; bh=ruT9fHvv7+6JiRY3/fpKZBu74HQlu+cTKGiEJh/M4Z4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HnJBYl6CpYTmrIrjjE4VK2oy2nD/ES/JLwdvXIL4dYEa0t77B//2eJo0iiqvkpjh332eTk653Ad0zP3zrBQCOS90vARyImtcwhXVgo7H/3N2z9mD2/CWqDhHNr5Bwf0V1XqJ5e82jocdDTa1Zvk1nuSf1FSKa9UNnxtFJg84nwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sQn7MMoo; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sQn7MMoo" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-483487335c2so60646755e9.2 for ; Wed, 08 Apr 2026 00:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775634033; x=1776238833; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0mL8hBd7svM+oHdl0KgcAFujd7BacdqcxKlG5vQmrck=; b=sQn7MMooGEL4LxTa4o1ozOIxnSUlafJrlINohmCBg1oLU7SAbBLtcNboEue5wd6Gge O+8OdV03kEK00pmgEYdAhzb75m9Fto5qvxCkxtWn0jhtZcg5TjgvFFfm5EOr3aM7Fad9 woT9ZgDQ3OaiJVXDbNn3mrwr9Jt91Uf2Ax1bUJrZDE8l9n95/csTQIDLYhsURGDgt5Hs u4acDH/DVpgGPrBL8flZEIrgjhFy6dT3gFUTUw4qb+HO6gRLDS0Eh1dvWuo5SAov5UMX QXZ4G8gwQVokbxQdjoIVKK4c4AvccLN4efgnXAURvNwdFuN1KkrNQG42ciErQIMfHO7p KeSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775634033; x=1776238833; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0mL8hBd7svM+oHdl0KgcAFujd7BacdqcxKlG5vQmrck=; b=Gp5TG3cbmd5x2QqTvd/OrK8+WvfQ7liXZyH41DIqHi+OqUY2dyHmq/dNi/PPwDx0oX KpazQDLK7+kLO8Jr8FfVyZ1vn43njtVkCrHi8ZeBBVM/RFF5LXr2Df1jA75tlmHHcGNw JsJQxMqxbvjyL3R8ppwSkiJTOejNU9WUDnYsfBi6VM65p+IReJDDaPe5CKFp7nX9dEAk TcYGouRaqNzo29OYrululbzuIrL1+YCwrs/2gwHTR59HN3RY9nnKjqiPK1KUFwDU7o/B SYi0XPjjk6eHzGEenVxLcQTZ9wUqpaDCnBf+6SRwPkkyDYXMVbRtISdVnwPd3cXY/eNh Kpcg== X-Forwarded-Encrypted: i=1; AJvYcCW11z4eKpbjpvtL6quFbX8mb0JLUXNiL3TomC3J2xw4sQ6MI9kT9qpPydRuox4EllF66DfCbICNa9Bzkhw=@vger.kernel.org X-Gm-Message-State: AOJu0YxNmo9UWV8ACIVK9Xhd015jQTjZNP5NghbWUzmyzWSda61PDh6K kN0sNXXONrCEK3rRIH/MNsPrRzgTAIAqmqOfR3lk2PeNcNS6UYwTKX/P X-Gm-Gg: AeBDieudCytIxYwEJAwCSS9OQF2dYoItpoVHeLFhivgiYBVTAvlaB8ULNCKS3DjAN6m wWRUvSL3mwcDDJYCB0FcoR/pIQm7EbPZGXIJ9XkqqN1l6KKQtuOBlcRp1QRuT51v+S/ts8PX/d+ pJMlQ+vUcagEhkpwCU9MVfmw/RNOfQjIyBh99CQOL3NKXssb5VVxmspieVMUWN/6vEOSOXSH3Xe JN/byNDpzf4LPthqNO5FKJq1lee4nD6foi/8saoXTCKJMvzpHMXz4JU/b0W6oE5TrRyHsHEcBf+ Aeqc5cdR0ko6Hl/oTHjcqjbrxhODogxOkzzHSCnkbxuGiJDHVuH5vJ6OMcj/lrBQROAQIyFH/vk vAeuQ4mD+h0FjBQhnFWSeCLo3Rv/VMWtRFNRsT0cEnjd5qAA9yXAzqsgRARPVzGnZ+2d5CZuXEg retz0hvyTjY2CRuwIqmvurj8nJA0vnHw== X-Received: by 2002:a05:600c:6085:b0:488:b239:77ec with SMTP id 5b1f17b1804b1-488b2397962mr134666495e9.17.1775634032762; Wed, 08 Apr 2026 00:40:32 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488a91686f9sm350538545e9.10.2026.04.08.00.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 00:40:32 -0700 (PDT) Date: Wed, 8 Apr 2026 10:40:28 +0300 From: Dan Carpenter To: Hungyu Lin Cc: gregkh@linuxfoundation.org, b9788213@gmail.com, ethantidmore@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: rtl8723bs: convert xmit init path to standard error codes Message-ID: References: <20260405232534.14122-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260405232534.14122-1-dennylin0707@gmail.com> On Sun, Apr 05, 2026 at 11:25:34PM +0000, Hungyu Lin wrote: > Replace the use of _SUCCESS/_FAIL return values with standard > kernel return conventions (0 on success, negative errno on failure) > in the xmit initialization path. > > Specifically: > - rtw_os_xmit_resource_alloc() now returns 0 or -ENOMEM > - rtw_alloc_hwxmits() now returns 0 or -ENOMEM > - _rtw_init_xmit_priv() updated to propagate error codes and use > direct truth checks instead of comparing with _FAIL > - caller in os_intfs.c updated accordingly > > This improves error propagation and aligns the driver with > kernel coding style. > > Signed-off-by: Hungyu Lin > --- Break this up into a bunch of patches: patch 1: Change _rtw_init_xmit_priv() to use direct returns and get rid of the exit label. patch 2: Make rtw_alloc_hwxmits() static patch 3: Make rtw_alloc_hwxmits() return negative error codes and update the call site to look like this: res = rtw_alloc_hwxmits(); if (res) return _FAIL; patch 4: Move rtw_os_xmit_resource_alloc() to drivers/staging/rtl8723bs/core/rtw_xmit.c and make it static. patch 5: Make rtw_os_xmit_resource_alloc() return -ENOMEM on failure and update the call sites to look like: res = rtw_os_xmit_resource_alloc(); if (res) return _FAIL; patch 6: Change _rtw_init_xmit_priv() to return negative error codes and update the call sites to look like: res = _rtw_init_xmit_priv(&padapter->xmitpriv, padapter); if (res) goto free_mlme_ext; Making the functions static makes them easier to review so we don't have to jump around between files. Doing it one function at a time is easier to review because we don't have to remember all the functions which were changed. Direct returns are easier to review because we don't have to scroll to the bottom of the function. regards, dan carpenter