From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BF8B3E559E for ; Wed, 15 Apr 2026 16:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776271821; cv=none; b=M191D7C/K9o3YWH1xprfNGNjLWTYacNZqkvKSjGDL3O2vkEYzgEPBM8ZZvmh6XJEnBXA2p78YtJPCoDALyXlZW3qmj9Et0pLtUp2iFuHv2wZEk84cijhET1H53LNNFSP9iIr/X0uqJrpA++Xx8S/I/9E5QD4VJpGUcJ+8mPScN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776271821; c=relaxed/simple; bh=+d0Q4WGKM5f5Bewo3//S+QANGhhTTe9Ktg/xQlvAyrc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ye5wN1QcmfzWd8tRSDYCfkZ4/MXUdeUOajsms6WFsDIasKSRszRIHw7ShI47pKqLFqG9wAaBXoagtPfCm5fGBQw5srldFMwADSbLTN9AhYB4pasM11ZRjtNUGF3U892BaUBDwGj0x+koAPutdjuDdJ9G3zokROScCUATjGXkHdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RdKjHkbk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RdKjHkbk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 125D3C2BCB5; Wed, 15 Apr 2026 16:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776271821; bh=+d0Q4WGKM5f5Bewo3//S+QANGhhTTe9Ktg/xQlvAyrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RdKjHkbkWPShcQ7Wej/yBbQQk5+/0TNoeIUZ8VDLHoSJcfYchcXbS2UkYYtLGrqKH ABBvhwcjZ5Vxd1a7uI0Tf1vW/oElnxDoIN3cPaMZdbam5PfkWTh3+wV+EOH62jN+Oc /OAjng8aIY8DIHpK9SoWIicF8aKlOhRl3Wo7kx6MHWnPEWI6keNaclygqNBsdzjVtE rm363qqmq4zZOTvicc5IwVLzcFNp+WZhLi3L2jNGOHPf30pYWLumEuEnFVso4uuL1d +kFmhHN4vAEj2gszUX0FA5bRHs382RWb4FgLNWtfvA5eXE2ir+U/BxBQID7BMP3CqG o1BBxBbAcs7+A== Date: Wed, 15 Apr 2026 17:50:16 +0100 From: Lorenzo Stoakes To: Shuah Khan Cc: Andrew Morton , pfalcato@suse.de, vbabka@kernel.org, Marco Elver , Brendan Jackman , Suren Baghdasaryan , linux-kernel@vger.kernel.org Subject: Re: Duplicate headers in tools/testing/shared directory diverged - rcupdate.h Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 15, 2026 at 10:39:05AM -0600, Shuah Khan wrote: > All, > > I am sending this email to you all because you touched tools/testing/shared > and its sub directories and show up in We need to add these to somewhere in MAINTAINERS... > > get_maintainer.pl -f tools/testing/shared/ output > > rbtree compile failed as it couldn't find urcu.h Presumably liburcu is not installed. > > cc -I../shared -I. -I../../include -I../../arch/x86/include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined -c -o rbtree_test.o rbtree_test.c > In file included from ../shared/shared.h:11, > from rbtree_test.c:9: > ../shared/linux/rcupdate.h:5:10: fatal error: urcu.h: No such file or directory > 5 | #include > | ^~~~~~~~ > compilation terminated. > > This sent me down the path to look at the duplicate headers in tools/testing/shared > especially rcupdate.h which is under tools/testing/shared/linux > > It appears this file is an exact copy of include/linux/rcupdate.h and now it $ wc -l tools/testing/shared/linux/rcupdate.h 12 tools/testing/shared/linux/rcupdate.h $ wc -l include/linux/rcupdate.h 1196 include/linux/rcupdate.h Umm, no? > diverged. Why do we have these duplicate headers here in this shared > directory - it appears they are out of date and lead to maintenance problems. Because they're not duplicates of one another? One is a wrapper around urcu, your problem is you don't have that library installed. Unless I'm missing something? > > thanks, > -- Shuah Thanks, Lorenzo