From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.1 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793986539; b=kDMlAjrb6XiW4QjjkQu63CggD5Lf8LbPsyE3fzp6UzwLH44fVL7bWURrfY6rjKn79SXm V1NAMDsxjn5o0lFD/NGwrRfkT9xX5/PopYrhMBHtP/OAJanMJ4mQVLnUpisGvgL1312Iu tNlEmSSkxg3v/QCptUVwUegjhcsH0o3Id/yW/yEx0ZsG9pmKoQlbdSOgrM2oh6/4JmuOi +FgJ8xvPO8q3CuY1muubMsguQX+Y2GY62NJT411N1M8El7EjCEJRSw/zZ9FLY/ivuJPai gpcw+k53j3qpMQSjd5zfBWQtPwvZ6fhEPlTKdmM6ZUKYquf4CgQ5jcN5zpIdsP+Wyyg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793986539; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:MIME-Version:Date:Content-Type: Content-Transfer-Encoding:From:Message-ID:TLS-Required:Subject:To:Cc: In-Reply-To:References; bh=9h1qWQSo2bfZtMhtQwi2j+0baKULX5LG8qfPi6Czi9Q=; b=Tyg3H8xR+rF39DJKX1fZRk1Xn4L9EydfZc4QXtthNio9cxtS+qXJyy+RVU0i+h1nl2Ia udJtP01BHTODojk0K+nDXUcnbEzvz3wFRc/A4ANvidNTvYpvPCIPuLXx0FfgXHzmJ5Cyx Qg1TZY3TCAFzGUI0evuqG2Gq+w27J10E6lxyDoGlyqIjSC8TOiaWSOJm2hAo5eHsjp7oa 5Mlq/3l10VZcMtRcDMXhfGz2wgIJHLedrqWo+MHXGJ19BddeNGUA7HIzwuaCtiM02I/nV d276p4lUcbbLSiT+15TZImcoV2PNx+//kazgdxkbEula7rsXVljX0gGzVzf16RMsQrA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b="lct/ELIR"; arc=none smtp.remote-ip=91.218.175.1 Received: from mta0.migadu.com (out-1.mta0.migadu.com [91.218.175.1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D15F606A32C for ; Fri, 6 Nov 2026 17:35:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2D15F606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=lct/ELIR X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=UAw4luFEqDTEvPhZffw7Um2r/LrzYhDoiu6+Pdiro9g=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793986535; v=1; x=1794591335; b=lct/ELIRKuHBomUTFoBq19HCaAcqSwoOz7FBS43kZ2ktXBRCBfNn0vvUTJwcscU4GLs44nP3 pybKJeeh2ZVKNqP+onVr1faCtmxHnynN1vsBbbmSBnWpFhGvMC1z4tHwBlmwufIaQqfTqhDteW6 YUxvRLBrI2z/7LFTWGZqC+cA= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id df4875bbaf29c7f8; Fri, 06 Nov 2026 17:35:24 +0000 X-Mizu-Trace-ID: df4875bbaf29c7f8 X-Migadu-Flow: FLOW_OUT X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Date: Fri, 06 Nov 2026 17:35:23 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Luka Gejak" Message-ID: TLS-Required: No Subject: Re: [PATCH rtw-next v2 7/7] wifi: rtw88: 8812a, 8821a: respect peer A-MPDU size limits To: "Ho Jie Feng" , "Ping-Ke Shih" Cc: linux-wireless@vger.kernel.org, "Ho Jie Feng" , linux-kernel@vger.kernel.org In-Reply-To: <20261031070950.425176-8-hjf3108@gmail.com> References: <20261031070950.425176-1-hjf3108@gmail.com> <20261031070950.425176-8-hjf3108@gmail.com> Hi Jie Feng, Two small comments below. October 31, 2026 at 8:09 AM, "Ho Jie Feng" wrote: > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821a.c b/drivers/ne= t/wireless/realtek/rtw88/rtw8821a.c > index f7391f6aa3039c7ba4d88249d968a5f1763ea866..f597edec290f64fda1c4578= 12b240515360dc387 100644 > --- a/drivers/net/wireless/realtek/rtw88/rtw8821a.c > +++ b/drivers/net/wireless/realtek/rtw88/rtw8821a.c > @@ -49,6 +49,13 @@ static void rtw8821a_cfg_ldo25(struct rtw_dev *rtwde= v, bool enable) > { > } > > +static void rtw8821a_set_ampdu_factor(struct rtw_dev *rtwdev, u8 facto= r) > +{ > + factor =3D min_t(u8, factor, IEEE80211_HT_MAX_AMPDU_64K); For a VHT peer rtw_set_ampdu_factor() passes the VHT exponent here, so IEEE80211_VHT_MAX_AMPDU_64K would match the 8812a version. It is the same value, so this is only about readability. > + > + rtw_write32(rtwdev, REG_AMPDU_MAX_LENGTH, (8192 << factor) - 1); > +} This is the same as rtw8812a_set_ampdu_factor() apart from the limit. Maybe a single rtw88xxa_set_ampdu_factor() that picks the limit by chip id, like rtw88xxa_set_crystal_cap() in patch 5 does for the mask? Best regards, Luka Gejak