From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "tanghuan@vivo.com" <tanghuan@vivo.com>
Cc: "avri.altman@wdc.com" <avri.altman@wdc.com>,
"ebiggers@google.com" <ebiggers@google.com>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"minwoo.im@samsung.com" <minwoo.im@samsung.com>,
"opensource.kernel@vivo.com" <opensource.kernel@vivo.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH] ufs: core: add caps UFSHCD_CAP_MCQ_EN
Date: Tue, 22 Apr 2025 07:51:39 +0000 [thread overview]
Message-ID: <ada5e578b647b71e85ab1a7eccd7401f7b4d2700.camel@mediatek.com> (raw)
In-Reply-To: <20250422062555.694-1-tanghuan@vivo.com>
On Tue, 2025-04-22 at 14:25 +0800, Huan Tang wrote:
>
> Hi Peter sir,
>
>
>
> Thanks for you reply!
>
> I found that using low-end UFS in SoCs that support MCQ may cause
>
> device latency to reach extreme values.
>
>
>
> My idea is that after having this patch, I can add hba->caps &=
>
> ~UFSHCD_CAP_MCQ_EN to disable mcq via ufs-qcom.c or ufs-mediatek.c.
>
>
>
> Do you mean to add a caps UFSHCD_CAP_MCQ_DISABLE?
>
> Or remove hba->caps |= UFSHCD_CAP_MCQ_EN in ufshcd_alloc_host,
>
> and then add hba->caps |= UFSHCD_CAP_MCQ_EN in ufs-xxx.c, such as
> ufs-mediatek.c?
>
>
>
> Thanks
>
> Huan
Hi Huan,
What I mean is that you need upstream code to disable this flag.
hba->caps &= ~UFSHCD_CAP_MCQ_EN
But this seems a bit strange to me, as MCQ is a UFS host feature.
It shouldn't be related to the old ufs2.x device.
If it is ultimately confirmed to be an issue with the UFS device,
you can add a device quirk to disable this flag.
Thanks.
Peter
prev parent reply other threads:[~2025-04-22 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 13:51 Huan Tang
2025-04-21 13:58 ` Huan Tang
2025-04-22 2:55 ` Peter Wang (王信友)
2025-04-22 6:25 ` Huan Tang
2025-04-22 6:57 ` Bart Van Assche
2025-04-22 7:22 ` Huan Tang
2025-04-22 6:57 ` Avri Altman
2025-04-22 7:04 ` Huan Tang
2025-04-22 7:06 ` Huan Tang
2025-04-22 8:11 ` Avri Altman
2025-04-22 7:51 ` Peter Wang (王信友) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada5e578b647b71e85ab1a7eccd7401f7b4d2700.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=ebiggers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=minwoo.im@samsung.com \
--cc=opensource.kernel@vivo.com \
--cc=quic_nguyenb@quicinc.com \
--cc=tanghuan@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®