From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751189AbdFEPug (ORCPT ); Mon, 5 Jun 2017 11:50:36 -0400 Received: from esa7.dell-outbound.iphmx.com ([68.232.153.96]:5313 "EHLO esa7.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbdFEPuf (ORCPT ); Mon, 5 Jun 2017 11:50:35 -0400 From: Cc: , , , , , , , , DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=j5NNWNsM66qRYroAFMcTcAfasDi5BY8BKWpkdk9xt5+IuNOs72uLnB3F TwWLddsU55AFOztzWBnw4upABRoXbbUJioPjv3+0UhQjD/3HVVyK0xoJh 5P1ZxX00JCliktk4CU6cQnCTjxmHbJY2xlK08CZEIbTGqcrBWoYXLFaJX 4=; X-LoopCount0: from 10.175.216.249 X-IronPort-AV: E=Sophos;i="5.39,300,1493701200"; d="scan'208";a="25881850" To: , Subject: RE: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs Thread-Topic: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs Thread-Index: AQHS3hJ37EujnwisJEaskjaJeXmwDKIWaoNQ Date: Mon, 5 Jun 2017 15:50:24 +0000 Message-ID: References: <20170602140524.23367-1-mika.westerberg@linux.intel.com> <20170602140524.23367-20-mika.westerberg@linux.intel.com> <20170605081437.GA7519@wunner.de> <20170605093249.GK3454@lahna.fi.intel.com> <20170605120756.GA7793@wunner.de> <20170605125507.GL3454@lahna.fi.intel.com> <20170605133334.GM3454@lahna.fi.intel.com> <1496672494.22624.4.camel@linux.intel.com> <20170605152036.GA19810@kroah.com> <20170605154057.GQ3454@lahna.fi.intel.com> In-Reply-To: <20170605154057.GQ3454@lahna.fi.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v55Fodls001303 > -----Original Message----- > From: Mika Westerberg [mailto:mika.westerberg@linux.intel.com] > Sent: Monday, June 5, 2017 10:41 AM > To: Greg Kroah-Hartman > Cc: Andy Shevchenko ; Lukas Wunner > ; Andreas Noever ; Michael > Jamet ; Yehezkel Bernat ; > Amir Levy ; Andy Lutomirski ; > Limonciello, Mario ; Dominguez, Jared > ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs > > On Mon, Jun 05, 2017 at 05:20:36PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote: > > > On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > > > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > > > > > > > > > > It turns out that this is not too big change after all so I think it > > > > can > > > > be included in the ICM patch if you want. > > > > > > > > Basically we would have module parameter: > > > > > > > > cm=auto|native|icm > > > > > > > > where auto is the default. > > > > > > > > Does that work? > > > > > > > > > I remember Greg is opposite to being fan of module parameters in new > > > code, so, please, if you are still going to do that, do it a separate > > > patch which will be last in the series and can be discussed separately > > > w.o. preventing everything else being applied. > > > > Yes, you should never need module parameters in "modern" code. As no > > one will ever set them, or know what to do here. Make it "automatic" > > please. > > Well in current series it is already automatic :-) > > What Lukas wants here is a way to force a certain connection manager > implementation to be used instead. And presumably that's mostly for debugging purposes and will lead to additional quirks to get "automatic" to do the right thing on those machines that's it's found to be needed or more beneficial.