From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3700C04A6A for ; Tue, 8 Aug 2023 19:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234409AbjHHTrP (ORCPT ); Tue, 8 Aug 2023 15:47:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236707AbjHHTq7 (ORCPT ); Tue, 8 Aug 2023 15:46:59 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 308C94C07B for ; Tue, 8 Aug 2023 09:50:57 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-99bfcf4c814so860823866b.0 for ; Tue, 08 Aug 2023 09:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691513455; x=1692118255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sQgrfQw0P6pTmKNcUIhzKP/rgp8qN+H1U22DXchyEX8=; b=ZOFyNE+ty10UCoRS0Y18vaTBm0DCmXV0QIDPOX/RKxcTUhgyKOJFalFUfTWnJJp+IP nhdXzQSkoeX8fJXTCz8ZrEE2jB5+Ct28xpC1mj2cUEoKSDwFpwq7kjPU2iD/rAq1zngp ke8aFBq1bkgxzoiRqtfBqBTPq8XMxer2SX/m6VCV95gyJO8m4KLt64soJ9Qt2pQQrLye mF403RqSXZ7GobUULx1o+2ggaCpOyW3KovZdEk8U4VTF+6hgmjGfSJyt229w/EfL6XRi siJC52iFtGVlRQUGe6ubkgfpEIVYJzwcODsLm3vmWBgzN2ubIz4NT8IR1U8GkjjIemTz n08g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691513455; x=1692118255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sQgrfQw0P6pTmKNcUIhzKP/rgp8qN+H1U22DXchyEX8=; b=RywFTwuZSCyx8F5lKHgm5rXW2fFlALxoDoARsZSqTCCTeMaeZOKifPWrLYz3mdLx+H ykAmicOgNUnZwXHpsHkl71uQFcZhcCIvfkNGeu8VYCnKSQFRIWwvp1VxMFMEWEvvx06F NJqjk4w06UG5ALuS7B//0C4Oh04kPeam7KXxNrtmoOjn1bCjJPSifMfisnJuo82L0+Se OiMA0541dpPUXTwRFHe8wKLn42z2/VGr32/pjEj+ZbTPP0u9vazzTGpnyLDelsmCJOrm fovZARxULLal16cbJdUziVAzEH7Fb0FmOKKbd8tNC3qzR3MFLS1vleUYUCSNq1RVcRi8 KYWg== X-Gm-Message-State: AOJu0YxunO6txGfeA46F2FwV3kS8eQTUz67sm7q9hprZ+3k78uVJ1UGv FilAKTAFFv6Dh3yq8QLCstuT3CoOlW2tGobOSrE= X-Google-Smtp-Source: AGHT+IHOV1+SwptyB2y6PObKLYIfXb0SnPIa+qNzfFQDPldY+tNhzDRnIS3lyd9q6xt4sZxlqEOpfw== X-Received: by 2002:a17:906:84:b0:99c:980:d551 with SMTP id 4-20020a170906008400b0099c0980d551mr10554435ejc.50.1691483778414; Tue, 08 Aug 2023 01:36:18 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id k2-20020a1709063fc200b00993470682e5sm6344518ejj.32.2023.08.08.01.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 01:36:17 -0700 (PDT) Message-ID: Date: Tue, 8 Aug 2023 10:36:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 4/9] i2c: hisi: Use dev_err_probe in probe function Content-Language: en-US To: Liao Chang , andi.shyti@kernel.org, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com Cc: linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-5-liaochang1@huawei.com> From: Krzysztof Kozlowski In-Reply-To: <20230808012954.1643834-5-liaochang1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2023 03:29, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. > > Reviewed-by: Yicong Yang > Signed-off-by: Liao Chang > --- > drivers/i2c/busses/i2c-hisi.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c > index e067671b3ce2..6fc8d6fa43b6 100644 > --- a/drivers/i2c/busses/i2c-hisi.c > +++ b/drivers/i2c/busses/i2c-hisi.c > @@ -462,18 +462,14 @@ static int hisi_i2c_probe(struct platform_device *pdev) > hisi_i2c_disable_int(ctlr, HISI_I2C_INT_ALL); > > ret = devm_request_irq(dev, ctlr->irq, hisi_i2c_irq, 0, "hisi-i2c", ctlr); > - if (ret) { > - dev_err(dev, "failed to request irq handler, ret = %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "failed to request irq handler\n"); I don't think this is needed: https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/ Best regards, Krzysztof