From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 435023644AF for ; Mon, 1 Jun 2026 08:50:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780303851; cv=none; b=Cg2JpLEejA9Cj+Ix2ksrNKDIKDpUqk7CkOXpDO2AAOVwYcz8ZA6dLI/MJA1HrRWRYekGKZyAQwjQMjKy0jy3b2N3v7Td6xDWDltDXerMVQdh6r0L9GxChKtlQCckOsZe8ezvTiG+VsEPO559V1uReV5/dy/MkKoliIONqmq2C6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780303851; c=relaxed/simple; bh=CYZ1Vy2By+yBHIYXTEtf5uBHc5ES7CBnEUGYuN7XzeE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dn3yxmePhr1vQKBulz6lRmIlZt/knkFxwxchZDMVbITtUpNahgB8g5vJj77j3N1ZvhYjhupx19FXL3E9pt2GaRIX7UtT7fuP+A8nu3xjWIRCpBfAArLc+FqnVckN0d+YBf+gAAm696bKGI6Xm7MMBffqqgYs6KMm4DGBz7l2wcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X5OwSdP+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X5OwSdP+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57F641F00893; Mon, 1 Jun 2026 08:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780303847; bh=DOXmX21/fHF25zTKpMhWR+5TihwK4YQ+etb6BdX+TIg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=X5OwSdP+fi0Uaehu7DjVQsFNIdLpyaoZ93FgUIe97onX9nUceSXf23ESKmpZDFQXS 0rSzmAG2hEV3J8IGKQUGcjWaW2Czv6Te+9TxPQ+bIfomwP55NYIRjWwNR/6+qB3WZN Oo9IA0JTCsQo0QqepLS9wgEyOy+m58czDl8FRh4hGmNuntFlrRwodsKtkjnfPAdMw0 ynBEwbuqOpR5V5Z1YHWSu2R+LlOTGl3ZFa/mG6+x1XgWpgBo8O2Tt+fnaC4kJiVPhL B+e3stH+aDOAFmw7lvKIazYYtEf2fBHP0cjpecKz4ksLX+/cYhQeEyy7STb8L87ScG DyrAh7eZF8sbw== Message-ID: Date: Mon, 1 Jun 2026 10:50:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 19/22] mm/page_alloc: implement __GFP_UNMAPPED allocations Content-Language: en-US To: Brendan Jackman , Brendan Jackman , Borislav Petkov , Dave Hansen , Peter Zijlstra , Andrew Morton , David Hildenbrand , Wei Xu , Johannes Weiner , Zi Yan , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, rppt@kernel.org, Sumit Garg , derkling@google.com, reijiw@google.com, Will Deacon , rientjes@google.com, "Kalyazin, Nikita" , patrick.roy@linux.dev, "Itazuri, Takahiro" , Andy Lutomirski , David Kaplan , Thomas Gleixner , Yosry Ahmed References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> <20260320-page_alloc-unmapped-v2-19-28bf1bd54f41@google.com> <7bfda0d8-2a7a-4337-8b55-d0c158df7839@kernel.org> From: "Vlastimil Babka (SUSE)" Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/29/26 17:02, Brendan Jackman wrote: > On Fri May 15, 2026 at 4:46 PM UTC, Brendan Jackman wrote: >> On Wed May 13, 2026 at 3:43 PM UTC, Vlastimil Babka (SUSE) wrote: > [...] >>> Uhh, speaking of compaction and reclaim... we rely on finding a whole free >>> pageblock in order to flip it. If that doesn't exist, the whole >>> get_page_from_freelist() will fail, and we might enter the >>> reclaim/compaction cycle in __allow_pages_slowpath(). But since we might >>> ultimately want an order-0 allocation, there won't be any compaction >>> attempted, because that code won't know we failed to flip a pageblock. And >>> the watermarks might look good and prevent reclaim as well I think? We >>> should somehow indicate this, and handle accordingly. Might not be trivial. >>> Or maybe reuse pageblock isolation code to do the migrations directly in >>> __rmqueue_direct_map? >> >> Ah, thanks, I suspect you are right. >> >> I did fear there would be some sort of case where this "not-quite >> reclaim" interacted badly with the actual reclaim, and I tried to test >> it by running some stuff in parallel with stress-ng (allocating >> __GFP_UNMAPPED via secretmem), and I didn't see a difference in the >> effective availability of memory. However, I suspect testing this is >> quite a deep art my "run these two commands that I copy pasted from an >> LLM suggestion" test was just crap. >> >> Do you have any workloads you can suggest for evaluating this kinda >> thing? We would definitely see it in Google prod (I think we see this >> kind of issue with our shrinker-based internal version of ASI distorting >> reclaim behaviour in ways even more subtle than this) but that is not a >> very practical experimental cycle... > > I slop-coded a benchmark: > > https://github.com/bjackman/kernel-benchmarks-nix/tree/master/packages/benchmarks/secretmem-vs-frag > > It does some mmap/munmap patterns to try and generate fragmentation, > then spams secretmem allocations until it gets OOM-killed. > > With this series, I see the OOM-kills happening noticeably sooner on a > 1GiB VM: > > metric: secretmem_allocated_bytes (B) | test: secretmem-vs-frag > +---------------------------------------------+---------+-------------+-------------+-----------------+-------------+-------+ > | kernel_release | samples | mean | min | histogram | max | Δμ | > +---------------------------------------------+---------+-------------+-------------+-----------------+-------------+-------+ > | 7.0.0-rc4-next-20260319 | 4 | 683,147,264 | 643,825,664 | █ | 715,128,832 | | > | 7.0.0-rc4-next-20260319-00028-gf00246eb72cd | 3 | 623,553,195 | 551,550,976 | ███ | 692,060,160 | -8.7% | > +---------------------------------------------+---------+-------------+-------------+-----------------+-------------+-------+ > > So... I think maybe I've reproduced the issue you pointed out? I will > try and fix it and see if this degradation goes away. Since I assume the fragmentating allocations are movable allocations, it might be the case, yeah.