From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D2E2FF65F for ; Fri, 24 Jul 2026 11:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892849; cv=none; b=qImFCX/VMQ65m9f3WMKmsSNHqwyA835SFxrfLoZxKbYCjReRgDfVL4LjcJ052gTClBuEY8GS3m/QiRhS130IQTnPp9ytQ1PB3uTZYCN1IA05poM3VOQ7KlAgHb9ikolK1FLYrbMB53I/e85ONYQfUSoq2Ry3g5cPCcVjJboD56U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784892849; c=relaxed/simple; bh=scwsC0kid1BqQ0jPwRVLCGl8q/xTqF5Xfjr6ts2eH8Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TmC5Zv6ZfX6bd+C9MX7sYjVG75UNyT1ad5N1bkcIwtJLiMkL281bKcDOQGe+JWec7ZA4hD8t1iNdUPM8JFE25od+xjdf83NoJYA9rh7piNCuenENMCo9nS7lA3TmlQZcDt7hnpoiFK/ZzbxRqpX5g2h62icX/TrSC1cuSEhFFBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=d3m5tca/; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=I7B6/acy; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Hm9QSQvU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=vzCW8Q7F; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="d3m5tca/"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="I7B6/acy"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Hm9QSQvU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="vzCW8Q7F" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DD56E7B716; Fri, 24 Jul 2026 11:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784892844; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DFCWad4wPj8DgFEN1bHucIT8UKMjgs/taKdLP4BaGfw=; b=d3m5tca/ojKlj1g2MxP0J53FRZERf0rxnXmNEryU51wIZphMxjDzU5E1w2aD6am+EuVz+6 bT5Utrg7YN/r4iuNokQwo7XAVBLgao6aKjsnJNfTwsXmSlQm80nta2rHNAnP8k4sdnvr79 xdjKtq+t6rY0WGYl9ohLQy7xoPQgrw4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784892844; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DFCWad4wPj8DgFEN1bHucIT8UKMjgs/taKdLP4BaGfw=; b=I7B6/acyWcJNIIxA2lsmWdpm1izePAb9Z5QX7KAx7WFJh72VGkWtwuhIAlh6ghaeIixsw3 U4H1jsIrkSiWvsBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Hm9QSQvU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vzCW8Q7F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784892842; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DFCWad4wPj8DgFEN1bHucIT8UKMjgs/taKdLP4BaGfw=; b=Hm9QSQvUGeDjyA8ijwdaWnjC4DF4vFzB1sdfnHX/fgQRlSCGHMuAjfIsVrONzEZPKZZYsE YtlSPt7f/uWaz1Zaf3nDAAJwmph/BUGuOJZKAWaFLXcCzKd9iRM7i+M/L5CaoFSb52mubI Q2kscoVq6++WuXIOx/+0tMue1ZQcZaU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784892842; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DFCWad4wPj8DgFEN1bHucIT8UKMjgs/taKdLP4BaGfw=; b=vzCW8Q7F3F3UXxQrz3Nmecj2oCQAib1CNYv0iO+J74UnX976EWNJyfsUeVsJQPZ/2u+SWv IdsXuEQcOC7J1vDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D440779BA; Fri, 24 Jul 2026 11:34:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NI2nJKpNY2o6MgAAD6G6ig (envelope-from ); Fri, 24 Jul 2026 11:34:02 +0000 Message-ID: Date: Fri, 24 Jul 2026 13:34:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/sysfb: ofdrm: Fix is_avivo() constant comparison bug To: oushixiong1025@163.com Cc: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.or, linux-kernel@vger.kernel.org, Shixiong Ou References: <20260724094140.799730-1-oushixiong1025@163.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260724094140.799730-1-oushixiong1025@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[163.com,gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[163.com]; RCPT_COUNT_SEVEN(0.00)[9]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[redhat.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,lists.freedesktop.or,vger.kernel.org,kylinos.cn]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,bootlin.com:url,suse.de:mid,suse.de:dkim,suse.com:url,kylinos.cn:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Rspamd-Queue-Id: DD56E7B716 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action Hi Am 24.07.26 um 11:41 schrieb oushixiong1025@163.com: > From: Shixiong Ou > > The is_avivo() function has a logic error where it compares a constant > to another constant instead of checking the device parameter: > > (PCI_VENDOR_ID_ATI_R600 >= 0x9400) > > However, according to the code comment and the OFDRM_MODEL_AVIVO > definition ("ATI R5xx"), this function is intended to match only R5xx > cards (device IDs 0x7100-0x7800), not R6xx or later. The second > condition checking for R600 is erroneous and should be removed. > > Signed-off-by: Shixiong Ou > --- > drivers/gpu/drm/sysfb/ofdrm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/sysfb/ofdrm.c b/drivers/gpu/drm/sysfb/ofdrm.c > index a6dc34b9ec0f..ea1db1cfe3ed 100644 > --- a/drivers/gpu/drm/sysfb/ofdrm.c > +++ b/drivers/gpu/drm/sysfb/ofdrm.c > @@ -238,8 +238,7 @@ static bool is_avivo(u32 vendor, u32 device) > { > /* This will match most R5xx */ > return (vendor == PCI_VENDOR_ID_ATI) && > - ((device >= PCI_VENDOR_ID_ATI_R520 && device < 0x7800) || > - (PCI_VENDOR_ID_ATI_R600 >= 0x9400)); I tried to match exactly this: https://elixir.bootlin.com/linux/v7.1.4/source/drivers/video/fbdev/offb.c#L365 IDK if that works in practice, but I don't dare changing it without a concrete bug report. Best regards Thomas > + (device >= PCI_VENDOR_ID_ATI_R520 && device < 0x7800); > } > > static enum ofdrm_model display_get_model_of(struct drm_device *dev, struct device_node *of_node) -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)