From: Bart Van Assche <bvanassche@acm.org>
To: daejun7.park@samsung.com,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sang-yoon Oh <sangyoon.oh@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
yongmyung lee <ymhungry.lee@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
Adel Choi <adel.choi@samsung.com>,
BoRam Shin <boram.shin@samsung.com>
Subject: Re: [PATCH v8 1/4] scsi: ufs: Add UFS feature related parameter
Date: Sat, 8 Aug 2020 16:00:18 -0700 [thread overview]
Message-ID: <adb044b2-67e0-b451-332c-37789ded99f9@acm.org> (raw)
In-Reply-To: <231786897.01596705001840.JavaMail.epsvc@epcpadp1>
On 2020-08-06 02:02, Daejun Park wrote:
> @@ -537,6 +548,7 @@ struct ufs_dev_info {
> u8 *model;
> u16 wspecversion;
> u32 clk_gating_wait_us;
> + u8 b_ufs_feature_sup;
> u32 d_ext_ufs_feature_sup;
> u8 b_wb_buffer_type;
> u32 d_wb_alloc_units;
>
Hmm ... shouldn't this variable be introduced in the patch that introduces
the code that sets and uses this variable?
How about making it clear in the patch subject that this patch adds protocol
constants related to HPB?
Otherwise this patch looks good to me.
Bart.
next prev parent reply other threads:[~2020-08-08 23:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200806073257epcms2p61564ed62e02fc42fc3c2b18fa92a038d@epcms2p6>
2020-08-06 7:32 ` [PATCH v8 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
[not found] ` <CGME20200806073257epcms2p61564ed62e02fc42fc3c2b18fa92a038d@epcms2p3>
2020-08-06 9:18 ` [PATCH v8 4/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2020-08-09 0:35 ` Bart Van Assche
2020-08-13 2:13 ` [PATCH v8 2/4] scsi: ufs: Introduce HPB feature Daejun Park
2020-08-13 3:00 ` Daejun Park
2020-08-13 3:22 ` Bart Van Assche
2020-08-06 9:52 ` [PATCH v8 0/4] scsi: ufs: Add Host Performance Booster Support Bean Huo
2020-08-06 9:56 ` Avri Altman
2020-08-06 10:02 ` Bean Huo
2020-08-06 10:12 ` Avri Altman
2020-08-06 10:28 ` Bean Huo
2020-08-06 13:56 ` Avri Altman
2020-08-06 16:36 ` Alim Akhtar
2020-08-06 18:39 ` Bart Van Assche
2020-08-07 4:32 ` Martin K. Petersen
[not found] ` <CGME20200806073257epcms2p61564ed62e02fc42fc3c2b18fa92a038d@epcms2p5>
2020-08-06 23:15 ` Daejun Park
[not found] ` <CGME20200806073257epcms2p61564ed62e02fc42fc3c2b18fa92a038d@epcms2p2>
2020-08-06 9:15 ` [PATCH v8 3/4] scsi: ufs: L2P map management for HPB read Daejun Park
2020-08-09 0:29 ` Bart Van Assche
2020-08-13 3:13 ` Daejun Park
2020-08-13 3:15 ` [PATCH v8 4/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2020-08-06 9:02 ` [PATCH v8 1/4] scsi: ufs: Add UFS feature related parameter Daejun Park
2020-08-08 23:00 ` Bart Van Assche [this message]
2020-08-06 9:11 ` [PATCH v8 2/4] scsi: ufs: Introduce HPB feature Daejun Park
2020-08-08 22:56 ` Bart Van Assche
2020-08-09 0:07 ` Bart Van Assche
2020-08-13 2:16 ` [PATCH v8 1/4] scsi: ufs: Add UFS feature related parameter Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adb044b2-67e0-b451-332c-37789ded99f9@acm.org \
--to=bvanassche@acm.org \
--cc=adel.choi@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=boram.shin@samsung.com \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sangyoon.oh@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
--cc=tomas.winkler@intel.com \
--cc=ymhungry.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®