From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1A8C4C80; Thu, 5 Sep 2024 06:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725516942; cv=none; b=ScuvrRANZUQey03aBbfpkH94n0gKmD+fZorKj0imvyd2V74boZ9V3qSsXWYoCwib462wLYxFCf8QTuNFkIhXoxLlRL2rS9soYBju6DDB+6yikRmOG/k89YAWM6nmEUJHvJ+N6VwA9Ljh248PJMDSvTM95UY7N/0VbOByWAgJZ4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725516942; c=relaxed/simple; bh=9aHNHVkze1BhIJG/QnTZnftNpwk0qaooXgopN1G7imw=; h=Message-ID:Date:MIME-Version:Subject:From:To:CC:References: In-Reply-To:Content-Type; b=WdQZMtgpIz3zItnw3LzuOZAMbP0PGqUxfwPhCp8EqEZOIQy2Xnt8DB5NRASYMJnYjFbqEntbVRvs7aFQRpm6ZsGT/gnv8vrMRwiPfLnjCBT8PFlwUSizIwTpaI/yp+St3HkgatNKdNh/eOyGmdZXYoYDkHNg6RWm5d8qCDHQYHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=eqgBmWwu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="eqgBmWwu" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4852QAEo005926; Thu, 5 Sep 2024 06:15:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Kw6N4ezchqagxVwAc6Ws23rAHbZyEPmlc6cL8apff6g=; b=eqgBmWwuWN4K+Vf7 HgdCzasHdCOQg4Bxz7NDulJep4zJUAMnRlKJTSvDaEwkw3S1vqRI1f5+atbGUOzY 6a+aVxommaGFtReCh9AmKanHqOTRhnHe1CPYNoYS9p5lnerFbqYrnKBhKlmey6rI gl1HNxQ/FxCT4AnKA34VrL2AYXDxr/UbOiJNRVqChE2uIdBho0P/XJYjubSbm1ex /EzAZIg8tl+g4iTPoNJ7ECz21pxjqFKpBWyL0ZKjwlCwGsM4ScaeVcYgA5/8nHrb pgh6csCpsZ+OBaeO7gCd23OXFR5/+dK7QW6mrhYtlMz+336R0+z2Sd95JF7qhqO4 f8qa3w== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41epwe2cv8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Sep 2024 06:15:34 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4856FX8A032153 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Sep 2024 06:15:33 GMT Received: from [10.216.46.64] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 4 Sep 2024 23:15:29 -0700 Message-ID: Date: Thu, 5 Sep 2024 11:45:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 03/29] media: iris: add platform driver for iris video device Content-Language: en-US From: Dikshita Agarwal To: Dmitry Baryshkov , Bryan O'Donoghue CC: Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , "Rob Herring" , Krzysztof Kozlowski , "Conor Dooley" , Philipp Zabel , , , , References: <20240827-iris_v3-v3-0-c5fdbbe65e70@quicinc.com> <20240827-iris_v3-v3-3-c5fdbbe65e70@quicinc.com> <74126160-57f9-4abf-a26c-3491c8f3dd78@linaro.org> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: egusa6IZ5Rm9n3aPpnuZHt26IxGPhtIy X-Proofpoint-GUID: egusa6IZ5Rm9n3aPpnuZHt26IxGPhtIy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-05_04,2024-09-04_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2409050043 On 9/5/2024 11:42 AM, Dikshita Agarwal wrote: > > > On 8/29/2024 2:43 PM, Dmitry Baryshkov wrote: >> On Tue, Aug 27, 2024 at 03:08:03PM GMT, Bryan O'Donoghue wrote: >>> On 27/08/2024 11:05, Dikshita Agarwal via B4 Relay wrote: >>>> +static const struct of_device_id iris_dt_match[] = { >>>> + { .compatible = "qcom,sm8550-iris", }, >>>> + { .compatible = "qcom,sm8250-venus", }, >>>> + { }, >>>> +}; >>>> +MODULE_DEVICE_TABLE(of, iris_dt_match); >>> >>> The enabling patch for the compat strings should come last - if its first >>> then the time between the compat add and the last patch is a dead zone where >>> things are bound to break on a booting board. >> >> But then it's impossible to test the driver in the interim state. >> Moreover enabling it at the end only makes it hard to follow platform >> data changes. What about adding sm8550 at this point and adding sm8250 >> at the end? Or enabling qcom,sm8550-iris and the fake qcom,sm8250-iris >> now (and clearly documenting it as fake) and as the last patch change it >> to qcom,sm8250-venus. > > Sure, we will add qcom,sm8250-iris at this point so that it enables the > testing of the driver, and will add one patch at the last to add > qcom,sm8250-venus. Sorry fixing the typos. what I meant was, we will add qcom,sm8550-iris at this point so that it enables the testing of the driver, and will add one patch at the last to add qcom,sm8250-venus. > > Thanks, > Dikshita >> >