From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BD461BC39 for ; Mon, 9 Sep 2024 16:08:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725898102; cv=none; b=FYUVLQIIWIMI1zfNzZfyc7Dbc3Cd8M2vVKyAM/7s9d6CRHTW6kAMXiHwi+Uk6t6MDCTkjRVlj82c/VBdzBtWoMAenP96HVNMZ54hOSh3/2xfMqvEdq+BAkJRWH9aEmeo97H/a6y2zl7cA376uQ+WAeRNwKxziVfqhQX5j2xd8oY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725898102; c=relaxed/simple; bh=oedIX6uAWwQ5NPlDFPjLpUk46TfdFMO2UIdsrGksh+0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KlFUb0ke1o1yfRdB1Z2OYtplHKC40faJ5glGHKwGtwsAI8hd9qZ1ExVIs5qzyyeikPZ4GHc8OkOxI4m6CDWsxlMUykb/Uj8cA/jxN8koljblvqbFi/vnwoaLV1A88F+V3IBYaZ87bwbNh+u4KIbZDaxYBhzcvXJRKbh1migMCPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UG5ypbNa; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UG5ypbNa" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-374c6eb1d44so123090f8f.1 for ; Mon, 09 Sep 2024 09:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725898097; x=1726502897; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=XT5l8P6NzbjGGFiTNVLcXv6l+wRZ27lZ2toZJg0ywbE=; b=UG5ypbNaxHv3+5WRhTirKgAaWUYP8d9MTR9IMWeIBLSJYfImYWL8L6awR5BHLZyGzF YLRKubwni93MJ37ZfsxyN5WW3no4b4TXzhNF09KMSNN84H8Vw0pcKumAe0kFOSPddiKW SmTCEAJpWiN85l6/VOuvMGz+haaA+Rnu9VAN4ojHq1W15rj8XvOs/eeGlNfWf0F3HCmh O8uTzU1f0rh7GpJH51W4xOlZObv06FoHUn+wOMQNEMB1xVEbmAkZ0r/wQ0V7HyYgWPIx pEhdgsjVh3RcAiPxS75RVL/GUR1qbp3hCSvPE8GiGuZNCWJvCvKZZTsb45n2o7KrupJE Nhtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725898097; x=1726502897; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XT5l8P6NzbjGGFiTNVLcXv6l+wRZ27lZ2toZJg0ywbE=; b=gTOtsGbEd1IELwefyjH+F3YpwEBcOa/rpc0lm8dsY2Nuui9uDirLKS29yhUrGtzP78 d+3suYHrTM1zPtHp7ayXqAvkMBn9cpXDrKGa9IMrUCV6WHg+oRbrBwi8Z5fxYeZfvwco +EF0e/BLnSFQXWLaemZoV2YsdxmhHY/iP5Y8SWnJwmwJKWSUPquX193PNCMJdodcN86C muDQVFiLCH2Rw8Q7q+w8JnQ0f9mTywn64qcTSL7aZFSfmp/LD/2QAl873zn6KzIbpRqj Lx+JrToX1lLRu/TCBzGmqtNosYso2u0HlaxgMzqx9Wl6Ziio9LsZQRQmIuETUGDEnr+v fevQ== X-Forwarded-Encrypted: i=1; AJvYcCVU6skA7F5oNu9MnxW6pusNuxxROD1a2J1bL5lamWkiT6q337D8Qjm2zsh0SWfKN5t48Qu95gHXo/clL2M=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7GvFXRQuzl2K0ESBJE0z8Hz0T5dd2DAwuFVivMDjNNPoA1ifx mlgYZ2kbDg4aCLK9lkf2nBRPO5B4MGxoOf/+aO6HdmPz+r9WBWqs8xoV0EWlBtA= X-Google-Smtp-Source: AGHT+IGMTZqgOJO2exltKV8g17LnzhtBMAzSkWU0AQcVhbO6zcCCl+H5Zok6BiW3wg3dWxEGKIHLCQ== X-Received: by 2002:a5d:6d08:0:b0:378:955f:d243 with SMTP id ffacd0b85a97d-378955fd2damr2224248f8f.13.1725898096574; Mon, 09 Sep 2024 09:08:16 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378956d3700sm6396046f8f.88.2024.09.09.09.08.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2024 09:08:15 -0700 (PDT) Message-ID: Date: Mon, 9 Sep 2024 18:08:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soundwire: stream: Revert "soundwire: stream: fix programming slave ports for non-continous port maps" To: Pierre-Louis Bossart , Charles Keepax Cc: Vinod Koul , Bard Liao , Sanyog Kale , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, "stable@vger.kernel.org" References: <20240904145228.289891-1-krzysztof.kozlowski@linaro.org> <8462d322-a40a-4d6c-99c5-3374d7f3f3a0@linux.intel.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <8462d322-a40a-4d6c-99c5-3374d7f3f3a0@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/09/2024 17:45, Pierre-Louis Bossart wrote: > > > On 9/9/24 16:36, Charles Keepax wrote: >> On Wed, Sep 04, 2024 at 04:52:28PM +0200, Krzysztof Kozlowski wrote: >>> This reverts commit ab8d66d132bc8f1992d3eb6cab8d32dda6733c84 because it >>> breaks codecs using non-continuous masks in source and sink ports. The >>> commit missed the point that port numbers are not used as indices for >>> iterating over prop.sink_ports or prop.source_ports. >>> >>> Soundwire core and existing codecs expect that the array passed as >>> prop.sink_ports and prop.source_ports is continuous. The port mask still >>> might be non-continuous, but that's unrelated. >>> >>> Reported-by: Bard Liao >>> Closes: https://lore.kernel.org/all/b6c75eee-761d-44c8-8413-2a5b34ee2f98@linux.intel.com/ >>> Fixes: ab8d66d132bc ("soundwire: stream: fix programming slave ports for non-continous port maps") >>> Signed-off-by: Krzysztof Kozlowski >>> >>> --- >> >> Would be good to merge this as soon as we can, this is causing >> soundwire regressions from rc6 onwards. > > the revert also needs to happen in -stable. 6.10.8 is broken as well. It will happen. You do not need to Cc-stable (and it will not help, will not be picked), because this is marked as fix for existing commit. Best regards, Krzysztof