mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Hoegeun Kwon <hoegeun.kwon@samsung.com>,
	inki.dae@samsung.com, airlied@linux.ie, kgene@kernel.org,
	krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
	catalin.marinas@arm.com, will.deacon@arm.com
Cc: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible.
Date: Thu, 07 Sep 2017 13:27:45 +0200	[thread overview]
Message-ID: <adb813cf-e4f3-a9c6-1f7a-8c6d1638c28c@samsung.com> (raw)
In-Reply-To: <1504777143-29834-3-git-send-email-hoegeun.kwon@samsung.com>

Hi Hoegeun,

On 2017-09-07 11:39, Hoegeun Kwon wrote:
> Exynos 5250 and 5420 have different hardware rotation limits. However,
> currently it uses only one compatible - "exynos5-gsc". Since we have
> to distinguish between these two, we add different compatible.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>

The new values (5250/5420 specific) should replace old exynos5-gsc, 
there is no
point providing both in dts.

> ---
>   arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
>   arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
>   2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 8dbeb87..f795c76 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -637,7 +637,7 @@
>   		};
>   
>   		gsc_0:  gsc@13e00000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
>   			reg = <0x13e00000 0x1000>;
>   			interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
>   			power-domains = <&pd_gsc>;
> @@ -647,7 +647,7 @@
>   		};
>   
>   		gsc_1:  gsc@13e10000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
>   			reg = <0x13e10000 0x1000>;
>   			interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>   			power-domains = <&pd_gsc>;
> @@ -657,7 +657,7 @@
>   		};
>   
>   		gsc_2:  gsc@13e20000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
>   			reg = <0x13e20000 0x1000>;
>   			interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
>   			power-domains = <&pd_gsc>;
> @@ -667,7 +667,7 @@
>   		};
>   
>   		gsc_3:  gsc@13e30000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
>   			reg = <0x13e30000 0x1000>;
>   			interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
>   			power-domains = <&pd_gsc>;
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 02d2f89..86afe77 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -658,7 +658,7 @@
>   		};
>   
>   		gsc_0: video-scaler@13e00000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc";
>   			reg = <0x13e00000 0x1000>;
>   			interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
>   			clocks = <&clock CLK_GSCL0>;
> @@ -668,7 +668,7 @@
>   		};
>   
>   		gsc_1: video-scaler@13e10000 {
> -			compatible = "samsung,exynos5-gsc";
> +			compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc";
>   			reg = <0x13e10000 0x1000>;
>   			interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>   			clocks = <&clock CLK_GSCL1>;

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

  reply	other threads:[~2017-09-07 11:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170907093912epcas2p4575c6910bfa240105083e407e1b62d10@epcas2p4.samsung.com>
2017-09-07  9:39 ` [PATCH v2 0/3] drm/exynos/gsc: Support the hardware rotation limits Hoegeun Kwon
     [not found]   ` <CGME20170907093912epcas2p3696ae1d6750c796dc2207747f3421d3c@epcas2p3.samsung.com>
2017-09-07  9:39     ` [PATCH v2 1/3] [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version Hoegeun Kwon
     [not found]   ` <CGME20170907093912epcas2p2c012de3af3915a58d889c2d48e283705@epcas2p2.samsung.com>
2017-09-07  9:39     ` [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible Hoegeun Kwon
2017-09-07 11:27       ` Marek Szyprowski [this message]
2017-09-08  2:48         ` Hoegeun Kwon
2017-09-09 19:57       ` kbuild test robot
2017-09-13  2:31         ` Hoegeun Kwon
     [not found]   ` <CGME20170907093912epcas2p198ae12fc11fb2b8a7a9e8d6be817e796@epcas2p1.samsung.com>
2017-09-07  9:39     ` [PATCH v2 3/3] drm/exynos/gsc: Add hardware rotation limits Hoegeun Kwon
2017-09-07 11:30       ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adb813cf-e4f3-a9c6-1f7a-8c6d1638c28c@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=airlied@linux.ie \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hoegeun.kwon@samsung.com \
    --cc=inki.dae@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®