From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF7F231A7E2 for ; Tue, 23 Jun 2026 16:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782233235; cv=none; b=N2PZ+im8Xl/w9e/pZd6wffjSWykl/cnnqaa94TnMGBREZ+ne5kaYEZcmKyM2uWUjt31epP1iaroZzpkCEBdfZtKZjHycjUQubihyWYQvbM0ijvh97gbrVkVKBPriZEm9MuwogJmUmrwXFwWC+xvEYbrBpDtPJzb2v1tpkXcl7fA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782233235; c=relaxed/simple; bh=ickOgqp7e7FCZNO3eNjSwNBANQsKvA/8RRTMthmVMuI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ToQfY8cCp8sXOEDivL9Ij9hAJ2dz/9fVVwxxzViSDc2DJX4YM9zHeydwF2dBmB3gJrqMINCj3fbGSVzrBQDUycCV1yxstAVgTVuMCSWBT2bNHlcBTm5CBhjENhmma+H6W1hOFeL7SY4LdWgQ80U3t1MoVrsouxUglVBkK0uMAGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pDY3yLV8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JgfwZ3TG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pDY3yLV8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JgfwZ3TG" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBZiVO4052828 for ; Tue, 23 Jun 2026 16:47:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SNCnasIGge6iLQlgIEDujkQhHNFEgY5Q07iOwzqg3uE=; b=pDY3yLV8p6AaPYor 6i1WnaLjwRgDHl+AqULKrA+SvQ7QGs7OtcgUPlg+oCSRXyETLuz1MldKJ9cw1ZUs Wgj18jmlMuxQ3ohXl7BfanVmjD2x2JjEVq8ZLMn/uC74mDpMeS6a2i/HzGIyhAP/ I1WR8eE3wwTbp6aywJR0NKUdycz6bPQMrE9ds+fD7Eon3UBWOJ9bbJWOO+qZDzIb ymQpl9HsYzYldCHlqXXIxOnPcFqm+Oe1pMxLK1otiphDTPjVu1PBVxYSPPggBjLg urGCm+rqwf4hHkvxLLUq7F5PjaZpzobeneMMnyUW/8A7jA42ekDRb/ay2cdUjFI+ vH9yQw== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyr9yskdq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 16:47:12 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-6c4271166f3so11128137.0 for ; Tue, 23 Jun 2026 09:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782233232; x=1782838032; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SNCnasIGge6iLQlgIEDujkQhHNFEgY5Q07iOwzqg3uE=; b=JgfwZ3TGKhS4U/hVxJd/9NsDja7x77IM9zCIXDVyA49wEZIV+M+YeIf9c7K76iBV7s Lh28hkQm0TXdcvXldcBdhlcwJ6fChqPxboorA7D12NcRPy7o5Er5igmrjEnnv58UKqZz eqOheEuAGN/GB4zCx2GrHXtkWYIW44+fVeRGgi+cYVYOa90wiMVwv46IjzTHocOS/KKu dBhtqellyjydG7MKfxsdrNfQX8jqmaJd5NWGrHreAKah38LqldkfEiIinnFHo40KOFhl rF2Dmmzt92qSTyQC5/sbw1V/0wdjNnzx+d65QbbUo3AM1aYg9XAyfjd7RcSQ5KFDdOcb m1bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782233232; x=1782838032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SNCnasIGge6iLQlgIEDujkQhHNFEgY5Q07iOwzqg3uE=; b=Vnk3zWC+DYT0QTJIMuw5xbSigwZfHMDaGBxu4J1aFozDlkbkzOdihWWPN1L5C31V9/ WqtTCoJh5V05BEiJw66IVqBiXKS+SRZMHpoTAvYa3xddCwHQIPP5EHbHAIemb+mS02gM mTyvWAFMv+sTdKgxG0iy4pSyRBlzW9JMLiSMKy3LZ4aOuBN96kms15y0WuNXdse5bl8T rFQXVBVeLYmZKVz7jTLSEkGs07kfiiZV77FXp70DQakYtEIeN/wcqzLkeUWuuVcuFOLy fneH/U/1v6OdnEG9akkukLVe5XUebxAzj8jZ1TYdwDkoC4BmSshSVwOaxQze0lcYk1Qx +lpg== X-Forwarded-Encrypted: i=1; AFNElJ9ZfennPLK43wUqmAvpz+1SkLa24hyioYkmX/glDgYIb4ighCtXA2mnADyoJoYAq+f6HgQRmOzHGMPct/A=@vger.kernel.org X-Gm-Message-State: AOJu0YyiKvQp9nNt+iZf4qveXj52FTeiEiuWOn6WcSih91+FtSVBrhBS +S/REezCIEavXHvhrBqN5tQF4sEnveCz3bvjUdUrybE8lllJNDfFHfvMkL0JjllcwEjWL1yl9pB JIqyYOYnRcHYLlTdd67qgDac2Y3pp6KmfGaJ2QihTWuqN4KsRe905WpoWhETAZtROfNNArHxFN2 Y= X-Gm-Gg: AfdE7ck/Zbgfm3BKHSe6ATU7RpPp3zhvW53y9rPF3bSwAP317el4QRmjbVRm44bU4hE tP3objuKTzC3bkqEW++Ya0G0drQoMECHEdWcNeTf+5yDrXGVRXRXnsT84ZaZsxkCq0CnbIXJXIj XzkpAtQKRc1nxyCrIIeeoLRrwOUBIl6CmUzYNLk2GL84cwr/AM1t8XswrphGs9vYDG/l5wb1ufB M83yc4MxFpjmTX4o0XppJqoDkjEvAoR6bzEtt+6GGIyOLdEDI6qWrxSmyUW4rvz4VTCIQYrSHEO Rb10SA9uG4YkQWWr2DAa+fun3fr0c1VsvKO6MSjis8lDI6uCcoGQWZ0QxUk/jhfu4JyQX2Ee7Nz t6bPTilh2/rlk7swk3HZIx1+Ouus9h+WyD54= X-Received: by 2002:a05:6102:5715:b0:632:8717:e553 with SMTP id ada2fe7eead31-72f3b6a9e65mr1438690137.7.1782233231938; Tue, 23 Jun 2026 09:47:11 -0700 (PDT) X-Received: by 2002:a05:6102:5715:b0:632:8717:e553 with SMTP id ada2fe7eead31-72f3b6a9e65mr1438685137.7.1782233231529; Tue, 23 Jun 2026 09:47:11 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1002d6c5f6sm195658166b.49.2026.06.23.09.47.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 09:47:10 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 18:47:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] iommu/qcom: Add NULL ctx check in TLB invalidation paths To: Mukesh Ojha , Rob Clark , Will Deacon , "Joerg Roedel (AMD)" Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> <20260623122034.1166295-7-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623122034.1166295-7-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JYSMa0KV c=1 sm=1 tr=0 ts=6a3ab890 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=5zc1ivFRGWfvx6kDekkA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-GUID: 09oAoCBDwO6r1icvzico_JLJTNW4xFwo X-Proofpoint-ORIG-GUID: 09oAoCBDwO6r1icvzico_JLJTNW4xFwo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEzNyBTYWx0ZWRfXx/CgACwJU7TB 5fSzvI8wIhMefjzeijnby3/sxFXMqTc0sK1DkD0DW2bm9Bq4qlzlUqpXQpIus7/I66B6JueRjr6 LQdDDPMb183BiRn/tY+43rw1wd+bovbjIqTYt+dZfhWIvCpI6ExCpFIPTMMrIH75pVtKlkXqDSG bC0SfiMNU3VR1/Q9IecanTdKR9d5WxYAboesdy6srEqmeXXM4wPr8OPYbTu5Zzhqfq9lO64rs2J PbGRuzKqenMVyFQLN3RtJ9acWrvIlNx2is5qjfuaX9AkUBmy1BT3v+oWxpK8VBW5Sff5ChrE1Hg aChs17xubFJHuWd9910sx919VBOy2w9Hkldy+eVBuNuEccQusnbnT0VVU1WIV/Dx+qtI0Qp4s/J fSricv2ztDd7og7jnNhl37/nkc/Hxvf9ibuYrBfdINvPHebMTQ3WXPN0K11e9VhLAFTGggtZYHM A/yWqwk5IpYgaMCAabQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEzNyBTYWx0ZWRfX4h/hLxVPMjVb TYBeKyKRxsMT1c2qW7fE/vYdLnbRSaslS1tlx97RVKMEcCWgtE6svsMXY2EQYxhbLa3kMSBeKAQ z53EFg693fMMbKV+BwfObxg03aSl2AU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230137 On 6/23/26 2:20 PM, Mukesh Ojha wrote: > to_ctx() returns qcom_iommu->ctxs[asid], which can be NULL if the > corresponding context bank failed to probe or was already removed. > qcom_iommu_tlb_sync(), qcom_iommu_tlb_inv_context(), and > qcom_iommu_tlb_inv_range_nosync() all dereference the returned pointer > directly, risking a NULL pointer dereference. > > Add WARN_ON(!ctx) guards with continue so TLB operations skip > broken context banks without crashing. > > Signed-off-by: Mukesh Ojha > --- > drivers/iommu/arm/arm-smmu/qcom_iommu.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c > index 40fb0408dc07..51b60b296bb8 100644 > --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c > +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c > @@ -121,6 +121,9 @@ static void qcom_iommu_tlb_sync(void *cookie) > struct qcom_iommu_ctx *ctx = to_ctx(qcom_domain, fwspec->ids[i]); > unsigned int val, ret; > > + if (WARN_ON(!ctx)) > + continue; I'm rather unamused that we have to deal with this in the first place.. I don't know if this can be easily reworked to be more predictable, but this works in the interim Reviewed-by: Konrad Dybcio Konrad