mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Clément Léger" <cleger@meta.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] io_uring/net: Add bundle support for multishot recvmsg
Date: Tue, 17 Nov 2026 14:20:17 +0100	[thread overview]
Message-ID: <adcaa022-50c5-4754-93a6-a4365ccd09c4@meta.com> (raw)
In-Reply-To: <9e96afba-66cf-4812-b14c-faa2958caa06@kernel.dk>

On 11/17/26 13:26, Jens Axboe wrote:
> > 
> On 11/17/26 5:06 AM, Cl?ment L?ger wrote:
>> On 11/17/26 03:45, Jens Axboe wrote:
>>>> On 11/16/26 4:17 AM, Cl?ment L?ger wrote:
>>>> IORING_RECVSEND_BUNDLE was disabled for IORING_OP_RECVMSG because the
>>>> envelope and control-message sizing was not implemented. Enable
>>>> bundled multishot recvmsg by reserving its metadata in the first buffer
>>>> and accounting for payload spread across the selected buffer run.
>>>
>>> Patch 1 is fine (though both need rebasing against for-7.5/io_uring),
>>> but a few notes on this one:
>>>
>>
>>> 2) Why not support incremental buffer rings?
>>
>> I deliberately left it since it required more wiring/modifications. I
>> can add it in the next version though.
> 
> I think it's much better if it's complete. As a user, there's nothing
> more annoying than having random features only work with a subset of
> others. It's confusing!

Yeah, make sense, it is not actually that much work !

> 
>>> And the usual, do you have a liburing test and man page updates as
>>> well?
>>
>> Yes indeed, I have liburing tests, just didn't to send them right
>> away. I'm missing the man page update though. I'll add it for V2
> 
> Great!
> 
>>> A minor note is that the commenting is a bit excessive... I'd prune
>>> that for v2.
>>
>> I'd usually remove them but they mostly seemed useful to me. I'll
>> prune that.
> 
> They seem a bit LLM excessive to me. Just something to keep an eye on. I
> like them to be shorter and concise, leave the bigger explanations for
> the commit messages, if required.

Acked, thanks for the advice !

Clément


      reply	other threads:[~2026-11-17 13:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 11:17 [PATCH 0/2] " Clément Léger
2026-11-16 11:17 ` [PATCH 1/2] io_uring/net: Factor out receive buffer selection Clément Léger
2026-11-16 11:17 ` [PATCH 2/2] io_uring/net: Add bundle support for multishot recvmsg Clément Léger
2026-11-17  2:45   ` Jens Axboe
2026-11-17 12:06     ` Clément Léger
2026-11-17 12:26       ` Jens Axboe
2026-11-17 13:20         ` Clément Léger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adcaa022-50c5-4754-93a6-a4365ccd09c4@meta.com \
    --to=cleger@meta.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®