mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Mark Brown <broonie@kernel.org>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: sumit.semwal@linaro.org, gregkh@linuxfoundation.org,
	arve@android.com, riandrews@android.com,
	dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH v4 2/2] staging: ion: create one device entry per heap
Date: Tue, 26 Sep 2017 11:08:34 -0700	[thread overview]
Message-ID: <adcb091c-ce01-1e04-2cc2-8c36f67433f3@redhat.com> (raw)
In-Reply-To: <20170926161701.aegnk3kb3fpgz4uy@sirena.org.uk>

On 09/26/2017 09:17 AM, Mark Brown wrote:
> On Tue, Sep 26, 2017 at 02:07:05PM +0200, Benjamin Gaignard wrote:
> 
>> version 4:
>> - add a configuration flag to switch between legacy Ion misc device
>>    and one device per heap version.
> 
> Should this be a switch or should it just be enabling and disabling the
> legacy device with the per heap ones always availalbe?  I can't see that
> the new devices would do any harm or have trouble interacting with the
> per heap ones.  Being able to have both enabled would make things easier
> for userspaces that are moving to the device per heap interface.
> 

Agreed. We should be enabling the new interface unconditionally. The
old /dev/ion interface should coexist to allow for backwards
compatibility but keep it under a Kconfig to allow it to be turned off
for security or other reasons.

Thanks,
Laura

      reply	other threads:[~2017-09-26 18:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26 12:07 [PATCH v4 0/2] staging: ion: get one device " Benjamin Gaignard
2017-09-26 12:07 ` [PATCH v4 1/2] staging: ion: simplify ioctl args checking function Benjamin Gaignard
2017-09-26 12:07 ` [PATCH v4 2/2] staging: ion: create one device entry per heap Benjamin Gaignard
2017-09-26 16:17   ` Mark Brown
2017-09-26 18:08     ` Laura Abbott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adcb091c-ce01-1e04-2cc2-8c36f67433f3@redhat.com \
    --to=labbott@redhat.com \
    --cc=arve@android.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®