From: Juergen Gross <jgross@suse.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] xen: Two possible sleep-in-atomic-context bugs in bind_evtchn_to_irqhandler()
Date: Wed, 20 Jun 2018 08:57:12 +0200 [thread overview]
Message-ID: <add28699-59bc-dde7-e521-f21f550c8562@suse.com> (raw)
In-Reply-To: <80315b22-63c1-c8cc-1035-11fa36bee83a@gmail.com>
On 20/06/18 04:49, Jia-Ju Bai wrote:
> The driver may sleep with holding a spinlock.
> The function call paths (from bottom to top) in Linux-4.16.7 are:
>
> [FUNC] mutex_lock_nested --> can sleep
> drivers/xen/events/events_base.c, 839: mutex_lock_nested in
> bind_evtchn_to_irq
> drivers/xen/events/events_base.c, 1030: bind_evtchn_to_irq in
> bind_evtchn_to_irqhandler
> drivers/xen/pvcalls-front.c, 371: bind_evtchn_to_irqhandler in
> create_active
> drivers/xen/pvcalls-front.c, 417: create_active in pvcalls_front_connect
> drivers/xen/pvcalls-front.c, 410: spin_lock in pvcalls_front_connect
>
> [FUNC] request_irq --> can sleep
> drivers/xen/events/events_base.c, 1003: request_irq in
> bind_evtchn_to_irqhandler
> drivers/xen/pvcalls-front.c, 371: bind_evtchn_to_irqhandler in
> create_active
> drivers/xen/pvcalls-front.c, 417: create_active in pvcalls_front_connect
> drivers/xen/pvcalls-front.c, 410: spin_lock in pvcalls_front_connect
>
> These bugs are found by my static analysis tool (DSAC-2) and checked by my
> code review.
>
> I do not know how to correctly fix these bugs, so I just report them.
> Maybe create_active() should not be called with holding a spinlock.
Right, I think calling create_active() should be done before taking the
lock. Stefano, what do you think?
Juergen
prev parent reply other threads:[~2018-06-20 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 2:49 Jia-Ju Bai
2018-06-20 6:57 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=add28699-59bc-dde7-e521-f21f550c8562@suse.com \
--to=jgross@suse.com \
--cc=baijiaju1990@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®